You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/23 12:28:38 UTC
[GitHub] [dolphinscheduler] DarkAssassinator opened a new pull request, #11621: [DOC] should notice that need setting the full path when call the resource file #11620
DarkAssassinator opened a new pull request, #11621:
URL: https://github.com/apache/dolphinscheduler/pull/11621
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
fix #11620
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 merged pull request #11621: [DOC] should notice that need setting the full path when call the resource file #11620
Posted by GitBox <gi...@apache.org>.
EricGao888 merged PR #11621:
URL: https://github.com/apache/dolphinscheduler/pull/11621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on a diff in pull request #11621: [DOC] should notice that need setting the full path when call the resource file #11620
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on code in PR #11621:
URL: https://github.com/apache/dolphinscheduler/pull/11621#discussion_r953699816
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -24,7 +24,7 @@ Drag from the toolbar <img src="../../../../img/tasks/icons/shell.png" width="15
2. Check `Normal` for `Run Flag`. If `Prohibit Execution` is checked, the task will not execute when the workflow runs.
3. Select `Task Priority`: when the number of worker threads is insufficient, high priority tasks will execute first in the execution queue, and tasks with the same priority will execute in the order of first in, first out.
4. Timeout alarm (optional): check the timeout alarm, timeout failure, and fill in the "timeout period". When the task execution time exceeds **timeout period**, an alert email will send and the task timeout fails.
-5. Resources (optional). Resources are files create or upload in the `Resource Center -> File Management` page. For example, the file name is `test.sh`, and the command to call the resource in the script is `sh test.sh`.
+5. Resources (optional). Resources are files create or upload in the `Resource Center -> File Management` page. For example, the file name is `test.sh`, and the command to call the resource in the script is `sh test.sh`.Please note that you need to use the full path to the resource files.
Review Comment:
done
##########
docs/docs/en/guide/resource/file-manage.md:
##########
@@ -65,6 +65,8 @@ In the workflow definition module of project Manage, create a new workflow using
- Script: 'sh hello.sh'
- Resource: Select 'hello.sh'
+> Notice: When invoking a resource file in the script, the file name needs to be the same as the full path of the selected resource:
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11621: [DOC] should notice that need setting the full path when call the resource file #11620
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11621:
URL: https://github.com/apache/dolphinscheduler/pull/11621#issuecomment-1225625040
> done. Please review again. thx
LGTM, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on pull request #11621: [DOC] should notice that need setting the full path when call the resource file #11620
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on PR #11621:
URL: https://github.com/apache/dolphinscheduler/pull/11621#issuecomment-1225616491
done. Please review again. thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11621: [DOC] should notice that need setting the full path when call the resource file #11620
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11621:
URL: https://github.com/apache/dolphinscheduler/pull/11621#discussion_r953318393
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -24,7 +24,7 @@ Drag from the toolbar <img src="../../../../img/tasks/icons/shell.png" width="15
2. Check `Normal` for `Run Flag`. If `Prohibit Execution` is checked, the task will not execute when the workflow runs.
3. Select `Task Priority`: when the number of worker threads is insufficient, high priority tasks will execute first in the execution queue, and tasks with the same priority will execute in the order of first in, first out.
4. Timeout alarm (optional): check the timeout alarm, timeout failure, and fill in the "timeout period". When the task execution time exceeds **timeout period**, an alert email will send and the task timeout fails.
-5. Resources (optional). Resources are files create or upload in the `Resource Center -> File Management` page. For example, the file name is `test.sh`, and the command to call the resource in the script is `sh test.sh`.
+5. Resources (optional). Resources are files create or upload in the `Resource Center -> File Management` page. For example, the file name is `test.sh`, and the command to call the resource in the script is `sh test.sh`.Please note that you need to use the full path to the resource files.
Review Comment:
```suggestion
5. Resources (optional). Resources are files created or uploaded in the `Resource Center -> File Management` page. For example, the file name is `test.sh`, and the command to use the resource in the script is `sh test.sh`. Please note that you need to use the full path to the resource files.
```
##########
docs/docs/en/guide/resource/file-manage.md:
##########
@@ -65,6 +65,8 @@ In the workflow definition module of project Manage, create a new workflow using
- Script: 'sh hello.sh'
- Resource: Select 'hello.sh'
+> Notice: When invoking a resource file in the script, the file name needs to be the same as the full path of the selected resource:
Review Comment:
```suggestion
> Notice: When using a resource file in the script, the file name needs to be the same as the full path of the selected resource:
```
##########
docs/docs/zh/guide/project/workflow-definition.md:
##########
@@ -16,7 +16,7 @@
1. “运行标志”勾选“正常”，若勾选“禁止执行”，运行工作流不会执行该任务；
1. 选择“任务优先级”：当 worker 线程数不足时，级别高的任务在执行队列中会优先执行，相同优先级的任务按照先进先出的顺序执行；
1. 超时告警（非必选）：勾选超时告警、超时失败，填写“超时时长”，当任务执行时间超过**超时时长**，会发送告警邮件并且任务超时失败；
- 1. 资源（非必选）：资源文件是资源中心->文件管理页面创建或上传的文件，如文件名为 `test.sh`，脚本中调用资源命令为 `sh test.sh`；
+ 1. 资源（非必选）：资源文件是资源中心->文件管理页面创建或上传的文件，如文件名为 `test.sh`，脚本中调用资源命令为 `sh test.sh`.注意调用需要使用资源的全路径；
Review Comment:
```suggestion
1. 资源（非必选）：资源文件是资源中心->文件管理页面创建或上传的文件，如文件名为 `test.sh`，脚本中调用资源命令为 `sh test.sh`。注意调用需要使用资源的全路径；
```
##########
docs/docs/en/guide/resource/file-manage.md:
##########
@@ -65,6 +65,8 @@ In the workflow definition module of project Manage, create a new workflow using
- Script: 'sh hello.sh'
- Resource: Select 'hello.sh'
+> Notice: When invoking a resource file in the script, the file name needs to be the same as the full path of the selected resource:
+> For example: if the resource path is `/resource/hello.sh`, you need to use the full path of `/resource/hello.sh` to call in the script.
Review Comment:
```suggestion
> For example: if the resource path is `/resource/hello.sh`, you need to use the full path of `/resource/hello.sh` to use it in the script.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org