You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by fe...@apache.org on 2010/05/19 06:48:50 UTC

svn commit: r946025 - /directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/NestableDelegate.java

Author: felixk
Date: Wed May 19 04:48:50 2010
New Revision: 946025

URL: http://svn.apache.org/viewvc?rev=946025&view=rev
Log:
Constants should be final

Modified:
    directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/NestableDelegate.java

Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/NestableDelegate.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/NestableDelegate.java?rev=946025&r1=946024&r2=946025&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/NestableDelegate.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/NestableDelegate.java Wed May 19 04:48:50 2010
@@ -65,7 +65,7 @@ public class NestableDelegate implements
      * 
      * @since 2.0
      */
-    public static boolean topDown = true;
+    public static final boolean topDown = true;
 
     /**
      * Whether to trim the repeated stack trace. This public flag may be set by
@@ -73,7 +73,7 @@ public class NestableDelegate implements
      * 
      * @since 2.0
      */
-    public static boolean trimStackFrames = true;
+    public static final boolean trimStackFrames = true;
 
 
     /**

Re: svn commit: r946025 - /directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/NestableDelegate.java

Posted by Emmanuel Lecharny <el...@gmail.com>.
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Thanks for heaps up, I missed this. And thanks for fixing.
>    
Btw, checking the code, I realize that those classes are a copy of some 
commons-lang classes. We could do the same things that wht you did a few 
days ago : remove them from the code, and replaced the calls to them by 
a direct call to the commons-lang classes.

wdyt ?


-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.nextury.com

Re: svn commit: r946025 - /directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/NestableDelegate.java

Posted by Felix Knecht <fe...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Sorry, should of course be 'heads up' (slow brain ...)

> Thanks for heaps up, I missed this. And thanks for fixing.
> 
> Felix
> 
> 
>> Good catch, however if those constants are static and final, then they
>> should be upercased.
> 
>> Like :
> 
>> public static final boolean TOP_DOWN = true;
> 
>> I will fix that.--
>> Regards,
>> Cordialement,
>> Emmanuel Lécharny
>> www.nextury.com
> 
> 
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkvzqPkACgkQ2lZVCB08qHHkmACeM0oQrz3n0HiD9aLroNVAbWMm
ReYAoLQdAgSwfqvqWJVWM8LodygrHBNd
=+txK
-----END PGP SIGNATURE-----

Re: svn commit: r946025 - /directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/NestableDelegate.java

Posted by Felix Knecht <fe...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Thanks for heaps up, I missed this. And thanks for fixing.

Felix

> 
> Good catch, however if those constants are static and final, then they
> should be upercased.
> 
> Like :
> 
> public static final boolean TOP_DOWN = true;
> 
> I will fix that.--
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.nextury.com
> 
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkvzqI8ACgkQ2lZVCB08qHGG3wCgoA7mjw1Ki/4jwXV43pFsQ6am
I20AnA7tuoaNmvsqXIT50rlMQuoDRMRQ
=xD4L
-----END PGP SIGNATURE-----

Re: svn commit: r946025 - /directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/util/NestableDelegate.java

Posted by Emmanuel Lecharny <el...@gmail.com>.
On 5/19/10 6:48 AM, felixk@apache.org wrote:
> Author: felixk
> Date: Wed May 19 04:48:50 2010
> New Revision: 946025
>
> URL: http://svn.apache.org/viewvc?rev=946025&view=rev
> Log:
> Constants should be final
>    

Good catch, however if those constants are static and final, then they 
should be upercased.

Like :

public static final boolean TOP_DOWN = true;

I will fix that.--
Regards,
Cordialement,
Emmanuel Lécharny
www.nextury.com