You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by davidtzoor <gi...@git.apache.org> on 2016/06/16 07:00:40 UTC
[GitHub] zeppelin pull request #1024: Add force layout visualization in paragraphs fo...
GitHub user davidtzoor opened a pull request:
https://github.com/apache/zeppelin/pull/1024
Add force layout visualization in paragraphs for SQL queries
### What is this PR for?
Add force layout (graph) visualization to the existing set of visualizations in Zeppelin Web notp.
### What type of PR is it?
[Feature]
### What is the Jira issue?
[ZEPPELIN-1011]
### How should this be tested?
The testes are incorporated within the existing test suite.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
No.
* Is there breaking changes for older versions?
No.
* Does this needs documentation?
We can add some documentation explaining about the different fields that need to be selected in order to generate the force layout component.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davidtzoor/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1024.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1024
----
commit 619376b54ba4064d58e1ac9c8dba9ce9be103a4a
Author: David Tzoor <dt...@paypal.com>
Date: 2016-06-16T06:26:17Z
add force layout button
commit ea6c346a90f38f6e413bbbe646d2fcf96620e4cc
Author: David Tzoor <dt...@paypal.com>
Date: 2016-06-16T06:27:18Z
add div and svg tags that will contain the force layout object
commit 7048e8ebb55bcd570b0374afe9ac284696c7284c
Author: David Tzoor <dt...@paypal.com>
Date: 2016-06-16T06:39:30Z
add column drop boxes for column selection for source and destination nodes
commit c9a11c6150a50c66ff7d15739532b117aa48ddef
Author: David Tzoor <dt...@paypal.com>
Date: 2016-06-16T06:44:54Z
add force layout rendering and column selection handling methods
commit 045251e3ed214be1f50876b80db2bbc638ce7dd7
Author: David Tzoor <dt...@paypal.com>
Date: 2016-06-16T06:45:58Z
add force layout and tooltip CSS
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1024: Add force layout visualization in paragraphs for SQL q...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor commented on the issue:
https://github.com/apache/zeppelin/pull/1024
Sorry for the mess. I will create a new branch with the commits and reopen a new pull request. Thank you for your help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1024: Add force layout visualization in paragraphs for SQL q...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1024
@davidtzoor Thank you.
You might have the problem again considering you made your PR based on your master branch.
Using a custom branch is usually safer, for example right now until this PR is merged, you should not add any changes that differ from Apache Zeppelin source code and is non-related to this PR.
If you do have to do a rebase again, try doing this while in your master:
* `git fetch zeppelinOriginalRepo`
* `git rebase zeppelinOrignalRepo/master`
* resolve conflicts
* `git push`or `git push -f`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1024: Add force layout visualization in paragraphs for SQL q...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1024
Now this PR contains some commits that do not belong here, and it either needs to be re-created from a separate branch as @corneadoug points out, or interactively rebased with keeping only good commits here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1024: Add force layout visualization in paragraphs for SQL q...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1024
@davidtzoor Seems it is really not working, please create a branch for your PR
(`git checkout -b nameOfMyBranch`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1024: Add force layout visualization in paragraphs fo...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor closed the pull request at:
https://github.com/apache/zeppelin/pull/1024
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1024: Add force layout visualization in paragraphs for SQL q...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor commented on the issue:
https://github.com/apache/zeppelin/pull/1024
@corneadoug I created a new pull request (#1044) from a different branch (not `master`).
I am closing this issue. Thank you for your patience and help :smile_cat:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1024: Add force layout visualization in paragraphs for SQL q...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor commented on the issue:
https://github.com/apache/zeppelin/pull/1024
@corneadoug I recreated the PR after doing the rebasing from scratch and it now has no conflict. Hope it works out this time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---