You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Aljoscha Krettek (Jira)" <ji...@apache.org> on 2019/11/11 14:27:00 UTC

[jira] [Commented] (FLINK-14514) Improve interface of FunctionContext#getJobParameter

    [ https://issues.apache.org/jira/browse/FLINK-14514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971626#comment-16971626 ] 

Aljoscha Krettek commented on FLINK-14514:
------------------------------------------

This sounds fine, yes.

> Improve interface of FunctionContext#getJobParameter
> ----------------------------------------------------
>
>                 Key: FLINK-14514
>                 URL: https://issues.apache.org/jira/browse/FLINK-14514
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / API
>            Reporter: Jark Wu
>            Priority: Major
>
> Currentlly, {{FunctionContext#getJobParameter}} gets the key-values from env's ExecutionConfig, but during expression reducing, it gets key-values from {{TableConfig#getConfiguration}} . As we are aiming to not expose underlying env which means users can't access ExecutionConfig in the future. So I propose to get from {{TableConfig#getConfiguration}} and make it clear in javadoc. 
> This might be a in-compatible way, but considering it is not heavily used, I think it's fine. We can add a release note for this.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)