You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/20 02:57:10 UTC

[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #899: test: harden quit_test and list_test

tisonkun commented on code in PR #899:
URL: https://github.com/apache/incubator-kvrocks/pull/899#discussion_r974840651


##########
tests/gocase/unit/quit/quit_test.go:
##########
@@ -45,7 +45,7 @@ func TestPipeQuit(t *testing.T) {
 
 		require.NoError(t, c.WriteArgs("PING"))
 		r, err = c.ReadLine()
-		require.EqualError(t, err, "EOF")
+		require.Error(t, err)

Review Comment:
   After `QUIT`, the connection can be disposed. So we can possibly receive "read tcp 127.0.0.1:53224->127.0.0.1:36579: read: connection reset by peer" instead of "EOF".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org