You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Seshu Pasam (Created) (JIRA)" <ji...@apache.org> on 2012/03/29 18:22:27 UTC
[jira] [Created] (WINK-364) ApacheHttpClientConnectionHandler:
openConnection should be synchronized, should be thread pool and support
connection pooling
ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread pool and support connection pooling
------------------------------------------------------------------------------------------------------------------------------
Key: WINK-364
URL: https://issues.apache.org/jira/browse/WINK-364
Project: Wink
Issue Type: Bug
Components: Client
Affects Versions: 1.1.4
Reporter: Seshu Pasam
Attachments: wink-client-apache-httpclient.diff
I found the following issues when using ApacheHttpClientConnectionHandler:
a.) openConnection() should be synchronized. It need not be synchronized if the httpClient was passed in, but that is typically not the case
b.) ApacheHttpClientConnectionHandler should be thread safe and support connection pooling
c.) Deprecated method usage
d.) Request not properly aborted when exceptions are thrown by httpClient#execute()
I will attach a patch. Please review and apply the patch. Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WINK-364) ApacheHttpClientConnectionHandler:
openConnection should be synchronized, should be thread safe and support
connection pooling
Posted by "Raymond Feng (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raymond Feng resolved WINK-364.
-------------------------------
Resolution: Fixed
Patch applied. Thank you!
> ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread safe and support connection pooling
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: WINK-364
> URL: https://issues.apache.org/jira/browse/WINK-364
> Project: Wink
> Issue Type: Bug
> Components: Client
> Affects Versions: 1.1.4
> Reporter: Seshu Pasam
> Labels: patch
> Attachments: wink-client-apache-httpclient.diff
>
>
> I found the following issues when using ApacheHttpClientConnectionHandler:
> a.) openConnection() should be synchronized. It need not be synchronized if the httpClient was passed in, but that is typically not the case
> b.) ApacheHttpClientConnectionHandler should be thread safe and support connection pooling
> c.) Deprecated method usage
> d.) Request not properly aborted when exceptions are thrown by httpClient#execute()
> I will attach a patch. Please review and apply the patch. Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WINK-364) ApacheHttpClientConnectionHandler:
openConnection should be synchronized, should be thread pool and support
connection pooling
Posted by "Seshu Pasam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Seshu Pasam updated WINK-364:
-----------------------------
Attachment: wink-client-apache-httpclient.diff
See bug description
> ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread pool and support connection pooling
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: WINK-364
> URL: https://issues.apache.org/jira/browse/WINK-364
> Project: Wink
> Issue Type: Bug
> Components: Client
> Affects Versions: 1.1.4
> Reporter: Seshu Pasam
> Labels: patch
> Attachments: wink-client-apache-httpclient.diff
>
>
> I found the following issues when using ApacheHttpClientConnectionHandler:
> a.) openConnection() should be synchronized. It need not be synchronized if the httpClient was passed in, but that is typically not the case
> b.) ApacheHttpClientConnectionHandler should be thread safe and support connection pooling
> c.) Deprecated method usage
> d.) Request not properly aborted when exceptions are thrown by httpClient#execute()
> I will attach a patch. Please review and apply the patch. Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Updated] (WINK-364) ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread safe and support connection pooling
Posted by Raymond Feng <en...@gmail.com>.
I'll take a look. Thanks for the patch.
Raymond Feng
Sent from my iPhone
On Mar 29, 2012, at 6:13 PM, "Seshu Pasam (Updated) (JIRA)" <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/WINK-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Seshu Pasam updated WINK-364:
> -----------------------------
>
> Summary: ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread safe and support connection pooling (was: ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread pool and support connection pooling)
>
> Can someone review and apply the patch please?
>
> Who should I contact to get commit privileges? Thanks
>
>> ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread safe and support connection pooling
>> ------------------------------------------------------------------------------------------------------------------------------
>>
>> Key: WINK-364
>> URL: https://issues.apache.org/jira/browse/WINK-364
>> Project: Wink
>> Issue Type: Bug
>> Components: Client
>> Affects Versions: 1.1.4
>> Reporter: Seshu Pasam
>> Labels: patch
>> Attachments: wink-client-apache-httpclient.diff
>>
>>
>> I found the following issues when using ApacheHttpClientConnectionHandler:
>> a.) openConnection() should be synchronized. It need not be synchronized if the httpClient was passed in, but that is typically not the case
>> b.) ApacheHttpClientConnectionHandler should be thread safe and support connection pooling
>> c.) Deprecated method usage
>> d.) Request not properly aborted when exceptions are thrown by httpClient#execute()
>> I will attach a patch. Please review and apply the patch. Thanks
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
[jira] [Updated] (WINK-364) ApacheHttpClientConnectionHandler:
openConnection should be synchronized, should be thread safe and support
connection pooling
Posted by "Seshu Pasam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Seshu Pasam updated WINK-364:
-----------------------------
Summary: ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread safe and support connection pooling (was: ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread pool and support connection pooling)
Can someone review and apply the patch please?
Who should I contact to get commit privileges? Thanks
> ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread safe and support connection pooling
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: WINK-364
> URL: https://issues.apache.org/jira/browse/WINK-364
> Project: Wink
> Issue Type: Bug
> Components: Client
> Affects Versions: 1.1.4
> Reporter: Seshu Pasam
> Labels: patch
> Attachments: wink-client-apache-httpclient.diff
>
>
> I found the following issues when using ApacheHttpClientConnectionHandler:
> a.) openConnection() should be synchronized. It need not be synchronized if the httpClient was passed in, but that is typically not the case
> b.) ApacheHttpClientConnectionHandler should be thread safe and support connection pooling
> c.) Deprecated method usage
> d.) Request not properly aborted when exceptions are thrown by httpClient#execute()
> I will attach a patch. Please review and apply the patch. Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WINK-364) ApacheHttpClientConnectionHandler:
openConnection should be synchronized, should be thread safe and support
connection pooling
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242622#comment-13242622 ]
Hudson commented on WINK-364:
-----------------------------
Integrated in Wink-Trunk-JDK1.5 #475 (See [https://builds.apache.org/job/Wink-Trunk-JDK1.5/475/])
Apply the patch for https://issues.apache.org/jira/browse/WINK-364. Thanks, Seshu. (Revision 1307529)
Result = SUCCESS
rfeng : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307529
Files :
* /incubator/wink/trunk/wink-client-apache-httpclient/src/main/java/org/apache/wink/client/ApacheHttpClientConfig.java
* /incubator/wink/trunk/wink-client-apache-httpclient/src/main/java/org/apache/wink/client/internal/handlers/ApacheHttpClientConnectionHandler.java
> ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread safe and support connection pooling
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: WINK-364
> URL: https://issues.apache.org/jira/browse/WINK-364
> Project: Wink
> Issue Type: Bug
> Components: Client
> Affects Versions: 1.1.4
> Reporter: Seshu Pasam
> Labels: patch
> Attachments: wink-client-apache-httpclient.diff
>
>
> I found the following issues when using ApacheHttpClientConnectionHandler:
> a.) openConnection() should be synchronized. It need not be synchronized if the httpClient was passed in, but that is typically not the case
> b.) ApacheHttpClientConnectionHandler should be thread safe and support connection pooling
> c.) Deprecated method usage
> d.) Request not properly aborted when exceptions are thrown by httpClient#execute()
> I will attach a patch. Please review and apply the patch. Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira