You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/11 11:11:51 UTC

[GitHub] [spark] attilapiros commented on a change in pull request #24026: [SPARK-27090][CORE] Removing old LEGACY_DRIVER_IDENTIFIER ("")

attilapiros commented on a change in pull request #24026: [SPARK-27090][CORE] Removing old LEGACY_DRIVER_IDENTIFIER ("<driver>")	
URL: https://github.com/apache/spark/pull/24026#discussion_r264182893
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala
 ##########
 @@ -197,7 +197,6 @@ class BlockManagerSuite extends SparkFunSuite with Matchers with BeforeAndAfterE
 
   test("BlockManagerId.isDriver() backwards-compatibility with legacy driver ids (SPARK-6716)") {
 
 Review comment:
   Please update the test name as from now on it does not test "backwards-compatibility with legacy driver ids".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org