[GitHub] [incubator-kvrocks] torwig commented on a diff in pull request #791: Use PutVarInt instead of PutFixed while encoding stream entry value

[GitBox <gi...@apache.org>]

torwig commented on code in PR #791:
URL: https://github.com/apache/incubator-kvrocks/pull/791#discussion_r954753774


##########
src/encoding.cc:
##########
@@ -271,3 +271,77 @@ double DecodeDouble(const char *ptr) {
   memcpy(&value, &decoded, sizeof(value));
   return value;
 }
+
+char* EncodeVarint32(char *dst, uint32_t v) {
+  // Operate on characters as unsigneds
+  unsigned char* ptr = reinterpret_cast<unsigned char*>(dst);
+  static const int B = 128;

Review Comment:
   Refactored this function. Replace it to unrolled version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org