You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Richard Atkins (JIRA)" <ji...@apache.org> on 2010/09/03 07:42:32 UTC
[jira] Created: (SHINDIG-1418) Write detailed logging to debug, not
warning or info
Write detailed logging to debug, not warning or info
----------------------------------------------------
Key: SHINDIG-1418
URL: https://issues.apache.org/jira/browse/SHINDIG-1418
Project: Shindig
Issue Type: Improvement
Components: Java
Reporter: Richard Atkins
When shindig gets an error (4xx or 5xx) from the server while fetching data, shindig will generate a very large log message containing the full conversation trace leading up to the error. On systems where these errors are triggered every time someone views a page, this can quickly fill the error log. Shindig should log a brief summary of the warning (or info) to that logger, and only log the details of the connection error to the debug logger.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1418) Write detailed logging to debug,
not warning or info
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1418.
-----------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Patched with modifications.
Thanks!
> Write detailed logging to debug, not warning or info
> ----------------------------------------------------
>
> Key: SHINDIG-1418
> URL: https://issues.apache.org/jira/browse/SHINDIG-1418
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Reporter: Richard Atkins
> Fix For: 3.0.0
>
> Attachments: debug-detail-logging.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When shindig gets an error (4xx or 5xx) from the server while fetching data, shindig will generate a very large log message containing the full conversation trace leading up to the error. On systems where these errors are triggered every time someone views a page, this can quickly fill the error log. Shindig should log a brief summary of the warning (or info) to that logger, and only log the details of the connection error to the debug logger.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1418) Write detailed logging to debug,
not warning or info
Posted by "Richard Atkins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928487#action_12928487 ]
Richard Atkins commented on SHINDIG-1418:
-----------------------------------------
Looking over the modifications made, if the logging config is logging to two different files (one for warnings+, the other for a full debug log - a common setup for helping admins spot problems and developers investigate the details), the warning now won't show up in the warnings log. It'd be better to let it log both messages to the full log (if necessary) than to lose any warnings. That is: don't use else ifs, just use ifs.
> Write detailed logging to debug, not warning or info
> ----------------------------------------------------
>
> Key: SHINDIG-1418
> URL: https://issues.apache.org/jira/browse/SHINDIG-1418
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Reporter: Richard Atkins
> Fix For: 3.0.0
>
> Attachments: debug-detail-logging.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When shindig gets an error (4xx or 5xx) from the server while fetching data, shindig will generate a very large log message containing the full conversation trace leading up to the error. On systems where these errors are triggered every time someone views a page, this can quickly fill the error log. Shindig should log a brief summary of the warning (or info) to that logger, and only log the details of the connection error to the debug logger.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1418) Write detailed logging to debug, not
warning or info
Posted by "Richard Atkins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Atkins updated SHINDIG-1418:
------------------------------------
Attachment: debug-detail-logging.patch
Attached is a patch against trunk that will address this issue. This will probably also work against most of the version branches, although I haven't tried that.
> Write detailed logging to debug, not warning or info
> ----------------------------------------------------
>
> Key: SHINDIG-1418
> URL: https://issues.apache.org/jira/browse/SHINDIG-1418
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Reporter: Richard Atkins
> Attachments: debug-detail-logging.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When shindig gets an error (4xx or 5xx) from the server while fetching data, shindig will generate a very large log message containing the full conversation trace leading up to the error. On systems where these errors are triggered every time someone views a page, this can quickly fill the error log. Shindig should log a brief summary of the warning (or info) to that logger, and only log the details of the connection error to the debug logger.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1418) Write detailed logging to debug,
not warning or info
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929905#action_12929905 ]
Paul Lindner commented on SHINDIG-1418:
---------------------------------------
However if you set debug level using the same log file you'd end up with multiple log entries which seems unhelpful.
> Write detailed logging to debug, not warning or info
> ----------------------------------------------------
>
> Key: SHINDIG-1418
> URL: https://issues.apache.org/jira/browse/SHINDIG-1418
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Reporter: Richard Atkins
> Fix For: 3.0.0
>
> Attachments: debug-detail-logging.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When shindig gets an error (4xx or 5xx) from the server while fetching data, shindig will generate a very large log message containing the full conversation trace leading up to the error. On systems where these errors are triggered every time someone views a page, this can quickly fill the error log. Shindig should log a brief summary of the warning (or info) to that logger, and only log the details of the connection error to the debug logger.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.