You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sushant40 <gi...@git.apache.org> on 2014/04/13 17:14:20 UTC
[GitHub] cordova-wp8 pull request: Fix for position fix not working.
GitHub user sushant40 opened a pull request:
https://github.com/apache/cordova-wp8/pull/31
Fix for position fix not working.
Elements that are css 'fixed' currently jiggle. This change makes the WP8 web
view full screen and hides it underneath the system tray. Developers will need to add padding to their page as they do in iOS7 in order to make their app appear 100% underneath the system tray.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sushant40/cordova-wp8 master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-wp8/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit b2968f96239c70f669f4b38552d67d304dc3fd6e
Author: Sushant Verma <su...@gmail.com>
Date: 2014-04-13T15:10:28Z
Fix for position fix not working.
Elements that are css 'fixed' currently jiggle. This makes the WP8 web
view full screen and hides it underneath the system tray.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-wp8 pull request: Fix for position fix not working.
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/31#issuecomment-52135694
No longer valid, closing ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-wp8 pull request: Fix for position fix not working.
Posted by sushant40 <gi...@git.apache.org>.
Github user sushant40 commented on the pull request:
https://github.com/apache/cordova-wp8/pull/31#issuecomment-40365778
The config fixes the issue I was having with position fixed not working.
However setting the app to full screen hides the system tray. My change allows for the system tray (and clock) to remain on the screen, similar to the built-in email app. Have a look at attached...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-wp8 pull request: Fix for position fix not working.
Posted by sushant40 <gi...@git.apache.org>.
Github user sushant40 commented on the pull request:
https://github.com/apache/cordova-wp8/pull/31#issuecomment-40363300
The status-bar plugin is IiOS7 only? Do you suggest that I update that to support WP8?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-wp8 pull request: Fix for position fix not working.
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/31#issuecomment-40396152
The addition of Windows Phone support has not been published to the registry. If you install from source [1] support for WP is there.
[1] https://github.com/apache/cordova-plugin-statusbar
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-wp8 pull request: Fix for position fix not working.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-wp8/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-wp8 pull request: Fix for position fix not working.
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/31#issuecomment-40325317
This interferes with functionality in the statusBar plugin. [1]
Also the config.xml fullscreen tag [2] exposes the same value, but is configurable per app.
[1]
http://plugins.cordova.io/#/package/org.apache.cordova.statusbar
[2] http://cordova.apache.org/docs/en/3.4.0/config_ref_index.md.html#The%20config.xml%20File
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---