[jira] [Commented] (SLING-5724) Teleporter: Use o.a.s.testing.clients instead of custom HTTP requests in TeleporterHttpClient

["Bertrand Delacretaz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15281539#comment-15281539 ] 

Bertrand Delacretaz commented on SLING-5724:
--------------------------------------------

I disagree - SLING-5715 is fixed AFAICS, and having no dependencies on http client libraries in the teleporter makes it easier to integrate, and more lightweight.

> Teleporter: Use o.a.s.testing.clients instead of custom HTTP requests in TeleporterHttpClient
> ---------------------------------------------------------------------------------------------
>
>                 Key: SLING-5724
>                 URL: https://issues.apache.org/jira/browse/SLING-5724
>             Project: Sling
>          Issue Type: Bug
>          Components: Testing
>    Affects Versions: JUnit Tests Teleporter 1.0.6
>            Reporter: Konrad Windszus
>
> Instead of having another client which deals with installing/uninstalling bundles, the {{ClientSideTeleporter}} should just leverage the class {{org.apache.sling.testing.clients.osgi.OsgiConsoleClient}} and {{org.apache.sling.testing.clients.osgi.WebconsoleClient}} for that purpose. That might also help with SLING-5715 as it is using the Apache HTTP Client under the hood, which might be a better choice than just plain HttpUrlConnections which are currently used by {{TeleporterHttpClient}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)