You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/18 08:38:50 UTC
[GitHub] [flink] aljoscha commented on a change in pull request #12132: [FLINK-17593][Connectors/FileSystem] Support arbitrary recovery mechanism for PartFileWriter
aljoscha commented on a change in pull request #12132:
URL: https://github.com/apache/flink/pull/12132#discussion_r426448856
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/filesystem/TestUtils.java
##########
@@ -414,4 +419,50 @@ public void clear() {
backingList.clear();
}
}
+
+ static class LocalRecoverableWriterForBucketStateMigrationTest extends LocalRecoverableWriter {
Review comment:
I think we should move this directly to `BucketStateSerializerTest` and rename it to `AlwaysRelativeLocalRecoverableWriter`, and maybe give the prefix as a parameter. Otherwise `"src/test/resources/"` will appear in more than one place and has to be kept in sync.
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/filesystem/TestUtils.java
##########
@@ -414,4 +419,50 @@ public void clear() {
backingList.clear();
}
}
+
+ static class LocalRecoverableWriterForBucketStateMigrationTest extends LocalRecoverableWriter {
+
+ final String prefix = "src/test/resources/";
+
+ LocalRecoverableWriterForBucketStateMigrationTest() {
+ super(new LocalFileSystem());
+ }
+
+ public RecoverableFsDataOutputStream open(Path filePath) throws IOException {
Review comment:
I think maybe we don't need this if we take the minor change from my branch that allows relative files: https://github.com/aljoscha/flink/commit/99810151e4dd37a5b61b89c8056a1ad1202d75a4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org