You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/30 20:10:24 UTC
[GitHub] [superset] codecov[bot] edited a comment on pull request #13868: fix: change status code for generic errors to 400
codecov[bot] edited a comment on pull request #13868:
URL: https://github.com/apache/superset/pull/13868#issuecomment-810420000
# [Codecov](https://codecov.io/gh/apache/superset/pull/13868?src=pr&el=h1) Report
> Merging [#13868](https://codecov.io/gh/apache/superset/pull/13868?src=pr&el=desc) (474dfa1) into [master](https://codecov.io/gh/apache/superset/commit/467848d8f7edd5387ead2f02a7d54bda7523cf7d?el=desc) (467848d) will **increase** coverage by `1.75%`.
> The diff coverage is `67.27%`.
> :exclamation: Current head 474dfa1 differs from pull request most recent head 9fee0ba. Consider uploading reports for the commit 9fee0ba to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13868?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13868 +/- ##
==========================================
+ Coverage 75.56% 77.31% +1.75%
==========================================
Files 935 935
Lines 47275 47534 +259
Branches 5883 6001 +118
==========================================
+ Hits 35725 36753 +1028
+ Misses 11375 10634 -741
+ Partials 175 147 -28
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <46.15%> (+8.33%)` | :arrow_up: |
| hive | `80.29% <50.00%> (ø)` | |
| mysql | `80.60% <50.00%> (ø)` | |
| postgres | `80.63% <50.00%> (ø)` | |
| presto | `80.30% <50.00%> (ø)` | |
| python | `81.14% <50.00%> (ø)` | |
| sqlite | `80.19% <50.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13868?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.66% <0.00%> (ø)` | |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `73.03% <50.00%> (+0.81%)` | :arrow_up: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `47.12% <60.00%> (-21.82%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `75.92% <69.23%> (+23.29%)` | :arrow_up: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `80.55% <100.00%> (+4.69%)` | :arrow_up: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `94.18% <100.00%> (+6.68%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.61% <100.00%> (ø)` | |
| ... and [116 more](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13868?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13868?src=pr&el=footer). Last update [467848d...9fee0ba](https://codecov.io/gh/apache/superset/pull/13868?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org