[jira] Closed: (LANG-514) CharRange constructor is hard to read

["Henri Yandell (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LANG-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed LANG-514.
------------------------------

    Resolution: Fixed

svn ci -m "Applying patch from LANG-514. CharRange constructors removed and replaced with readable static builder methods"
Sending        src/java/org/apache/commons/lang/CharRange.java
Sending        src/java/org/apache/commons/lang/CharSet.java
Sending        src/test/org/apache/commons/lang/CharRangeTest.java
Sending        src/test/org/apache/commons/lang/CharSetTest.java
Transmitting file data ....
Committed revision 829282.

> CharRange constructor is hard to read
> -------------------------------------
>
>                 Key: LANG-514
>                 URL: https://issues.apache.org/jira/browse/LANG-514
>             Project: Commons Lang
>          Issue Type: Improvement
>            Reporter: Henri Yandell
>             Fix For: 3.0
>
>         Attachments: LANG-514-private-ctor.patch, LANG-514.patch
>
>
> Saying new CharRange("....", true) is a very painful way to negate the '...'. Both for cryptic, and because you'd expect true to mean positiveness and false to imply the 'not'.
> Replace this with a static method:
> CharRange.not("....").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.