You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2025/07/14 04:38:34 UTC

[PR] ORC-1954: Fix CI asan-test [orc]

cxzl25 opened a new pull request, #2326:
URL: https://github.com/apache/orc/pull/2326

   
   ### What changes were proposed in this pull request?
   
   
   ### Why are the changes needed?
   https://github.com/apache/orc/actions/runs/16255164323
   
   ```
   [Invalid workflow file: .github/workflows/asan_test.yml#L33](https://github.com/apache/orc/actions/runs/16255164323/workflow)
   You have an error in your yaml syntax on line 33
   ```
   
   ### How was this patch tested?
   GA
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ORC-1954: Fix CI asan-test [orc]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #2326: ORC-1954: Fix CI asan-test
URL: https://github.com/apache/orc/pull/2326


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ORC-1954: Fix CI asan-test [orc]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #2326:
URL: https://github.com/apache/orc/pull/2326#issuecomment-3112105238

   Hi, @wgtmac . Do we need this in `branch-2.1` too because it was added at ORC 2.1.0?
   
   - #2097


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ORC-1954: Fix CI asan-test [orc]

Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #2326:
URL: https://github.com/apache/orc/pull/2326#discussion_r2227472111


##########
CMakeLists.txt:
##########
@@ -177,7 +177,7 @@ endif()
 
 # Configure Undefined Behavior Sanitizer if enabled
 if (ENABLE_UBSAN)
-  if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")

Review Comment:
   I'm not sure why this error was reported in GNU. I've tried a lot and no fixes.
   
   https://github.com/apache/orc/actions/runs/16258126145/job/45898042155
   
   
   ```bash
   CMake Error at /usr/local/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
     Could NOT find Threads (missing: Threads_FOUND)
   Call Stack (most recent call first):
     /usr/local/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
     /usr/local/share/cmake-3.31/Modules/FindThreads.cmake:226 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
     cmake_modules/ThirdpartyToolchain.cmake:38 (FIND_PACKAGE)
     CMakeLists.txt:200 (INCLUDE)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ORC-1954: Fix CI asan-test [orc]

Posted by "williamhyun (via GitHub)" <gi...@apache.org>.
williamhyun commented on PR #2326:
URL: https://github.com/apache/orc/pull/2326#issuecomment-3112257009

   It seems to be https://github.com/apache/orc/pull/2117, @dongjoon-hyun .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ORC-1954: Fix CI asan-test [orc]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #2326:
URL: https://github.com/apache/orc/pull/2326#issuecomment-3120449666

   Thank you, @cxzl25 , @williamhyun , @wgtmac . Merged to main/2.2 for Apache ORC 2.2.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ORC-1954: Fix CI asan-test [orc]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #2326:
URL: https://github.com/apache/orc/pull/2326#discussion_r2227478386


##########
CMakeLists.txt:
##########
@@ -177,7 +177,7 @@ endif()
 
 # Configure Undefined Behavior Sanitizer if enabled
 if (ENABLE_UBSAN)
-  if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")

Review Comment:
   Ya, it seems to fail for a long time.
   - https://github.com/apache/orc/actions/workflows/asan_test.yml?page=3&query=branch%3Amain
   - https://github.com/apache/orc/actions/workflows/asan_test.yml?query=branch%3Abranch-2.2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ORC-1954: Fix CI asan-test [orc]

Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #2326:
URL: https://github.com/apache/orc/pull/2326#discussion_r2227472111


##########
CMakeLists.txt:
##########
@@ -177,7 +177,7 @@ endif()
 
 # Configure Undefined Behavior Sanitizer if enabled
 if (ENABLE_UBSAN)
-  if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")

Review Comment:
   I'm not sure why this error was reported in GNU. I've tried a lot and no fixes.
   
   GNU + `-DENABLE_UBSAN=ON`
   
   https://github.com/apache/orc/actions/runs/16258126145/job/45898042155
   
   
   ```bash
   CMake Error at /usr/local/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
     Could NOT find Threads (missing: Threads_FOUND)
   Call Stack (most recent call first):
     /usr/local/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
     /usr/local/share/cmake-3.31/Modules/FindThreads.cmake:226 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
     cmake_modules/ThirdpartyToolchain.cmake:38 (FIND_PACKAGE)
     CMakeLists.txt:200 (INCLUDE)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ORC-1954: Fix CI asan-test [orc]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #2326:
URL: https://github.com/apache/orc/pull/2326#issuecomment-3112273763

   I've no idea why it didn't work for GNU. I need to investigate it. Let's unblock this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org