You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "ArthurWrong (via GitHub)" <gi...@apache.org> on 2023/03/09 12:20:38 UTC
[GitHub] [rocketmq-flink] ArthurWrong opened a new pull request, #84: Feature new metrics
ArthurWrong opened a new pull request, #84:
URL: https://github.com/apache/rocketmq-flink/pull/84
1. According to [FLIP-33](https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+Connector+Metrics), I replace tpsMetric and outTps with numRecordsInPerSecond and numRecordsOutPerSecond, and replace their counter with numRecordsIn and numRecordsOut at the same time.
2. Additionally, numRecordsIn, numRecordsOut, numRecordsInPerSecond, numRecordsOutPerSecond, these four metrics can be monitored on aliyun vvp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature new metrics [rocketmq-flink]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #84:
URL: https://github.com/apache/rocketmq-flink/pull/84#issuecomment-2022296882
可以解决一下冲突
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature new metrics [rocketmq-flink]
Posted by "ArthurWrong (via GitHub)" <gi...@apache.org>.
ArthurWrong commented on PR #84:
URL: https://github.com/apache/rocketmq-flink/pull/84#issuecomment-2024805999
> Thanks for your contributions! Can you rebase to last main branch.
Done. I have resolved the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature new metrics [rocketmq-flink]
Posted by "ArthurWrong (via GitHub)" <gi...@apache.org>.
ArthurWrong commented on code in PR #84:
URL: https://github.com/apache/rocketmq-flink/pull/84#discussion_r1535214106
##########
src/main/java/org/apache/rocketmq/flink/legacy/common/util/MetricUtils.java:
##########
@@ -75,6 +69,26 @@ public static LatencyGauge registerOutLatency(RuntimeContext context) {
.gauge(METRICS_SINK_OUT_LATENCY, new LatencyGauge());
}
+ public static Meter registerNumRecordsOInPerSecond(RuntimeContext context) {
Review Comment:
yes, it's a mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature new metrics [rocketmq-flink]
Posted by "ArthurWrong (via GitHub)" <gi...@apache.org>.
ArthurWrong commented on PR #84:
URL: https://github.com/apache/rocketmq-flink/pull/84#issuecomment-2026836917
> Thanks for your contributions! Can you rebase to last main branch.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature new metrics [rocketmq-flink]
Posted by "humkum (via GitHub)" <gi...@apache.org>.
humkum commented on code in PR #84:
URL: https://github.com/apache/rocketmq-flink/pull/84#discussion_r1535089840
##########
src/main/java/org/apache/rocketmq/flink/legacy/common/util/MetricUtils.java:
##########
@@ -75,6 +69,26 @@ public static LatencyGauge registerOutLatency(RuntimeContext context) {
.gauge(METRICS_SINK_OUT_LATENCY, new LatencyGauge());
}
+ public static Meter registerNumRecordsOInPerSecond(RuntimeContext context) {
Review Comment:
the function name should be registerNumRecordsInPerSecond ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature new metrics [rocketmq-flink]
Posted by "ArthurWrong (via GitHub)" <gi...@apache.org>.
ArthurWrong commented on PR #84:
URL: https://github.com/apache/rocketmq-flink/pull/84#issuecomment-2024683511
> Thanks for your contributions! Can you rebase to last main branch.
Done, I have resolved the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature new metrics [rocketmq-flink]
Posted by "ArthurWrong (via GitHub)" <gi...@apache.org>.
ArthurWrong commented on PR #84:
URL: https://github.com/apache/rocketmq-flink/pull/84#issuecomment-2080746664
@lizhimins @humkum Can we review the code and merge it into the main branch？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org