You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/07/24 14:55:18 UTC
Review Request 36777: LENS-680 : Remove commons-logging dependency
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36777/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-680
https://issues.apache.org/jira/browse/LENS-680
Repository: lens
Description
-------
Removes commons-logging dependency
Diffs
-----
lens-client/pom.xml c7ddc7a
lens-client/src/main/java/org/apache/lens/client/LensClient.java 9ff2124
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 1ecf145
lens-ml-lib/pom.xml a05d2dd
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java c067365
lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java 270f0f0
pom.xml 15ac998
Diff: https://reviews.apache.org/r/36777/diff/
Testing
-------
Have tested logs in local setup - all server logs, query-stats log and client logging wrt debug and verbose.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.999s]
[INFO] Lens .............................................. SUCCESS [3.200s]
[INFO] Lens API .......................................... SUCCESS [22.295s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.709s]
[INFO] Lens Cube ......................................... SUCCESS [4:13.928s]
[INFO] Lens DB storage ................................... SUCCESS [19.223s]
[INFO] Lens Query Library ................................ SUCCESS [15.550s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:47.750s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.003s]
[INFO] Lens Server ....................................... SUCCESS [5:36.798s]
[INFO] Lens client ....................................... SUCCESS [34.242s]
[INFO] Lens CLI .......................................... SUCCESS [2:44.803s]
[INFO] Lens Examples ..................................... SUCCESS [11.057s]
[INFO] Lens Distribution ................................. SUCCESS [9.989s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:33.074s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.218s]
[INFO] Lens Regression ................................... SUCCESS [13.102s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:03.842s
[INFO] Finished at: Fri Jul 24 12:43:36 UTC 2015
[INFO] Final Memory: 192M/2115M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 36777: LENS-680 : Remove commons-logging dependency
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On July 24, 2015, 12:58 p.m., Rajat Khandelwal wrote:
> > Can you check dependency tree?
Checked dependency tree. Lensserver no more depends/bundles commons-logging. But client debian bundles as spring-shell has a compile time dependency.
+- org.apache.lens:lens-cli:jar:2.3.0-beta-incubating-SNAPSHOT:compile
[INFO] | +- org.springframework.shell:spring-shell:jar:1.1.0.RELEASE:compile
[INFO] | | +- jline:jline:jar:2.11:compile
[INFO] | | +- cglib:cglib:jar:2.2.2:compile
[INFO] | | | - asm:asm:jar:3.3.1:compile
[INFO] | | +- org.springframework:spring-context-support:jar:4.0.3.RELEASE:compile
[INFO] | | | +- org.springframework:spring-beans:jar:4.0.3.RELEASE:compile
[INFO] | | | - org.springframework:spring-context:jar:4.0.3.RELEASE:compile
[INFO] | | | +- org.springframework:spring-aop:jar:4.0.3.RELEASE:compile
[INFO] | | | | - aopalliance:aopalliance:jar:1.0:compile
[INFO] | | | - org.springframework:spring-expression:jar:4.0.3.RELEASE:compile
[INFO] | | - org.springframework:spring-core:jar:4.0.3.RELEASE:compile
[INFO] | | - commons-logging:commons-logging:jar:1.1.3:compile
[INFO] | +- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile
[INFO] | - org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36777/#review92900
-----------------------------------------------------------
On July 24, 2015, 12:55 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36777/
> -----------------------------------------------------------
>
> (Updated July 24, 2015, 12:55 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-680
> https://issues.apache.org/jira/browse/LENS-680
>
>
> Repository: lens
>
>
> Description
> -------
>
> Removes commons-logging dependency
>
>
> Diffs
> -----
>
> lens-client/pom.xml c7ddc7a
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 9ff2124
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java 1ecf145
> lens-ml-lib/pom.xml a05d2dd
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java c067365
> lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java 270f0f0
> pom.xml 15ac998
>
> Diff: https://reviews.apache.org/r/36777/diff/
>
>
> Testing
> -------
>
> Have tested logs in local setup - all server logs, query-stats log and client logging wrt debug and verbose.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.999s]
> [INFO] Lens .............................................. SUCCESS [3.200s]
> [INFO] Lens API .......................................... SUCCESS [22.295s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.709s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.928s]
> [INFO] Lens DB storage ................................... SUCCESS [19.223s]
> [INFO] Lens Query Library ................................ SUCCESS [15.550s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:47.750s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.003s]
> [INFO] Lens Server ....................................... SUCCESS [5:36.798s]
> [INFO] Lens client ....................................... SUCCESS [34.242s]
> [INFO] Lens CLI .......................................... SUCCESS [2:44.803s]
> [INFO] Lens Examples ..................................... SUCCESS [11.057s]
> [INFO] Lens Distribution ................................. SUCCESS [9.989s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:33.074s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.218s]
> [INFO] Lens Regression ................................... SUCCESS [13.102s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:03.842s
> [INFO] Finished at: Fri Jul 24 12:43:36 UTC 2015
> [INFO] Final Memory: 192M/2115M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36777: LENS-680 : Remove commons-logging dependency
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36777/#review92900
-----------------------------------------------------------
Ship it!
Can you check dependency tree?
- Rajat Khandelwal
On July 24, 2015, 6:25 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36777/
> -----------------------------------------------------------
>
> (Updated July 24, 2015, 6:25 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-680
> https://issues.apache.org/jira/browse/LENS-680
>
>
> Repository: lens
>
>
> Description
> -------
>
> Removes commons-logging dependency
>
>
> Diffs
> -----
>
> lens-client/pom.xml c7ddc7a
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 9ff2124
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java 1ecf145
> lens-ml-lib/pom.xml a05d2dd
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java c067365
> lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java 270f0f0
> pom.xml 15ac998
>
> Diff: https://reviews.apache.org/r/36777/diff/
>
>
> Testing
> -------
>
> Have tested logs in local setup - all server logs, query-stats log and client logging wrt debug and verbose.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.999s]
> [INFO] Lens .............................................. SUCCESS [3.200s]
> [INFO] Lens API .......................................... SUCCESS [22.295s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.709s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.928s]
> [INFO] Lens DB storage ................................... SUCCESS [19.223s]
> [INFO] Lens Query Library ................................ SUCCESS [15.550s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:47.750s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.003s]
> [INFO] Lens Server ....................................... SUCCESS [5:36.798s]
> [INFO] Lens client ....................................... SUCCESS [34.242s]
> [INFO] Lens CLI .......................................... SUCCESS [2:44.803s]
> [INFO] Lens Examples ..................................... SUCCESS [11.057s]
> [INFO] Lens Distribution ................................. SUCCESS [9.989s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:33.074s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.218s]
> [INFO] Lens Regression ................................... SUCCESS [13.102s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:03.842s
> [INFO] Finished at: Fri Jul 24 12:43:36 UTC 2015
> [INFO] Final Memory: 192M/2115M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36777: LENS-680 : Remove commons-logging dependency
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36777/
-----------------------------------------------------------
(Updated July 27, 2015, 5:28 a.m.)
Review request for lens.
Changes
-------
Remove commons-logging from hadoop-common
Bugs: LENS-680
https://issues.apache.org/jira/browse/LENS-680
Repository: lens
Description
-------
Removes commons-logging dependency
Diffs (updated)
-----
lens-client/pom.xml c7ddc7a
lens-client/src/main/java/org/apache/lens/client/LensClient.java 9ff2124
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 1ecf145
lens-dist/pom.xml 15d62d3
lens-ml-lib/pom.xml a05d2dd
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java c067365
lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java 270f0f0
pom.xml 15ac998
Diff: https://reviews.apache.org/r/36777/diff/
Testing
-------
Have tested logs in local setup - all server logs, query-stats log and client logging wrt debug and verbose.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.999s]
[INFO] Lens .............................................. SUCCESS [3.200s]
[INFO] Lens API .......................................... SUCCESS [22.295s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.709s]
[INFO] Lens Cube ......................................... SUCCESS [4:13.928s]
[INFO] Lens DB storage ................................... SUCCESS [19.223s]
[INFO] Lens Query Library ................................ SUCCESS [15.550s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:47.750s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.003s]
[INFO] Lens Server ....................................... SUCCESS [5:36.798s]
[INFO] Lens client ....................................... SUCCESS [34.242s]
[INFO] Lens CLI .......................................... SUCCESS [2:44.803s]
[INFO] Lens Examples ..................................... SUCCESS [11.057s]
[INFO] Lens Distribution ................................. SUCCESS [9.989s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:33.074s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.218s]
[INFO] Lens Regression ................................... SUCCESS [13.102s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:03.842s
[INFO] Finished at: Fri Jul 24 12:43:36 UTC 2015
[INFO] Final Memory: 192M/2115M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu