[GitHub] khos2ow commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox <gi...@apache.org>]

khos2ow commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#discussion_r171869059
 
 

 ##########
 File path: utils/src/main/java/com/cloud/maint/Version.java
 ##########
 @@ -19,59 +19,82 @@
 
 package com.cloud.maint;
 
+import java.util.regex.Pattern;
+
+import org.apache.commons.lang.StringUtils;
+
 public class Version {
     /**
      * Compares two version strings and see which one is higher version.
-     * @param ver1
-     * @param ver2
-     * @return positive if ver1 is higher.  negative if ver1 is lower; zero if the same.
+     *
+     * @param version1
+     * @param version2
+     *
+     * @return positive if version1 is higher.  negative if version2 is lower; zero if the same.
 
 Review comment:
   Nice finding!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services