You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/03 07:12:02 UTC

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8563: [FLINK-12602][travis] Correct the flink pom `artifactId` config and s…

sunjincheng121 commented on a change in pull request #8563: [FLINK-12602][travis] Correct the flink pom `artifactId` config and s…
URL: https://github.com/apache/flink/pull/8563#discussion_r299805853
 
 

 ##########
 File path: flink-connectors/flink-sql-connector-kafka-0.10/pom.xml
 ##########
 @@ -41,6 +41,14 @@ under the License.
 			<artifactId>flink-connector-kafka-0.10_${scala.binary.version}</artifactId>
 			<version>${project.version}</version>
 		</dependency>
+		<!--  Due to the scope of `provided` transitive dependencies problem,
 
 Review comment:
   Thanks @WeiZhong94 @zentol, for @zentol's suggestion also make sense to me, just like we discuss offline @WeiZhong94 . and I mentioned above, we can take `approach 1` for this PR. 
   I'll update the PR soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services