Re: [PR] Fix JDBC lost-create under SERIALIZABLE isolation [polaris]

["dimas-b (via GitHub)" <gi...@apache.org>]

dimas-b commented on code in PR #5094:
URL: https://github.com/apache/polaris/pull/5094#discussion_r3725048122


##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DatasourceOperations.java:
##########
@@ -393,7 +394,8 @@ <T> T withRetries(Operation<T> operation) throws SQLException {
           // Handle Exceptions from ResultSet Iterator consumer, as it throws a RTE, ignore RTE from
           // the transactions.
           if (e.getCause() instanceof SQLException
-              && !(e instanceof EntityAlreadyExistsException)) {
+              && !(e instanceof EntityAlreadyExistsException)
+              && !(e instanceof RetryOnConcurrencyException)) {

Review Comment:
   This is becoming complicated. Should we have a simple catch-and-rethrow clauses for those poss-through exceptions above line 391?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org