You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/29 21:31:02 UTC

[GitHub] [kafka] sebwills commented on pull request #8481: KAFKA-9034 Tolerate spaces in $JAVA_HOME

sebwills commented on pull request #8481:
URL: https://github.com/apache/kafka/pull/8481#issuecomment-621475637


   > ```shell
   > ```shell
   > JAVA_MAJOR_VERSION=$($JAVA -version 2>&1 | sed -E -n 's/.* version "([0-9]*).*$/\1/p')
   > ```
   > 
   > 
   > There is another similar code in the kafka-run-class.sh. Should it be fixed also?
   > ```
   
   Good spot. Yes, it should be. I've updated, and tested it on Cygwin to confirm.
   
   What is the process for getting this PR merged now?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org