You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by duncangrant <gi...@git.apache.org> on 2015/04/07 11:51:28 UTC
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
GitHub user duncangrant opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/584
Rabbit mq management flag
Add flag enableManagementPlugin defaulting to false
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/duncangrant/incubator-brooklyn feature/add-rabbit-management-flag
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/584.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #584
----
commit 91964249100b61e1593b8a236517546dd0c94077
Author: Duncan Grant <du...@cloudsoftcorp.com>
Date: 2015-04-07T09:45:46Z
Rabbit mq management flag
Add flag enableManagementPlugin defaulting to false
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#issuecomment-90623540
For time / your own sanity it might be worth checking with one or two of the tests rather than all of them. e.g. `mvn clean install -PLive -Dtest=RabbitEc2LiveTest#test_CentOS_6_3`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/584
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#issuecomment-90614608
@duncangrant Looking good. Couple more things. Have you run `RabbitEc2LiveTest` at all? (Assuming it even passed previously, of course!)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#issuecomment-90611602
I think I've covered all Sam's review points.
Once he is happy I'll squash the commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27891098
--- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitSshDriver.java ---
@@ -124,11 +125,21 @@ public void install() {
@Override
public void customize() {
Networking.checkPortsValid(MutableMap.of("amqpPort", getAmqpPort()));
- newScript(CUSTOMIZING)
- .body.append(
- format("cp -R %s/* .", getExpandedInstallDir())
- )
- .execute();
+ ScriptHelper scriptHelper = newScript(CUSTOMIZING);
+
+ scriptHelper.body.append(
+ format("cp -R %s/* .", getExpandedInstallDir())
+ );
+
+ if (Boolean.TRUE.equals(entity.getConfig(RabbitBroker.ENABLE_MANAGEMENT_PLUGIN))) {
+ scriptHelper.body.append(
+ "./sbin/rabbitmq-plugins enable rabbitmq_management"
+ );
+ }
+ scriptHelper.failOnNonZeroResultCode();
+ scriptHelper.execute();
+
+ copyTemplate(entity.getConfig(RabbitBroker.CONFIG_TEMPLATE_URL), getConfigPath() + ".config");
--- End diff --
It's intentional - I don't know why but rabbitmq adds the .config to the RABBITMQ_CONFIG_FILE env variable
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27865415
--- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitBrokerImpl.java ---
@@ -100,6 +102,14 @@ public void disconnectSensors() {
disconnectServiceUpIsRunning();
}
+ public boolean getEnableManagementPlugin() {
+ return getConfig(ENABLE_MANAGEMENT_PLUGIN);
--- End diff --
Worth returning `Boolean.TRUE.equals(getConfig(ENABLE_MANAGEMENT_PLUGIN))` just in case someone does something stupid and sets `ENABLE_MANAGEMENT_PLUGIN` to null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27890231
--- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitBrokerImpl.java ---
@@ -92,6 +92,8 @@ protected void connectSensors() {
connectServiceUpIsRunning();
setBrokerUrl();
+
+ setAttribute(MANAGEMENT_URL, format("http://%s:%s/", getAttribute(HOSTNAME), getAttribute(MANAGEMENT_PORT)));
--- End diff --
Should this be set if `ENABLE_MANAGEMENT_PLUGIN` is false?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#issuecomment-90861366
ah sorry! @duncangrant this makes your live testing more urgent -- if any problems hollar and we'll revert (or fix)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27866398
--- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitSshDriver.java ---
@@ -124,11 +123,20 @@ public void install() {
@Override
public void customize() {
Networking.checkPortsValid(MutableMap.of("amqpPort", getAmqpPort()));
- newScript(CUSTOMIZING)
- .body.append(
- format("cp -R %s/* .", getExpandedInstallDir())
- )
- .execute();
+ copyTemplate(entity.getConfig(RabbitBroker.CONFIG_TEMPLATE_URL), getConfigPath() + ".config");
+ ScriptHelper scriptHelper = newScript(CUSTOMIZING);
+
+ scriptHelper.body.append(
+ format("cp -R %s/* .", getExpandedInstallDir())
+ );
+
+ if (entity.getConfig(RabbitBroker.ENABLE_MANAGEMENT_PLUGIN)) {
+ scriptHelper.body.append(
+ "./sbin/rabbitmq-plugins enable rabbitmq_management"
+ );
+ }
+
+ scriptHelper.execute();
--- End diff --
Appreciate there wasn't one before but would make sense to include a `failOnNonZeroResultCode` to this step.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#issuecomment-90868528
Tests pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27870053
--- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitSshDriver.java ---
@@ -186,6 +195,11 @@ public void kill() {
.put("RABBITMQ_NODENAME", getEntity().getId())
.put("RABBITMQ_NODE_PORT", getAmqpPort().toString())
.put("RABBITMQ_PID_FILE", getRunDir()+"/"+getPidFile())
+ .put("RABBITMQ_CONFIG_FILE", getConfigPath())
.build();
}
+
+ private String getConfigPath() {
+ return getInstallDir() + "/rabbitmq";
--- End diff --
That's because you're doing it before executing the main script. Using `newScript(CUSTOMIZE)` magically creates runDir if it doesn't already exist.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#issuecomment-90859496
LGTM also. merging on basis that CentOS 6.3 test is healthy. @duncangrant please post the results of your live tests for reference, and if there are more fixes we can add them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27890167
--- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitBroker.java ---
@@ -60,7 +63,18 @@
@SetFromFlag("amqpVersion")
public static final BasicAttributeSensorAndConfigKey<String> AMQP_VERSION = new BasicAttributeSensorAndConfigKey<String>(
AmqpServer.AMQP_VERSION, AmqpServer.AMQP_0_9_1);
-
+
+ @SetFromFlag("managmentPort")
+ public static final PortAttributeSensorAndConfigKey MANAGEMENT_PORT = new PortAttributeSensorAndConfigKey(
+ "rabbitmq.management.port", "Port on which management interface will be available", "15672+");
--- End diff --
Indentation is off.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27869686
--- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitSshDriver.java ---
@@ -186,6 +195,11 @@ public void kill() {
.put("RABBITMQ_NODENAME", getEntity().getId())
.put("RABBITMQ_NODE_PORT", getAmqpPort().toString())
.put("RABBITMQ_PID_FILE", getRunDir()+"/"+getPidFile())
+ .put("RABBITMQ_CONFIG_FILE", getConfigPath())
.build();
}
+
+ private String getConfigPath() {
+ return getInstallDir() + "/rabbitmq";
--- End diff --
I started with that but it was failing to write the config in the customize step.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27890142
--- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitSshDriver.java ---
@@ -124,11 +125,21 @@ public void install() {
@Override
public void customize() {
Networking.checkPortsValid(MutableMap.of("amqpPort", getAmqpPort()));
- newScript(CUSTOMIZING)
- .body.append(
- format("cp -R %s/* .", getExpandedInstallDir())
- )
- .execute();
+ ScriptHelper scriptHelper = newScript(CUSTOMIZING);
+
+ scriptHelper.body.append(
+ format("cp -R %s/* .", getExpandedInstallDir())
+ );
+
+ if (Boolean.TRUE.equals(entity.getConfig(RabbitBroker.ENABLE_MANAGEMENT_PLUGIN))) {
+ scriptHelper.body.append(
+ "./sbin/rabbitmq-plugins enable rabbitmq_management"
+ );
+ }
+ scriptHelper.failOnNonZeroResultCode();
+ scriptHelper.execute();
+
+ copyTemplate(entity.getConfig(RabbitBroker.CONFIG_TEMPLATE_URL), getConfigPath() + ".config");
--- End diff --
`getShellEnvironment` doesn't append the `.config` you're adding here. Is this intentional?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#issuecomment-90623752
P.S. test_CentOS_6_3 passes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#issuecomment-90859662
Sorry, I was unclear. I checked the EC2 live test against master, not the changes in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27879313
--- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitSshDriver.java ---
@@ -124,11 +123,20 @@ public void install() {
@Override
public void customize() {
Networking.checkPortsValid(MutableMap.of("amqpPort", getAmqpPort()));
- newScript(CUSTOMIZING)
- .body.append(
- format("cp -R %s/* .", getExpandedInstallDir())
- )
- .execute();
+ copyTemplate(entity.getConfig(RabbitBroker.CONFIG_TEMPLATE_URL), getConfigPath() + ".config");
+ ScriptHelper scriptHelper = newScript(CUSTOMIZING);
+
+ scriptHelper.body.append(
+ format("cp -R %s/* .", getExpandedInstallDir())
+ );
+
+ if (entity.getConfig(RabbitBroker.ENABLE_MANAGEMENT_PLUGIN)) {
--- End diff --
Oh, sorry, misread the diff and thought `getEnableManagementPlugin` was on the driver. Worth doing the whole `Boolean.TRUE` thing as mentioned before then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27866368
--- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitSshDriver.java ---
@@ -18,26 +18,25 @@
*/
package brooklyn.entity.messaging.rabbit;
-import static brooklyn.util.ssh.BashCommands.*;
-import static java.lang.String.format;
-
-import java.util.List;
-import java.util.Map;
-
-import com.google.common.base.Strings;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
import brooklyn.entity.basic.AbstractSoftwareProcessSshDriver;
import brooklyn.entity.basic.Entities;
+import brooklyn.entity.basic.lifecycle.ScriptHelper;
import brooklyn.entity.messaging.amqp.AmqpServer;
import brooklyn.location.basic.SshMachineLocation;
import brooklyn.util.collections.MutableMap;
import brooklyn.util.net.Networking;
import brooklyn.util.os.Os;
-
+import com.google.common.base.Strings;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+import java.util.Map;
+
+import static brooklyn.util.ssh.BashCommands.*;
+import static java.lang.String.format;
--- End diff --
Try to avoid your IDE reformatting imports. I've followed these instructions to reduce these kinds of diffs: http://stackoverflow.com/a/17194980/41195
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27866446
--- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitSshDriver.java ---
@@ -186,6 +195,11 @@ public void kill() {
.put("RABBITMQ_NODENAME", getEntity().getId())
.put("RABBITMQ_NODE_PORT", getAmqpPort().toString())
.put("RABBITMQ_PID_FILE", getRunDir()+"/"+getPidFile())
+ .put("RABBITMQ_CONFIG_FILE", getConfigPath())
.build();
}
+
+ private String getConfigPath() {
+ return getInstallDir() + "/rabbitmq";
--- End diff --
Wouldn't it make more sense for the config path to refer to `runDir` rather than `installDir`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27866493
--- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitSshDriver.java ---
@@ -124,11 +123,20 @@ public void install() {
@Override
public void customize() {
Networking.checkPortsValid(MutableMap.of("amqpPort", getAmqpPort()));
- newScript(CUSTOMIZING)
- .body.append(
- format("cp -R %s/* .", getExpandedInstallDir())
- )
- .execute();
+ copyTemplate(entity.getConfig(RabbitBroker.CONFIG_TEMPLATE_URL), getConfigPath() + ".config");
+ ScriptHelper scriptHelper = newScript(CUSTOMIZING);
+
+ scriptHelper.body.append(
+ format("cp -R %s/* .", getExpandedInstallDir())
+ );
+
+ if (entity.getConfig(RabbitBroker.ENABLE_MANAGEMENT_PLUGIN)) {
--- End diff --
Use `getEnableManagementPlugin`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27878528
--- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitSshDriver.java ---
@@ -124,11 +123,20 @@ public void install() {
@Override
public void customize() {
Networking.checkPortsValid(MutableMap.of("amqpPort", getAmqpPort()));
- newScript(CUSTOMIZING)
- .body.append(
- format("cp -R %s/* .", getExpandedInstallDir())
- )
- .execute();
+ copyTemplate(entity.getConfig(RabbitBroker.CONFIG_TEMPLATE_URL), getConfigPath() + ".config");
+ ScriptHelper scriptHelper = newScript(CUSTOMIZING);
+
+ scriptHelper.body.append(
+ format("cp -R %s/* .", getExpandedInstallDir())
+ );
+
+ if (entity.getConfig(RabbitBroker.ENABLE_MANAGEMENT_PLUGIN)) {
--- End diff --
entity has type EntityLocal - are you suggesting I cast this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rabbit mq management flag
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/584#issuecomment-90619119
Goog point - I'll run the live tests in the morning (both before and after changes)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---