Re: [PR] HADOOP-19966. ZKDelegationTokenSecretManager startup cache load races with CuratorCache initialization [hadoop]

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on PR #8688:
URL: https://github.com/apache/hadoop/pull/8688#issuecomment-5677391891

   @Hexiaoqiao Token verify/renew/cancel are not affected: `getTokenInfo` and `getDelegationKey` fall back to ZK on a cache miss. The in-memory load exists for the expired-token remover, which only scans `currentTokens` (HADOOP-13487). That relied on PathChildrenCache `BUILD_INITIAL_CACHE` being synchronous; HADOOP-17835 (3.4.0) switched to `CuratorCache.start()`, which is asynchronous. The listener still fills the map a few seconds later, so the lasting effects are: token owner stats (Router `getTopTokenRealOwners`) are computed from a partial map and never corrected for pre-restart tokens, the root container znode is parsed on every startup and logs an ERROR, and `testNodesLoadedAfterRestart` is flaky in CI. Router with the token watcher disabled uses its own synchronous `rebuildTokenCache` and is unaffected. Retitled the PR and rewrote the description accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org