[jira] [Commented] (TS-4125) wrong non-active conditions check

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093817#comment-15093817 ] 

ASF GitHub Bot commented on TS-4125:
------------------------------------

GitHub user oknet opened a pull request:

    https://github.com/apache/trafficserver/pull/416

    TS-4125: wrong non-active conditions check

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/oknet/trafficserver patch-4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/416.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #416
    
----
commit b45f1e2065f0545f952b047b66d69d8d50276e60
Author: Oknet <xu...@gmail.com>
Date:   2016-01-12T12:25:28Z

    wrong non-active conditions check

----


> wrong non-active conditions check
> ---------------------------------
>
>                 Key: TS-4125
>                 URL: https://issues.apache.org/jira/browse/TS-4125
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core
>            Reporter: Oknet Xu
>
> In the NetHandler::manage_active_queue() function:
> we should close inactivity timeout vc that means "vc->next_activity_timeout_at <= now".
> but "vc->next_activity_timeout_at > now" here.
> It's call _close_vc() for an activity vc and close vc early.
> {code}
>   for (; vc != NULL; vc = vc_next) {
>     if ((vc->next_inactivity_timeout_at > now) || (vc->next_activity_timeout_at > now)) {
>       _close_vc(vc, now, handle_event, closed, total_idle_time, total_idle_count);
>     }
>     if (max_connections_active_per_thread_in > active_queue_size) {
>       return true;
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)