You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/05/21 02:24:13 UTC
[GitHub] [incubator-dolphinscheduler] codecov-commenter edited a comment on pull request #2764: [BUF FIX]fix: the master would be blocked when worker group not exists
codecov-commenter edited a comment on pull request #2764:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2764#issuecomment-631277903
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2764?src=pr&el=h1) Report
> Merging [#2764](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2764?src=pr&el=desc) into [dev-1.3.0](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/3cfe4c95fe15b896bc6fe2dd9c914a2165e959a5&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `54.54%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2764?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev-1.3.0 #2764 +/- ##
===============================================
+ Coverage 37.02% 37.07% +0.05%
- Complexity 2545 2550 +5
===============================================
Files 434 434
Lines 19999 20009 +10
Branches 2441 2444 +3
===============================================
+ Hits 7405 7419 +14
+ Misses 11919 11917 -2
+ Partials 675 673 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2764?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...inscheduler/server/master/config/MasterConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2764/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9jb25maWcvTWFzdGVyQ29uZmlnLmphdmE=) | `45.45% <33.33%> (-1.22%)` | `12.00 <1.00> (+1.00)` | :arrow_down: |
| [...ver/master/consumer/TaskPriorityQueueConsumer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2764/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9jb25zdW1lci9UYXNrUHJpb3JpdHlRdWV1ZUNvbnN1bWVyLmphdmE=) | `53.14% <57.89%> (-1.27%)` | `18.00 <4.00> (+2.00)` | :arrow_down: |
| [...server/master/dispatch/host/CommonHostManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2764/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L0NvbW1vbkhvc3RNYW5hZ2VyLmphdmE=) | `11.11% <0.00%> (-33.34%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ler/server/master/dispatch/ExecutorDispatcher.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2764/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9FeGVjdXRvckRpc3BhdGNoZXIuamF2YQ==) | `44.44% <0.00%> (-16.67%)` | `3.00% <0.00%> (-1.00%)` | |
| [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2764/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `68.25% <0.00%> (-3.18%)` | `13.00% <0.00%> (-1.00%)` | |
| [...nscheduler/server/entity/TaskExecutionContext.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2764/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL2VudGl0eS9UYXNrRXhlY3V0aW9uQ29udGV4dC5qYXZh) | `87.12% <0.00%> (+5.94%)` | `60.00% <0.00%> (+3.00%)` | |
| [.../server/worker/processor/TaskExecuteProcessor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2764/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9wcm9jZXNzb3IvVGFza0V4ZWN1dGVQcm9jZXNzb3IuamF2YQ==) | `36.66% <0.00%> (+26.66%)` | `3.00% <0.00%> (+2.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2764?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2764?src=pr&el=footer). Last update [7d2441f...1f61329](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2764?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org