You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@datasketches.apache.org by "Lee Rhodes (Jira)" <ji...@apache.org> on 2022/04/19 02:00:00 UTC

[jira] [Closed] (DATASKETCHES-5) Buffer over-read in MurmurHash3_x64_128

     [ https://issues.apache.org/jira/browse/DATASKETCHES-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lee Rhodes closed DATASKETCHES-5.
---------------------------------
    Assignee: Lee Rhodes  (was: Jon Malkin)

> Buffer over-read in MurmurHash3_x64_128
> ---------------------------------------
>
>                 Key: DATASKETCHES-5
>                 URL: https://issues.apache.org/jira/browse/DATASKETCHES-5
>             Project: Apache Datasketches
>          Issue Type: Bug
>            Reporter: Csaba Ringhofer
>            Assignee: Lee Rhodes
>            Priority: Critical
>
> MurmurHash3_x64_128 seems to contain a half-commented-out change that leads to adding the offset to the key 2 times:
> 'blocks ' is increased:
> https://github.com/apache/incubator-datasketches-cpp/blob/2941841dda921026a5dc2052388461d9295dc0b0/common/include/MurmurHash3.h#L128
> but the following lines assume that 'blocks ' still points to the start of the key:
> https://github.com/apache/incubator-datasketches-cpp/blob/2941841dda921026a5dc2052388461d9295dc0b0/common/include/MurmurHash3.h#L115
> https://github.com/apache/incubator-datasketches-cpp/blob/2941841dda921026a5dc2052388461d9295dc0b0/common/include/MurmurHash3.h#L133



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org