You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2014/02/18 09:49:20 UTC
[jira] [Resolved] (OAK-1193) AbstractTree.getChildNodeCount()
should not actively filter out hidden names
[ https://issues.apache.org/jira/browse/OAK-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela resolved OAK-1193.
-------------------------
Resolution: Won't Fix
resolving wontfix as filtering out on the nodebuilder is not possible for consistency with the hidden properties that must be accessible on the tree implementation.
we may reconsider this if it really turns out to have a significant performance impact.
> AbstractTree.getChildNodeCount() should not actively filter out hidden names
> ----------------------------------------------------------------------------
>
> Key: OAK-1193
> URL: https://issues.apache.org/jira/browse/OAK-1193
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Tobias Bocanegra
>
> {code}
> long count = nodeBuilder.getChildNodeCount(max);
> if (count > 0) {
> for (String name : INTERNAL_NODE_NAMES) {
> if (nodeBuilder.hasChildNode(name)) {
> count--;
> }
> }
> }
> {code}
> Checks {{INTERNAL_NODE_NAMES}} which is slow and not extensible. it should propagate the hidden-filtering down to node builder.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)