[GitHub] [hive] miklosgergely commented on a change in pull request #817: HIVE-22347 Break up DDLSemanticAnalyzer - extract Other analyzers

[GitBox <gi...@apache.org>]

miklosgergely commented on a change in pull request #817: HIVE-22347 Break up DDLSemanticAnalyzer - extract Other analyzers
URL: https://github.com/apache/hive/pull/817#discussion_r343011859
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/insert/commit/hook/InsertCommitHookOperation.java
 ##########
 @@ -16,7 +16,7 @@
  * limitations under the License.
  */
 
-package org.apache.hadoop.hive.ql.ddl.misc;
+package org.apache.hadoop.hive.ql.ddl.misc.insert.commit.hook;
 
 Review comment:
   I think that it is a good structure that each operation have their own package, it makes things cleaner. Putting everything under misc would break this structure, and also has a potential problem if in the future there would be more operations under misc, it may be a huge package with an endless list of classes.
   
   I'm ok with renaming the sub packages:
   
   cache.metadata -> metadata
   insert.commit.hook -> hooks
   msck -> msck
   remove.flag -> flags (?)
   show.conf -> conf
   
   Would that be ok? I don't see which of these operations are related enough to be put under the same category, so we'll still have 5 packages, but if in the future we'll have some new configuration, or metadata, or hook related stuff, they can go to the same package, or under some sub packages.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org