You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by kinow <gi...@git.apache.org> on 2017/05/18 09:42:33 UTC
[GitHub] commons-bcel pull request #13: BCEL-289: iterate through parameter annotatio...
GitHub user kinow opened a pull request:
https://github.com/apache/commons-bcel/pull/13
BCEL-289: iterate through parameter annotation entries using the right limit
The code was iterating through the number of parameters (3 in this case, the Bar parent class, and the two annotated parameters, while looking for annotated parameters.
As the constructor method has two annotated parameters, it throws an ArrayIndexOutOfBoundsException.
Found no pull requests with this fix, Maven site reports look OK, no new warnings/errors added, added a simple unit test.
As I never contributed to BCEL, will drop a message to the mailing list asking for someone to review it before I merge it.
Cheers
Bruno
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kinow/commons-bcel BCEL-289
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-bcel/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit d60291173e4d4a589873338547d968a540210507
Author: Bruno P. Kinoshita <br...@yahoo.com.br>
Date: 2017-05-18T09:37:07Z
BCEL-289: iterate through parameter annotation entries using the right limit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-bcel pull request #13: BCEL-289: iterate through parameter annotatio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-bcel/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org