You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@click.apache.org by "Malcolm Edgar (JIRA)" <ji...@apache.org> on 2010/02/26 05:18:27 UTC
[jira] Created: (CLK-633) Upgrade Click API to use type safe
collections
Upgrade Click API to use type safe collections
----------------------------------------------
Key: CLK-633
URL: https://issues.apache.org/jira/browse/CLK-633
Project: Click
Issue Type: Improvement
Components: core, extras
Affects Versions: 2.1.0
Reporter: Malcolm Edgar
Fix For: 2.2.0
Click API's do not expoint the Java 1.5 type safe collection features. We should upgrade these API to include type safe collections. This will help developers understand the API, and will help clean up a lof of warnings developers currently see when developing with Eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (CLK-633) Upgrade Click API to use type safe
collections
Posted by AndreyRybin <ap...@gmail.com>.
Also I found many: ? extends Object.
I think (and IDEA thinks) it is same as single "?".
--
View this message in context: http://click.1134972.n2.nabble.com/jira-Created-CLK-633-Upgrade-Click-API-to-use-type-safe-collections-tp4637138p4993854.html
Sent from the click-development mailing list archive at Nabble.com.
Re: [jira] Updated: (CLK-633) Upgrade Click API to use type safe
collections
Posted by AndreyRybin <ap...@gmail.com>.
Please, look also at my code in https://issues.apache.org/jira/browse/CLK-609
MyPage1 x = getContext().createPage(MyPage1.class);//no explicit cast - we
have all type information
looks much better than
MyPage1 x = (MyPage1) getContext().createPage(MyPage1.class);//explicit cast
(current version)
--
View this message in context: http://click.1134972.n2.nabble.com/jira-Created-CLK-633-Upgrade-Click-API-to-use-type-safe-collections-tp4637138p4992556.html
Sent from the click-development mailing list archive at Nabble.com.
Re: [jira] Updated: (CLK-633) Upgrade Click API to use type safe
collections
Posted by Bob Schellink <sa...@gmail.com>.
Ok, we should get these fixed for 2.2.0 final.
On 2/05/2010 18:19, AndreyRybin wrote:
>
> I checked http://svn.apache.org/repos/asf/click/trunk/click
>
> getHeadElements in many classes is still not generic.
> I used simple regex: public List[^<;] for all *.java files in src folders.
>
> Personally I feel pain from:
> DateField (ex: getHeadElements, addCalendarOptions)
> Tree (ex: getHeadElements, getSelectedNodes, getExpandedNodes)
>
>
Re: [jira] Updated: (CLK-633) Upgrade Click API to use type safe
collections
Posted by AndreyRybin <ap...@gmail.com>.
I checked http://svn.apache.org/repos/asf/click/trunk/click
getHeadElements in many classes is still not generic.
I used simple regex: public List[^<;] for all *.java files in src folders.
Personally I feel pain from:
DateField (ex: getHeadElements, addCalendarOptions)
Tree (ex: getHeadElements, getSelectedNodes, getExpandedNodes)
--
View this message in context: http://click.1134972.n2.nabble.com/jira-Created-CLK-633-Upgrade-Click-API-to-use-type-safe-collections-tp4637138p4992387.html
Sent from the click-development mailing list archive at Nabble.com.
[jira] Commented: (CLK-633) Upgrade Click API to use type safe
collections
Posted by "Andrey Rybin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838760#action_12838760 ]
Andrey Rybin commented on CLK-633:
----------------------------------
I meant this in my issue: https://issues.apache.org/jira/browse/CLK-609 ;-)
The code in my issue is simply additional syntactic sugar.
The core idea was "use generics instead of objects where possible"
> Upgrade Click API to use type safe collections
> ----------------------------------------------
>
> Key: CLK-633
> URL: https://issues.apache.org/jira/browse/CLK-633
> Project: Click
> Issue Type: Improvement
> Components: core, extras
> Affects Versions: 2.1.0
> Reporter: Malcolm Edgar
> Assignee: Malcolm Edgar
> Fix For: 2.2.0
>
>
> Click API's do not expoint the Java 1.5 type safe collection features. We should upgrade these API to include type safe collections. This will help developers understand the API, and will help clean up a lof of warnings developers currently see when developing with Eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CLK-633) Upgrade Click API to use type safe
collections
Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Schellink resolved CLK-633.
-------------------------------
Resolution: Fixed
I believe the conversion to generics have been completed in 2.2.0.
> Upgrade Click API to use type safe collections
> ----------------------------------------------
>
> Key: CLK-633
> URL: https://issues.apache.org/jira/browse/CLK-633
> Project: Click
> Issue Type: Improvement
> Components: core, extras
> Reporter: Malcolm Edgar
> Assignee: Malcolm Edgar
> Fix For: 2.2.0
>
>
> Click API's do not expoint the Java 1.5 type safe collection features. We should upgrade these API to include type safe collections. This will help developers understand the API, and will help clean up a lof of warnings developers currently see when developing with Eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLK-633) Upgrade Click API to use type safe
collections
Posted by "Malcolm Edgar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838773#action_12838773 ]
Malcolm Edgar commented on CLK-633:
-----------------------------------
Mi Andrey,
the issue I have raised is a duplicate of your CLK-609
regards Malcolm Edgar
> Upgrade Click API to use type safe collections
> ----------------------------------------------
>
> Key: CLK-633
> URL: https://issues.apache.org/jira/browse/CLK-633
> Project: Click
> Issue Type: Improvement
> Components: core, extras
> Affects Versions: 2.1.0
> Reporter: Malcolm Edgar
> Assignee: Malcolm Edgar
> Fix For: 2.2.0
>
>
> Click API's do not expoint the Java 1.5 type safe collection features. We should upgrade these API to include type safe collections. This will help developers understand the API, and will help clean up a lof of warnings developers currently see when developing with Eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CLK-633) Upgrade Click API to use
type safe collections
Posted by "Andrey Rybin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838760#action_12838760 ]
Andrey Rybin edited comment on CLK-633 at 2/26/10 8:41 AM:
-----------------------------------------------------------
I meant this in my issue: https://issues.apache.org/jira/browse/CLK-609 ;-)
The code in my issue is simply additional syntactic sugar.
The core idea was "use generics instead of objects where possible"
PS: And yes, IDEA paints all my click code yellow (unsafe type warnings) too ;-(
was (Author: andreyrybin):
I meant this in my issue: https://issues.apache.org/jira/browse/CLK-609 ;-)
The code in my issue is simply additional syntactic sugar.
The core idea was "use generics instead of objects where possible"
> Upgrade Click API to use type safe collections
> ----------------------------------------------
>
> Key: CLK-633
> URL: https://issues.apache.org/jira/browse/CLK-633
> Project: Click
> Issue Type: Improvement
> Components: core, extras
> Affects Versions: 2.1.0
> Reporter: Malcolm Edgar
> Assignee: Malcolm Edgar
> Fix For: 2.2.0
>
>
> Click API's do not expoint the Java 1.5 type safe collection features. We should upgrade these API to include type safe collections. This will help developers understand the API, and will help clean up a lof of warnings developers currently see when developing with Eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CLK-633) Upgrade Click API to use type safe
collections
Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Schellink updated CLK-633:
------------------------------
Fix Version/s: 2.3.0
(was: 2.2.0)
Affects Version/s: 2.2.0
(was: 2.1.0)
Not sure whether this work is finished or not. Moving to next release.
If anyone notices classes missing generics please list them here. Patches welcome too :)
> Upgrade Click API to use type safe collections
> ----------------------------------------------
>
> Key: CLK-633
> URL: https://issues.apache.org/jira/browse/CLK-633
> Project: Click
> Issue Type: Improvement
> Components: core, extras
> Affects Versions: 2.2.0
> Reporter: Malcolm Edgar
> Assignee: Malcolm Edgar
> Fix For: 2.3.0
>
>
> Click API's do not expoint the Java 1.5 type safe collection features. We should upgrade these API to include type safe collections. This will help developers understand the API, and will help clean up a lof of warnings developers currently see when developing with Eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CLK-633) Upgrade Click API to use type safe
collections
Posted by "Malcolm Edgar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Malcolm Edgar reassigned CLK-633:
---------------------------------
Assignee: Malcolm Edgar
> Upgrade Click API to use type safe collections
> ----------------------------------------------
>
> Key: CLK-633
> URL: https://issues.apache.org/jira/browse/CLK-633
> Project: Click
> Issue Type: Improvement
> Components: core, extras
> Affects Versions: 2.1.0
> Reporter: Malcolm Edgar
> Assignee: Malcolm Edgar
> Fix For: 2.2.0
>
>
> Click API's do not expoint the Java 1.5 type safe collection features. We should upgrade these API to include type safe collections. This will help developers understand the API, and will help clean up a lof of warnings developers currently see when developing with Eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CLK-633) Upgrade Click API to use type safe
collections
Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Schellink updated CLK-633:
------------------------------
Fix Version/s: 2.2.0
(was: 2.3.0)
Affects Version/s: (was: 2.2.0)
> Upgrade Click API to use type safe collections
> ----------------------------------------------
>
> Key: CLK-633
> URL: https://issues.apache.org/jira/browse/CLK-633
> Project: Click
> Issue Type: Improvement
> Components: core, extras
> Reporter: Malcolm Edgar
> Assignee: Malcolm Edgar
> Fix For: 2.2.0
>
>
> Click API's do not expoint the Java 1.5 type safe collection features. We should upgrade these API to include type safe collections. This will help developers understand the API, and will help clean up a lof of warnings developers currently see when developing with Eclipse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.