You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/13 07:45:46 UTC

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #9996: ARROW-8900: [C++][Python] Expose Proxy Options as parameters for S3FileSystem

jorisvandenbossche commented on a change in pull request #9996:
URL: https://github.com/apache/arrow/pull/9996#discussion_r612207982



##########
File path: python/pyarrow/_s3fs.pyx
##########
@@ -94,6 +186,11 @@ cdef class S3FileSystem(FileSystem):
     background_writes: boolean, default True
         Whether OutputStream writes will be issued in the background, without
         blocking.
+    proxy_options: dict or pyarrow._s3fs.S3ProxyOptions, default None
+        If a proxy is used, provide the options here. Supported options are:

Review comment:
       Alternatively, we could also only accept a dict here, to avoid needing to create the public `S3ProxyOptions` class? (to limit the API exposure a bit)
   
   In addition, it could also accept a string in which case it would do the equivalent of `S3ProxyOptions.from_uri(..)` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org