You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <da...@elego.de> on 2012/04/10 01:00:32 UTC
Re: svn commit: r1310535 -
/subversion/trunk/subversion/bindings/swig/ruby/test/test_client.rb
Joe Swatosh wrote on Mon, Apr 09, 2012 at 15:25:47 -0700:
> Hi Daniel,
>
> On Sun, Apr 8, 2012 at 2:30 PM, Daniel Shahaf <da...@elego.de> wrote:
> > joeswatosh@apache.org wrote on Fri, Apr 06, 2012 at 18:28:30 -0000:
> >> Author: joeswatosh
> >> Date: Fri Apr 6 18:28:30 2012
> >> New Revision: 1310535
> >>
>
>
> >> def test_changelists_get_without_block
> >> assert_changelists do |ctx, changelist_name|
> >> - ctx.changelists(changelist_name, @wc_path)
> >> + changelists = ctx.changelists(changelist_name, @wc_path)
> >> + changelists.each_value { |v| v.sort! }
> >> + changelists
> >
> > Do you need to sort CHANGELISTS, or only the values therein?
> >
> In this case only the values, as the changelists object is itself a
> Ruby (not APR) hash, so the order of hash values is determined by the
> Object#hash function.
>
Fair enough. (I looked into this code before and my recollection was
that CHANGELISTS was an array.)
> > Don't this and your other recent commit need to be backported to 1.7.x?
> >
> Possibly. Obviously neither commit impacts the bindings themselves,
> but if we are supporting the latest APR in the 1.7 branch, it will
> easier to have the tests passing than to have to explain why they
> aren't. What do you think?
>
Yes please. We backported 1.4.6 support fixes to the main test suite,
so I think we should do so for the bindings tests too.
> Thanks for checking up on me.
>
>
> --
> Joe
>
> >> end
> >> end
> >>
>
> >>
Thanks,
Daniel
Re: svn commit: r1310535 - /subversion/trunk/subversion/bindings/swig/ruby/test/test_client.rb
Posted by Joe Swatosh <jo...@gmail.com>.
On Mon, Apr 9, 2012 at 4:00 PM, Daniel Shahaf <da...@elego.de> wrote:
> Joe Swatosh wrote on Mon, Apr 09, 2012 at 15:25:47 -0700:
>> Hi Daniel,
>> On Sun, Apr 8, 2012 at 2:30 PM, Daniel Shahaf <da...@elego.de> wrote:
>> > joeswatosh@apache.org wrote on Fri, Apr 06, 2012 at 18:28:30 -0000:
>> >> Author: joeswatosh
>> >> Date: Fri Apr 6 18:28:30 2012
>> >> New Revision: 1310535
>
>> > Don't this and your other recent commit need to be backported to 1.7.x?
>> >
>> Possibly. Obviously neither commit impacts the bindings themselves,
>> but if we are supporting the latest APR in the 1.7 branch, it will
>> easier to have the tests passing than to have to explain why they
>> aren't. What do you think?
>>
>
> Yes please. We backported 1.4.6 support fixes to the main test suite,
> so I think we should do so for the bindings tests too.
>
Nominated in r1311547.
--
Joe