You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/18 21:48:36 UTC

[GitHub] [incubator-hudi] smarthi commented on issue #1245: [MINOR] Replace Collection.size > 0 with Collection.isEmpty()

smarthi commented on issue #1245: [MINOR] Replace Collection.size > 0 with Collection.isEmpty()
URL: https://github.com/apache/incubator-hudi/pull/1245#issuecomment-575941333
 
 
   > I am not sure if this is really improving things. its very subjective. I'd argue reading `!isEmpty()` is harder than a simple positive check..
   > 
   > Not sure if I want to really make this change
   
   I agree, maybe consider rebasing this PR after PR# 1159 is merged after 0.5.1 release - PR# 1159 introduces CollectionUtils - u could add this as a method there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services