You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "onichols-pivotal (GitHub)" <gi...@apache.org> on 2018/10/11 22:56:26 UTC
[GitHub] [geode] onichols-pivotal opened pull request #2598:
GEODE-5855 hide jobs that are not gating in default pipeline view
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [n/a] Have you written or updated unit tests to verify your changes?
- [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2598 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] upthewaterspout commented on pull request #2598:
GEODE-5855 hide jobs that are not gating in default pipeline view
Posted by "upthewaterspout (GitHub)" <gi...@apache.org>.
Should this be `java_test_version.name.endsWith("JDK11")` ?
[ Full content available at: https://github.com/apache/geode/pull/2598 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2598:
GEODE-5855 hide jobs that are not gating in default pipeline view
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
I almost hate to comment on one-line PRs, but if the intent is "only the things that act as blocking for `UpdatePassingRef`, then we should use the same as that block:
```
- name: UpdatePassingRef - name: UpdatePassingRef
public: true public: true
serial: true serial: true
plan: plan:
- get: geode - get: geode
passed: passed:
{% for test in tests if not (test.name=="StressNew" or test.name.startswith("Windows")) -%} {% for test in tests if not (test.name=="StressNew" or test.name.startswith("Windows")) -%}
- {{test.name}}TestOpenJDK8 - {{test.name}}TestOpenJDK8
{% endfor %} {% endfor %}
trigger: true
```
and/or macro / explicitly define the "these are the jobs" list in our Jinja parameters somewhere.
[ Full content available at: https://github.com/apache/geode/pull/2598 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dickcav commented on pull request #2598: GEODE-5855
hide jobs that are not gating in default pipeline view
Posted by "dickcav (GitHub)" <gi...@apache.org>.
@pivotal-amurmann may want to review this.
[ Full content available at: https://github.com/apache/geode/pull/2598 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2598:
GEODE-5855 hide jobs that are not gating in default pipeline view
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
I almost hate to comment on one-line PRs, but if the intent is "only the things that act as blocking for `UpdatePassingRef`, then we should use the same as that block:
```
- name: UpdatePassingRef
public: true
serial: true
plan:
- get: geode
passed:
{% for test in tests if not (test.name=="StressNew" or test.name.startswith("Windows")) -%}
- {{test.name}}TestOpenJDK8
{% endfor %}
trigger: true
[...]
```
and/or macro / explicitly define the "these are the jobs" list in our Jinja parameters somewhere.
[ Full content available at: https://github.com/apache/geode/pull/2598 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dickcav commented on pull request #2598: GEODE-5855
hide jobs that are not gating in default pipeline view
Posted by "dickcav (GitHub)" <gi...@apache.org>.
@pivotal-amurmann Should we then have an All or Complete so we can see them all?
[ Full content available at: https://github.com/apache/geode/pull/2598 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dickcav closed pull request #2598: GEODE-5855 hide
jobs that are not gating in default pipeline view
Posted by "dickcav (GitHub)" <gi...@apache.org>.
[ pull request closed by dickcav ]
[ Full content available at: https://github.com/apache/geode/pull/2598 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #2598:
GEODE-5855 hide jobs that are not gating in default pipeline view
Posted by "onichols-pivotal (GitHub)" <gi...@apache.org>.
created a macro for all_gating_jobs and added "complete" tab
[ Full content available at: https://github.com/apache/geode/pull/2598 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org