You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/20 09:32:29 UTC
[GitHub] [flink] wanglijie95 commented on a diff in pull request #20218: [FLINK-28145][runtime] Let ResourceManager supports blocklist
wanglijie95 commented on code in PR #20218:
URL: https://github.com/apache/flink/pull/20218#discussion_r925389418
##########
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategyTest.java:
##########
@@ -66,25 +62,25 @@ public void testFulfillRequirementWithRegisteredResources() {
STRATEGY.tryFulfillRequirements(
Collections.singletonMap(jobId, requirements),
taskManagerResourceInfoProvider);
- assertThat(result.getUnfulfillableJobs(), is(empty()));
- assertThat(result.getAllocationsOnPendingResources().keySet(), is(empty()));
- assertThat(result.getPendingTaskManagersToAllocate(), is(empty()));
+ assertThat(result.getUnfulfillableJobs()).isEmpty();
+ assertThat(result.getAllocationsOnPendingResources().keySet()).isEmpty();
Review Comment:
FIxed
##########
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategyTest.java:
##########
@@ -102,9 +98,9 @@ public void testFulfillRequirementWithPendingResources() {
STRATEGY.tryFulfillRequirements(
Collections.singletonMap(jobId, requirements),
taskManagerResourceInfoProvider);
- assertThat(result.getUnfulfillableJobs(), is(empty()));
- assertThat(result.getAllocationsOnRegisteredResources().keySet(), is(empty()));
- assertThat(result.getPendingTaskManagersToAllocate().size(), is(1));
+ assertThat(result.getUnfulfillableJobs()).isEmpty();
+ assertThat(result.getAllocationsOnRegisteredResources().keySet()).isEmpty();
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org