You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/02/01 03:30:54 UTC
Review Request: SQOOP-860 NullPointerException when running procedure export
against old database
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9211/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
Instead of returning null, I've changed the code to re-throw the exception.
This addresses bug SQOOP-860.
https://issues.apache.org/jira/browse/SQOOP-860
Diffs
-----
src/java/org/apache/sqoop/manager/SqlManager.java 03c9e64d3a08a2ef6a1b38720e67f7d2569b93c2
Diff: https://reviews.apache.org/r/9211/diff/
Testing
-------
I've done testing against old PostgreSQL instance where I detected original NPE, I'm now getting RuntimeException as expected.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-860 NullPointerException when running procedure
export against old database
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9211/#review16210
-----------------------------------------------------------
Ship it!
Ship It!
- Cheolsoo Park
On Feb. 1, 2013, 2:30 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9211/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 2:30 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Instead of returning null, I've changed the code to re-throw the exception.
>
>
> This addresses bug SQOOP-860.
> https://issues.apache.org/jira/browse/SQOOP-860
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/manager/SqlManager.java 03c9e64d3a08a2ef6a1b38720e67f7d2569b93c2
>
> Diff: https://reviews.apache.org/r/9211/diff/
>
>
> Testing
> -------
>
> I've done testing against old PostgreSQL instance where I detected original NPE, I'm now getting RuntimeException as expected.
>
>
> Thanks,
>
> Jarek Cecho
>
>