You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/04 03:12:55 UTC
[GitHub] [incubator-doris] vagetablechicken opened a new pull request #4243: [Bug] fix after making MemTracker shared
vagetablechicken opened a new pull request #4243:
URL: https://github.com/apache/incubator-doris/pull/4243
after making MemTracker shared(https://github.com/apache/incubator-doris/pull/4135), some code haven't been fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4243: [Bug] fix after making MemTracker shared
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4243:
URL: https://github.com/apache/incubator-doris/pull/4243
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #4243: [Bug] fix after making MemTracker shared
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #4243:
URL: https://github.com/apache/incubator-doris/pull/4243#discussion_r464892521
##########
File path: be/test/runtime/CMakeLists.txt
##########
@@ -42,10 +42,11 @@ ADD_BE_TEST(fragment_mgr_test)
#ADD_BE_TEST(data_spliter_test)
#ADD_BE_TEST(etl_job_mgr_test)
-# ADD_BE_TEST(tmp_file_mgr_test)
-ADD_BE_TEST(mem_limit_test)
-ADD_BE_TEST(buffered_block_mgr2_test)
-ADD_BE_TEST(buffered_tuple_stream2_test)
+#ADD_BE_TEST(tmp_file_mgr_test)
+#ADD_BE_TEST(disk_io_mgr_test)
+#ADD_BE_TEST(mem_limit_test)
Review comment:
Why comment these three unit tests ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #4243: [Bug] fix after making MemTracker shared
Posted by GitBox <gi...@apache.org>.
vagetablechicken commented on a change in pull request #4243:
URL: https://github.com/apache/incubator-doris/pull/4243#discussion_r464898707
##########
File path: be/test/runtime/CMakeLists.txt
##########
@@ -42,10 +42,11 @@ ADD_BE_TEST(fragment_mgr_test)
#ADD_BE_TEST(data_spliter_test)
#ADD_BE_TEST(etl_job_mgr_test)
-# ADD_BE_TEST(tmp_file_mgr_test)
-ADD_BE_TEST(mem_limit_test)
-ADD_BE_TEST(buffered_block_mgr2_test)
-ADD_BE_TEST(buffered_tuple_stream2_test)
+#ADD_BE_TEST(tmp_file_mgr_test)
+#ADD_BE_TEST(disk_io_mgr_test)
+#ADD_BE_TEST(mem_limit_test)
Review comment:
it's a mistake uncomment of pr 4135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org