You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/01/03 23:08:12 UTC

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files 

Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12152


Change subject: IMPALA-6521: Show experimental flags in /varz and log files
......................................................................

IMPALA-6521: Show experimental flags in /varz and log files

This patch shows the experimental flags when set in /varz by adding
a new "Experimental" column in /varz web page. The patch also updates
the log files to show experimental flags when set.

Testing:
- Added a new test for /varz web page
- Manually looked at the log files and /varz web oage with experimental
  flags set

Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
---
M be/src/common/logging.cc
M be/src/util/default-path-handlers.cc
M bin/impala-config.sh
A tests/custom_cluster/test_web_pages.py
M www/flags.tmpl
5 files changed, 65 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/12152/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
Gerrit-Change-Number: 12152
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 )

Change subject: IMPALA-6521: Show experimental flags in /varz and log files
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/1704/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
Gerrit-Change-Number: 12152
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Jan 2019 23:38:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 )

Change subject: IMPALA-6521: Show experimental flags in /varz and log files
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/12152/2/be/src/common/logging.cc
File be/src/common/logging.cc:

http://gerrit.cloudera.org:8080/#/c/12152/2/be/src/common/logging.cc@165
PS2, Line 165: }
> better to use a stringstream for building strings (appending to string can 
Done


http://gerrit.cloudera.org:8080/#/c/12152/2/be/src/common/logging.cc@166
PS2, Line 166:   }
> I'm confused by this iteration logic. Why not something like:
Done


http://gerrit.cloudera.org:8080/#/c/12152/2/tests/custom_cluster/test_web_pages.py
File tests/custom_cluster/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/12152/2/tests/custom_cluster/test_web_pages.py@35
PS2, Line 35: [e for
> I think list comprehensions are generally preferred to filter() in python -
TIL. Done.



-- 
To view, visit http://gerrit.cloudera.org:8080/12152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
Gerrit-Change-Number: 12152
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Jan 2019 01:08:38 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 )

Change subject: IMPALA-6521: Show experimental flags in /varz and log files
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/1708/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
Gerrit-Change-Number: 12152
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Jan 2019 01:39:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 )

Change subject: IMPALA-6521: Show experimental flags in /varz and log files
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3610/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/12152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
Gerrit-Change-Number: 12152
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Jan 2019 01:41:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 )

Change subject: IMPALA-6521: Show experimental flags in /varz and log files
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
Gerrit-Change-Number: 12152
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Jan 2019 05:34:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12152 )

Change subject: IMPALA-6521: Show experimental flags in /varz and log files
......................................................................

IMPALA-6521: Show experimental flags in /varz and log files

This patch shows the experimental flags when set in /varz by adding
a new "Experimental" column in /varz web page. The patch also updates
the log files to show experimental flags when set.

Testing:
- Added a new test for /varz web page
- Manually looked at the log files and /varz web page with experimental
  flags set

Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
Reviewed-on: http://gerrit.cloudera.org:8080/12152
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/common/logging.cc
M be/src/util/default-path-handlers.cc
M bin/impala-config.sh
A tests/custom_cluster/test_web_pages.py
M www/flags.tmpl
5 files changed, 61 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
Gerrit-Change-Number: 12152
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 )

Change subject: IMPALA-6521: Show experimental flags in /varz and log files
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/1705/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
Gerrit-Change-Number: 12152
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Jan 2019 23:46:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 )

Change subject: IMPALA-6521: Show experimental flags in /varz and log files
......................................................................


Patch Set 2:

(3 comments)

Generally seems good, had some style comments

http://gerrit.cloudera.org:8080/#/c/12152/2/be/src/common/logging.cc
File be/src/common/logging.cc:

http://gerrit.cloudera.org:8080/#/c/12152/2/be/src/common/logging.cc@165
PS2, Line 165: string
better to use a stringstream for building strings (appending to string can be quadratic, I think).


http://gerrit.cloudera.org:8080/#/c/12152/2/be/src/common/logging.cc@166
PS2, Line 166:     for (auto i = flags.begin(); i != iter; ++i) {
I'm confused by this iteration logic. Why not something like:

for (const auto& flag : flags) {
  if (!flag.hidden) continue;
  ...
}


http://gerrit.cloudera.org:8080/#/c/12152/2/tests/custom_cluster/test_web_pages.py
File tests/custom_cluster/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/12152/2/tests/custom_cluster/test_web_pages.py@35
PS2, Line 35: filter
I think list comprehensions are generally preferred to filter() in python - https://www.artima.com/weblogs/viewpost.jsp?thread=98196



-- 
To view, visit http://gerrit.cloudera.org:8080/12152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
Gerrit-Change-Number: 12152
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Jan 2019 23:23:31 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 )

Change subject: IMPALA-6521: Show experimental flags in /varz and log files
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
Gerrit-Change-Number: 12152
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Jan 2019 01:41:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12152 )

Change subject: IMPALA-6521: Show experimental flags in /varz and log files
......................................................................

IMPALA-6521: Show experimental flags in /varz and log files

This patch shows the experimental flags when set in /varz by adding
a new "Experimental" column in /varz web page. The patch also updates
the log files to show experimental flags when set.

Testing:
- Added a new test for /varz web page
- Manually looked at the log files and /varz web page with experimental
  flags set

Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
---
M be/src/common/logging.cc
M be/src/util/default-path-handlers.cc
M bin/impala-config.sh
A tests/custom_cluster/test_web_pages.py
M www/flags.tmpl
5 files changed, 65 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/12152/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
Gerrit-Change-Number: 12152
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12152 )

Change subject: IMPALA-6521: Show experimental flags in /varz and log files
......................................................................

IMPALA-6521: Show experimental flags in /varz and log files

This patch shows the experimental flags when set in /varz by adding
a new "Experimental" column in /varz web page. The patch also updates
the log files to show experimental flags when set.

Testing:
- Added a new test for /varz web page
- Manually looked at the log files and /varz web page with experimental
  flags set

Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
---
M be/src/common/logging.cc
M be/src/util/default-path-handlers.cc
M bin/impala-config.sh
A tests/custom_cluster/test_web_pages.py
M www/flags.tmpl
5 files changed, 61 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/12152/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
Gerrit-Change-Number: 12152
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 )

Change subject: IMPALA-6521: Show experimental flags in /varz and log files
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13b2694b445059e7e52c1ae56bd7e0e925fbb0e
Gerrit-Change-Number: 12152
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Jan 2019 01:16:07 +0000
Gerrit-HasComments: No