You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/02 13:21:07 UTC

[GitHub] [incubator-superset] bryanck commented on a change in pull request #10435: fix(log): log endpoint authentication

bryanck commented on a change in pull request #10435:
URL: https://github.com/apache/incubator-superset/pull/10435#discussion_r498816767



##########
File path: superset/views/core.py
##########
@@ -1690,6 +1690,7 @@ def dashboard(**_: Any) -> None:
 
     @api
     @event_logger.log_this
+    @has_access

Review comment:
       I'm seeing a regression with this change. I'm getting auth failures. Changing this to @has_access_api fixes the issue




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org