You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/08/28 14:48:27 UTC
[27/51] [partial] hbase-site git commit: Published site at
3afe9fb7e6ebfa71187cbe131558a83fae61cecd.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/424d7e41/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/AssignmentManager.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/AssignmentManager.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/AssignmentManager.html
index e42e654..fe4e081 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/AssignmentManager.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/AssignmentManager.html
@@ -560,7 +560,7 @@
<span class="sourceLineNo">552</span> TransitRegionStateProcedure proc;<a name="line.552"></a>
<span class="sourceLineNo">553</span> regionNode.lock();<a name="line.553"></a>
<span class="sourceLineNo">554</span> try {<a name="line.554"></a>
-<span class="sourceLineNo">555</span> preTransitCheck(regionNode, RegionStates.STATES_EXPECTED_ON_OPEN);<a name="line.555"></a>
+<span class="sourceLineNo">555</span> preTransitCheck(regionNode, STATES_EXPECTED_ON_ASSIGN);<a name="line.555"></a>
<span class="sourceLineNo">556</span> proc = TransitRegionStateProcedure.assign(getProcedureEnvironment(), regionInfo, sn);<a name="line.556"></a>
<span class="sourceLineNo">557</span> regionNode.setProcedure(proc);<a name="line.557"></a>
<span class="sourceLineNo">558</span> } finally {<a name="line.558"></a>
@@ -581,7 +581,7 @@
<span class="sourceLineNo">573</span> TransitRegionStateProcedure proc;<a name="line.573"></a>
<span class="sourceLineNo">574</span> regionNode.lock();<a name="line.574"></a>
<span class="sourceLineNo">575</span> try {<a name="line.575"></a>
-<span class="sourceLineNo">576</span> preTransitCheck(regionNode, RegionStates.STATES_EXPECTED_ON_CLOSE);<a name="line.576"></a>
+<span class="sourceLineNo">576</span> preTransitCheck(regionNode, STATES_EXPECTED_ON_UNASSIGN_OR_MOVE);<a name="line.576"></a>
<span class="sourceLineNo">577</span> proc = TransitRegionStateProcedure.unassign(getProcedureEnvironment(), regionInfo);<a name="line.577"></a>
<span class="sourceLineNo">578</span> regionNode.setProcedure(proc);<a name="line.578"></a>
<span class="sourceLineNo">579</span> } finally {<a name="line.579"></a>
@@ -599,7 +599,7 @@
<span class="sourceLineNo">591</span> TransitRegionStateProcedure proc;<a name="line.591"></a>
<span class="sourceLineNo">592</span> regionNode.lock();<a name="line.592"></a>
<span class="sourceLineNo">593</span> try {<a name="line.593"></a>
-<span class="sourceLineNo">594</span> preTransitCheck(regionNode, RegionStates.STATES_EXPECTED_ON_CLOSE);<a name="line.594"></a>
+<span class="sourceLineNo">594</span> preTransitCheck(regionNode, STATES_EXPECTED_ON_UNASSIGN_OR_MOVE);<a name="line.594"></a>
<span class="sourceLineNo">595</span> regionNode.checkOnline();<a name="line.595"></a>
<span class="sourceLineNo">596</span> proc = TransitRegionStateProcedure.move(getProcedureEnvironment(), regionInfo, targetServer);<a name="line.596"></a>
<span class="sourceLineNo">597</span> regionNode.setProcedure(proc);<a name="line.597"></a>
@@ -1419,448 +1419,483 @@
<span class="sourceLineNo">1411</span> }<a name="line.1411"></a>
<span class="sourceLineNo">1412</span><a name="line.1412"></a>
<span class="sourceLineNo">1413</span> // ============================================================================================<a name="line.1413"></a>
-<span class="sourceLineNo">1414</span> // Region Status update<a name="line.1414"></a>
-<span class="sourceLineNo">1415</span> // Should only be called in TransitRegionStateProcedure<a name="line.1415"></a>
-<span class="sourceLineNo">1416</span> // ============================================================================================<a name="line.1416"></a>
-<span class="sourceLineNo">1417</span> private void transitStateAndUpdate(RegionStateNode regionNode, RegionState.State newState,<a name="line.1417"></a>
-<span class="sourceLineNo">1418</span> RegionState.State... expectedStates) throws IOException {<a name="line.1418"></a>
-<span class="sourceLineNo">1419</span> RegionState.State state = regionNode.getState();<a name="line.1419"></a>
-<span class="sourceLineNo">1420</span> regionNode.transitionState(newState, expectedStates);<a name="line.1420"></a>
-<span class="sourceLineNo">1421</span> boolean succ = false;<a name="line.1421"></a>
-<span class="sourceLineNo">1422</span> try {<a name="line.1422"></a>
-<span class="sourceLineNo">1423</span> regionStateStore.updateRegionLocation(regionNode);<a name="line.1423"></a>
-<span class="sourceLineNo">1424</span> succ = true;<a name="line.1424"></a>
-<span class="sourceLineNo">1425</span> } finally {<a name="line.1425"></a>
-<span class="sourceLineNo">1426</span> if (!succ) {<a name="line.1426"></a>
-<span class="sourceLineNo">1427</span> // revert<a name="line.1427"></a>
-<span class="sourceLineNo">1428</span> regionNode.setState(state);<a name="line.1428"></a>
-<span class="sourceLineNo">1429</span> }<a name="line.1429"></a>
-<span class="sourceLineNo">1430</span> }<a name="line.1430"></a>
-<span class="sourceLineNo">1431</span> }<a name="line.1431"></a>
-<span class="sourceLineNo">1432</span><a name="line.1432"></a>
-<span class="sourceLineNo">1433</span> // should be called within the synchronized block of RegionStateNode<a name="line.1433"></a>
-<span class="sourceLineNo">1434</span> void regionOpening(RegionStateNode regionNode) throws IOException {<a name="line.1434"></a>
-<span class="sourceLineNo">1435</span> transitStateAndUpdate(regionNode, State.OPENING, RegionStates.STATES_EXPECTED_ON_OPEN);<a name="line.1435"></a>
-<span class="sourceLineNo">1436</span> regionStates.addRegionToServer(regionNode);<a name="line.1436"></a>
-<span class="sourceLineNo">1437</span> // update the operation count metrics<a name="line.1437"></a>
-<span class="sourceLineNo">1438</span> metrics.incrementOperationCounter();<a name="line.1438"></a>
-<span class="sourceLineNo">1439</span> }<a name="line.1439"></a>
-<span class="sourceLineNo">1440</span><a name="line.1440"></a>
-<span class="sourceLineNo">1441</span> // should be called within the synchronized block of RegionStateNode.<a name="line.1441"></a>
-<span class="sourceLineNo">1442</span> // The parameter 'giveUp' means whether we will try to open the region again, if it is true, then<a name="line.1442"></a>
-<span class="sourceLineNo">1443</span> // we will persist the FAILED_OPEN state into hbase:meta.<a name="line.1443"></a>
-<span class="sourceLineNo">1444</span> void regionFailedOpen(RegionStateNode regionNode, boolean giveUp) throws IOException {<a name="line.1444"></a>
-<span class="sourceLineNo">1445</span> RegionState.State state = regionNode.getState();<a name="line.1445"></a>
-<span class="sourceLineNo">1446</span> ServerName regionLocation = regionNode.getRegionLocation();<a name="line.1446"></a>
-<span class="sourceLineNo">1447</span> if (giveUp) {<a name="line.1447"></a>
-<span class="sourceLineNo">1448</span> regionNode.setState(State.FAILED_OPEN);<a name="line.1448"></a>
-<span class="sourceLineNo">1449</span> regionNode.setRegionLocation(null);<a name="line.1449"></a>
-<span class="sourceLineNo">1450</span> boolean succ = false;<a name="line.1450"></a>
-<span class="sourceLineNo">1451</span> try {<a name="line.1451"></a>
-<span class="sourceLineNo">1452</span> regionStateStore.updateRegionLocation(regionNode);<a name="line.1452"></a>
-<span class="sourceLineNo">1453</span> succ = true;<a name="line.1453"></a>
-<span class="sourceLineNo">1454</span> } finally {<a name="line.1454"></a>
-<span class="sourceLineNo">1455</span> if (!succ) {<a name="line.1455"></a>
-<span class="sourceLineNo">1456</span> // revert<a name="line.1456"></a>
-<span class="sourceLineNo">1457</span> regionNode.setState(state);<a name="line.1457"></a>
-<span class="sourceLineNo">1458</span> regionNode.setRegionLocation(regionLocation);<a name="line.1458"></a>
-<span class="sourceLineNo">1459</span> }<a name="line.1459"></a>
-<span class="sourceLineNo">1460</span> }<a name="line.1460"></a>
-<span class="sourceLineNo">1461</span> }<a name="line.1461"></a>
-<span class="sourceLineNo">1462</span> if (regionLocation != null) {<a name="line.1462"></a>
-<span class="sourceLineNo">1463</span> regionStates.removeRegionFromServer(regionLocation, regionNode);<a name="line.1463"></a>
-<span class="sourceLineNo">1464</span> }<a name="line.1464"></a>
-<span class="sourceLineNo">1465</span> }<a name="line.1465"></a>
-<span class="sourceLineNo">1466</span><a name="line.1466"></a>
-<span class="sourceLineNo">1467</span> // should be called within the synchronized block of RegionStateNode<a name="line.1467"></a>
-<span class="sourceLineNo">1468</span> void regionOpened(RegionStateNode regionNode) throws IOException {<a name="line.1468"></a>
-<span class="sourceLineNo">1469</span> // TODO: OPENING Updates hbase:meta too... we need to do both here and there?<a name="line.1469"></a>
-<span class="sourceLineNo">1470</span> // That is a lot of hbase:meta writing.<a name="line.1470"></a>
-<span class="sourceLineNo">1471</span> transitStateAndUpdate(regionNode, State.OPEN, RegionStates.STATES_EXPECTED_ON_OPEN);<a name="line.1471"></a>
-<span class="sourceLineNo">1472</span> RegionInfo hri = regionNode.getRegionInfo();<a name="line.1472"></a>
-<span class="sourceLineNo">1473</span> if (isMetaRegion(hri)) {<a name="line.1473"></a>
-<span class="sourceLineNo">1474</span> // Usually we'd set a table ENABLED at this stage but hbase:meta is ALWAYs enabled, it<a name="line.1474"></a>
-<span class="sourceLineNo">1475</span> // can't be disabled -- so skip the RPC (besides... enabled is managed by TableStateManager<a name="line.1475"></a>
-<span class="sourceLineNo">1476</span> // which is backed by hbase:meta... Avoid setting ENABLED to avoid having to update state<a name="line.1476"></a>
-<span class="sourceLineNo">1477</span> // on table that contains state.<a name="line.1477"></a>
-<span class="sourceLineNo">1478</span> setMetaAssigned(hri, true);<a name="line.1478"></a>
-<span class="sourceLineNo">1479</span> }<a name="line.1479"></a>
-<span class="sourceLineNo">1480</span> regionStates.addRegionToServer(regionNode);<a name="line.1480"></a>
-<span class="sourceLineNo">1481</span> regionStates.removeFromFailedOpen(hri);<a name="line.1481"></a>
-<span class="sourceLineNo">1482</span> }<a name="line.1482"></a>
-<span class="sourceLineNo">1483</span><a name="line.1483"></a>
-<span class="sourceLineNo">1484</span> // should be called within the synchronized block of RegionStateNode<a name="line.1484"></a>
-<span class="sourceLineNo">1485</span> void regionClosing(RegionStateNode regionNode) throws IOException {<a name="line.1485"></a>
-<span class="sourceLineNo">1486</span> transitStateAndUpdate(regionNode, State.CLOSING, RegionStates.STATES_EXPECTED_ON_CLOSE);<a name="line.1486"></a>
-<span class="sourceLineNo">1487</span> regionStateStore.updateRegionLocation(regionNode);<a name="line.1487"></a>
-<span class="sourceLineNo">1488</span><a name="line.1488"></a>
-<span class="sourceLineNo">1489</span> RegionInfo hri = regionNode.getRegionInfo();<a name="line.1489"></a>
-<span class="sourceLineNo">1490</span> // Set meta has not initialized early. so people trying to create/edit tables will wait<a name="line.1490"></a>
-<span class="sourceLineNo">1491</span> if (isMetaRegion(hri)) {<a name="line.1491"></a>
-<span class="sourceLineNo">1492</span> setMetaAssigned(hri, false);<a name="line.1492"></a>
+<span class="sourceLineNo">1414</span> // Expected states on region state transition.<a name="line.1414"></a>
+<span class="sourceLineNo">1415</span> // Notice that there is expected states for transiting to OPENING state, this is because SCP.<a name="line.1415"></a>
+<span class="sourceLineNo">1416</span> // See the comments in regionOpening method for more details.<a name="line.1416"></a>
+<span class="sourceLineNo">1417</span> // ============================================================================================<a name="line.1417"></a>
+<span class="sourceLineNo">1418</span> private static final State[] STATES_EXPECTED_ON_OPEN = {<a name="line.1418"></a>
+<span class="sourceLineNo">1419</span> State.OPENING, // Normal case<a name="line.1419"></a>
+<span class="sourceLineNo">1420</span> State.OPEN // Retrying<a name="line.1420"></a>
+<span class="sourceLineNo">1421</span> };<a name="line.1421"></a>
+<span class="sourceLineNo">1422</span><a name="line.1422"></a>
+<span class="sourceLineNo">1423</span> private static final State[] STATES_EXPECTED_ON_CLOSING = {<a name="line.1423"></a>
+<span class="sourceLineNo">1424</span> State.OPEN, // Normal case<a name="line.1424"></a>
+<span class="sourceLineNo">1425</span> State.CLOSING, // Retrying<a name="line.1425"></a>
+<span class="sourceLineNo">1426</span> State.SPLITTING, // Offline the split parent<a name="line.1426"></a>
+<span class="sourceLineNo">1427</span> State.MERGING // Offline the merge parents<a name="line.1427"></a>
+<span class="sourceLineNo">1428</span> };<a name="line.1428"></a>
+<span class="sourceLineNo">1429</span><a name="line.1429"></a>
+<span class="sourceLineNo">1430</span> private static final State[] STATES_EXPECTED_ON_CLOSED = {<a name="line.1430"></a>
+<span class="sourceLineNo">1431</span> State.CLOSING, // Normal case<a name="line.1431"></a>
+<span class="sourceLineNo">1432</span> State.CLOSED // Retrying<a name="line.1432"></a>
+<span class="sourceLineNo">1433</span> };<a name="line.1433"></a>
+<span class="sourceLineNo">1434</span><a name="line.1434"></a>
+<span class="sourceLineNo">1435</span> // This is for manually scheduled region assign, can add other states later if we find out other<a name="line.1435"></a>
+<span class="sourceLineNo">1436</span> // usages<a name="line.1436"></a>
+<span class="sourceLineNo">1437</span> private static final State[] STATES_EXPECTED_ON_ASSIGN = { State.CLOSED, State.OFFLINE };<a name="line.1437"></a>
+<span class="sourceLineNo">1438</span><a name="line.1438"></a>
+<span class="sourceLineNo">1439</span> // We only allow unassign or move a region which is in OPEN state.<a name="line.1439"></a>
+<span class="sourceLineNo">1440</span> private static final State[] STATES_EXPECTED_ON_UNASSIGN_OR_MOVE = { State.OPEN };<a name="line.1440"></a>
+<span class="sourceLineNo">1441</span><a name="line.1441"></a>
+<span class="sourceLineNo">1442</span> // ============================================================================================<a name="line.1442"></a>
+<span class="sourceLineNo">1443</span> // Region Status update<a name="line.1443"></a>
+<span class="sourceLineNo">1444</span> // Should only be called in TransitRegionStateProcedure<a name="line.1444"></a>
+<span class="sourceLineNo">1445</span> // ============================================================================================<a name="line.1445"></a>
+<span class="sourceLineNo">1446</span> private void transitStateAndUpdate(RegionStateNode regionNode, RegionState.State newState,<a name="line.1446"></a>
+<span class="sourceLineNo">1447</span> RegionState.State... expectedStates) throws IOException {<a name="line.1447"></a>
+<span class="sourceLineNo">1448</span> RegionState.State state = regionNode.getState();<a name="line.1448"></a>
+<span class="sourceLineNo">1449</span> regionNode.transitionState(newState, expectedStates);<a name="line.1449"></a>
+<span class="sourceLineNo">1450</span> boolean succ = false;<a name="line.1450"></a>
+<span class="sourceLineNo">1451</span> try {<a name="line.1451"></a>
+<span class="sourceLineNo">1452</span> regionStateStore.updateRegionLocation(regionNode);<a name="line.1452"></a>
+<span class="sourceLineNo">1453</span> succ = true;<a name="line.1453"></a>
+<span class="sourceLineNo">1454</span> } finally {<a name="line.1454"></a>
+<span class="sourceLineNo">1455</span> if (!succ) {<a name="line.1455"></a>
+<span class="sourceLineNo">1456</span> // revert<a name="line.1456"></a>
+<span class="sourceLineNo">1457</span> regionNode.setState(state);<a name="line.1457"></a>
+<span class="sourceLineNo">1458</span> }<a name="line.1458"></a>
+<span class="sourceLineNo">1459</span> }<a name="line.1459"></a>
+<span class="sourceLineNo">1460</span> }<a name="line.1460"></a>
+<span class="sourceLineNo">1461</span><a name="line.1461"></a>
+<span class="sourceLineNo">1462</span> // should be called within the synchronized block of RegionStateNode<a name="line.1462"></a>
+<span class="sourceLineNo">1463</span> void regionOpening(RegionStateNode regionNode) throws IOException {<a name="line.1463"></a>
+<span class="sourceLineNo">1464</span> // As in SCP, for performance reason, there is no TRSP attached with this region, we will not<a name="line.1464"></a>
+<span class="sourceLineNo">1465</span> // update the region state, which means that the region could be in any state when we want to<a name="line.1465"></a>
+<span class="sourceLineNo">1466</span> // assign it after a RS crash. So here we do not pass the expectedStates parameter.<a name="line.1466"></a>
+<span class="sourceLineNo">1467</span> transitStateAndUpdate(regionNode, State.OPENING);<a name="line.1467"></a>
+<span class="sourceLineNo">1468</span> regionStates.addRegionToServer(regionNode);<a name="line.1468"></a>
+<span class="sourceLineNo">1469</span> // update the operation count metrics<a name="line.1469"></a>
+<span class="sourceLineNo">1470</span> metrics.incrementOperationCounter();<a name="line.1470"></a>
+<span class="sourceLineNo">1471</span> }<a name="line.1471"></a>
+<span class="sourceLineNo">1472</span><a name="line.1472"></a>
+<span class="sourceLineNo">1473</span> // should be called within the synchronized block of RegionStateNode.<a name="line.1473"></a>
+<span class="sourceLineNo">1474</span> // The parameter 'giveUp' means whether we will try to open the region again, if it is true, then<a name="line.1474"></a>
+<span class="sourceLineNo">1475</span> // we will persist the FAILED_OPEN state into hbase:meta.<a name="line.1475"></a>
+<span class="sourceLineNo">1476</span> void regionFailedOpen(RegionStateNode regionNode, boolean giveUp) throws IOException {<a name="line.1476"></a>
+<span class="sourceLineNo">1477</span> RegionState.State state = regionNode.getState();<a name="line.1477"></a>
+<span class="sourceLineNo">1478</span> ServerName regionLocation = regionNode.getRegionLocation();<a name="line.1478"></a>
+<span class="sourceLineNo">1479</span> if (giveUp) {<a name="line.1479"></a>
+<span class="sourceLineNo">1480</span> regionNode.setState(State.FAILED_OPEN);<a name="line.1480"></a>
+<span class="sourceLineNo">1481</span> regionNode.setRegionLocation(null);<a name="line.1481"></a>
+<span class="sourceLineNo">1482</span> boolean succ = false;<a name="line.1482"></a>
+<span class="sourceLineNo">1483</span> try {<a name="line.1483"></a>
+<span class="sourceLineNo">1484</span> regionStateStore.updateRegionLocation(regionNode);<a name="line.1484"></a>
+<span class="sourceLineNo">1485</span> succ = true;<a name="line.1485"></a>
+<span class="sourceLineNo">1486</span> } finally {<a name="line.1486"></a>
+<span class="sourceLineNo">1487</span> if (!succ) {<a name="line.1487"></a>
+<span class="sourceLineNo">1488</span> // revert<a name="line.1488"></a>
+<span class="sourceLineNo">1489</span> regionNode.setState(state);<a name="line.1489"></a>
+<span class="sourceLineNo">1490</span> regionNode.setRegionLocation(regionLocation);<a name="line.1490"></a>
+<span class="sourceLineNo">1491</span> }<a name="line.1491"></a>
+<span class="sourceLineNo">1492</span> }<a name="line.1492"></a>
<span class="sourceLineNo">1493</span> }<a name="line.1493"></a>
-<span class="sourceLineNo">1494</span> regionStates.addRegionToServer(regionNode);<a name="line.1494"></a>
-<span class="sourceLineNo">1495</span> // update the operation count metrics<a name="line.1495"></a>
-<span class="sourceLineNo">1496</span> metrics.incrementOperationCounter();<a name="line.1496"></a>
+<span class="sourceLineNo">1494</span> if (regionLocation != null) {<a name="line.1494"></a>
+<span class="sourceLineNo">1495</span> regionStates.removeRegionFromServer(regionLocation, regionNode);<a name="line.1495"></a>
+<span class="sourceLineNo">1496</span> }<a name="line.1496"></a>
<span class="sourceLineNo">1497</span> }<a name="line.1497"></a>
<span class="sourceLineNo">1498</span><a name="line.1498"></a>
<span class="sourceLineNo">1499</span> // should be called within the synchronized block of RegionStateNode<a name="line.1499"></a>
-<span class="sourceLineNo">1500</span> // The parameter 'normally' means whether we are closed cleanly, if it is true, then it means that<a name="line.1500"></a>
-<span class="sourceLineNo">1501</span> // we are closed due to a RS crash.<a name="line.1501"></a>
-<span class="sourceLineNo">1502</span> void regionClosed(RegionStateNode regionNode, boolean normally) throws IOException {<a name="line.1502"></a>
-<span class="sourceLineNo">1503</span> RegionState.State state = regionNode.getState();<a name="line.1503"></a>
-<span class="sourceLineNo">1504</span> ServerName regionLocation = regionNode.getRegionLocation();<a name="line.1504"></a>
-<span class="sourceLineNo">1505</span> regionNode.transitionState(normally ? State.CLOSED : State.ABNORMALLY_CLOSED,<a name="line.1505"></a>
-<span class="sourceLineNo">1506</span> RegionStates.STATES_EXPECTED_ON_CLOSE);<a name="line.1506"></a>
-<span class="sourceLineNo">1507</span> boolean succ = false;<a name="line.1507"></a>
-<span class="sourceLineNo">1508</span> try {<a name="line.1508"></a>
-<span class="sourceLineNo">1509</span> regionStateStore.updateRegionLocation(regionNode);<a name="line.1509"></a>
-<span class="sourceLineNo">1510</span> succ = true;<a name="line.1510"></a>
-<span class="sourceLineNo">1511</span> } finally {<a name="line.1511"></a>
-<span class="sourceLineNo">1512</span> if (!succ) {<a name="line.1512"></a>
-<span class="sourceLineNo">1513</span> // revert<a name="line.1513"></a>
-<span class="sourceLineNo">1514</span> regionNode.setState(state);<a name="line.1514"></a>
-<span class="sourceLineNo">1515</span> regionNode.setRegionLocation(regionLocation);<a name="line.1515"></a>
-<span class="sourceLineNo">1516</span> }<a name="line.1516"></a>
-<span class="sourceLineNo">1517</span> }<a name="line.1517"></a>
-<span class="sourceLineNo">1518</span> if (regionLocation != null) {<a name="line.1518"></a>
-<span class="sourceLineNo">1519</span> regionNode.setLastHost(regionLocation);<a name="line.1519"></a>
-<span class="sourceLineNo">1520</span> regionNode.setRegionLocation(null);<a name="line.1520"></a>
-<span class="sourceLineNo">1521</span> regionStates.removeRegionFromServer(regionLocation, regionNode);<a name="line.1521"></a>
-<span class="sourceLineNo">1522</span> }<a name="line.1522"></a>
-<span class="sourceLineNo">1523</span> }<a name="line.1523"></a>
-<span class="sourceLineNo">1524</span><a name="line.1524"></a>
-<span class="sourceLineNo">1525</span> public void markRegionAsSplit(final RegionInfo parent, final ServerName serverName,<a name="line.1525"></a>
-<span class="sourceLineNo">1526</span> final RegionInfo daughterA, final RegionInfo daughterB) throws IOException {<a name="line.1526"></a>
-<span class="sourceLineNo">1527</span> // Update hbase:meta. Parent will be marked offline and split up in hbase:meta.<a name="line.1527"></a>
-<span class="sourceLineNo">1528</span> // The parent stays in regionStates until cleared when removed by CatalogJanitor.<a name="line.1528"></a>
-<span class="sourceLineNo">1529</span> // Update its state in regionStates to it shows as offline and split when read<a name="line.1529"></a>
-<span class="sourceLineNo">1530</span> // later figuring what regions are in a table and what are not: see<a name="line.1530"></a>
-<span class="sourceLineNo">1531</span> // regionStates#getRegionsOfTable<a name="line.1531"></a>
-<span class="sourceLineNo">1532</span> final RegionStateNode node = regionStates.getOrCreateRegionStateNode(parent);<a name="line.1532"></a>
-<span class="sourceLineNo">1533</span> node.setState(State.SPLIT);<a name="line.1533"></a>
-<span class="sourceLineNo">1534</span> final RegionStateNode nodeA = regionStates.getOrCreateRegionStateNode(daughterA);<a name="line.1534"></a>
-<span class="sourceLineNo">1535</span> nodeA.setState(State.SPLITTING_NEW);<a name="line.1535"></a>
-<span class="sourceLineNo">1536</span> final RegionStateNode nodeB = regionStates.getOrCreateRegionStateNode(daughterB);<a name="line.1536"></a>
-<span class="sourceLineNo">1537</span> nodeB.setState(State.SPLITTING_NEW);<a name="line.1537"></a>
-<span class="sourceLineNo">1538</span><a name="line.1538"></a>
-<span class="sourceLineNo">1539</span> regionStateStore.splitRegion(parent, daughterA, daughterB, serverName);<a name="line.1539"></a>
-<span class="sourceLineNo">1540</span> if (shouldAssignFavoredNodes(parent)) {<a name="line.1540"></a>
-<span class="sourceLineNo">1541</span> List<ServerName> onlineServers = this.master.getServerManager().getOnlineServersList();<a name="line.1541"></a>
-<span class="sourceLineNo">1542</span> ((FavoredNodesPromoter)getBalancer()).<a name="line.1542"></a>
-<span class="sourceLineNo">1543</span> generateFavoredNodesForDaughter(onlineServers, parent, daughterA, daughterB);<a name="line.1543"></a>
-<span class="sourceLineNo">1544</span> }<a name="line.1544"></a>
-<span class="sourceLineNo">1545</span> }<a name="line.1545"></a>
-<span class="sourceLineNo">1546</span><a name="line.1546"></a>
-<span class="sourceLineNo">1547</span> /**<a name="line.1547"></a>
-<span class="sourceLineNo">1548</span> * When called here, the merge has happened. The two merged regions have been<a name="line.1548"></a>
-<span class="sourceLineNo">1549</span> * unassigned and the above markRegionClosed has been called on each so they have been<a name="line.1549"></a>
-<span class="sourceLineNo">1550</span> * disassociated from a hosting Server. The merged region will be open after this call. The<a name="line.1550"></a>
-<span class="sourceLineNo">1551</span> * merged regions are removed from hbase:meta below> Later they are deleted from the filesystem<a name="line.1551"></a>
-<span class="sourceLineNo">1552</span> * by the catalog janitor running against hbase:meta. It notices when the merged region no<a name="line.1552"></a>
-<span class="sourceLineNo">1553</span> * longer holds references to the old regions.<a name="line.1553"></a>
-<span class="sourceLineNo">1554</span> */<a name="line.1554"></a>
-<span class="sourceLineNo">1555</span> public void markRegionAsMerged(final RegionInfo child, final ServerName serverName,<a name="line.1555"></a>
-<span class="sourceLineNo">1556</span> final RegionInfo mother, final RegionInfo father) throws IOException {<a name="line.1556"></a>
-<span class="sourceLineNo">1557</span> final RegionStateNode node = regionStates.getOrCreateRegionStateNode(child);<a name="line.1557"></a>
-<span class="sourceLineNo">1558</span> node.setState(State.MERGED);<a name="line.1558"></a>
-<span class="sourceLineNo">1559</span> regionStates.deleteRegion(mother);<a name="line.1559"></a>
-<span class="sourceLineNo">1560</span> regionStates.deleteRegion(father);<a name="line.1560"></a>
-<span class="sourceLineNo">1561</span> regionStateStore.mergeRegions(child, mother, father, serverName);<a name="line.1561"></a>
-<span class="sourceLineNo">1562</span> if (shouldAssignFavoredNodes(child)) {<a name="line.1562"></a>
-<span class="sourceLineNo">1563</span> ((FavoredNodesPromoter)getBalancer()).<a name="line.1563"></a>
-<span class="sourceLineNo">1564</span> generateFavoredNodesForMergedRegion(child, mother, father);<a name="line.1564"></a>
-<span class="sourceLineNo">1565</span> }<a name="line.1565"></a>
-<span class="sourceLineNo">1566</span> }<a name="line.1566"></a>
-<span class="sourceLineNo">1567</span><a name="line.1567"></a>
-<span class="sourceLineNo">1568</span> /*<a name="line.1568"></a>
-<span class="sourceLineNo">1569</span> * Favored nodes should be applied only when FavoredNodes balancer is configured and the region<a name="line.1569"></a>
-<span class="sourceLineNo">1570</span> * belongs to a non-system table.<a name="line.1570"></a>
-<span class="sourceLineNo">1571</span> */<a name="line.1571"></a>
-<span class="sourceLineNo">1572</span> private boolean shouldAssignFavoredNodes(RegionInfo region) {<a name="line.1572"></a>
-<span class="sourceLineNo">1573</span> return this.shouldAssignRegionsWithFavoredNodes &&<a name="line.1573"></a>
-<span class="sourceLineNo">1574</span> FavoredNodesManager.isFavoredNodeApplicable(region);<a name="line.1574"></a>
-<span class="sourceLineNo">1575</span> }<a name="line.1575"></a>
-<span class="sourceLineNo">1576</span><a name="line.1576"></a>
-<span class="sourceLineNo">1577</span> // ============================================================================================<a name="line.1577"></a>
-<span class="sourceLineNo">1578</span> // Assign Queue (Assign/Balance)<a name="line.1578"></a>
-<span class="sourceLineNo">1579</span> // ============================================================================================<a name="line.1579"></a>
-<span class="sourceLineNo">1580</span> private final ArrayList<RegionStateNode> pendingAssignQueue = new ArrayList<RegionStateNode>();<a name="line.1580"></a>
-<span class="sourceLineNo">1581</span> private final ReentrantLock assignQueueLock = new ReentrantLock();<a name="line.1581"></a>
-<span class="sourceLineNo">1582</span> private final Condition assignQueueFullCond = assignQueueLock.newCondition();<a name="line.1582"></a>
-<span class="sourceLineNo">1583</span><a name="line.1583"></a>
-<span class="sourceLineNo">1584</span> /**<a name="line.1584"></a>
-<span class="sourceLineNo">1585</span> * Add the assign operation to the assignment queue.<a name="line.1585"></a>
-<span class="sourceLineNo">1586</span> * The pending assignment operation will be processed,<a name="line.1586"></a>
-<span class="sourceLineNo">1587</span> * and each region will be assigned by a server using the balancer.<a name="line.1587"></a>
-<span class="sourceLineNo">1588</span> */<a name="line.1588"></a>
-<span class="sourceLineNo">1589</span> protected void queueAssign(final RegionStateNode regionNode) {<a name="line.1589"></a>
-<span class="sourceLineNo">1590</span> regionNode.getProcedureEvent().suspend();<a name="line.1590"></a>
-<span class="sourceLineNo">1591</span><a name="line.1591"></a>
-<span class="sourceLineNo">1592</span> // TODO: quick-start for meta and the other sys-tables?<a name="line.1592"></a>
-<span class="sourceLineNo">1593</span> assignQueueLock.lock();<a name="line.1593"></a>
-<span class="sourceLineNo">1594</span> try {<a name="line.1594"></a>
-<span class="sourceLineNo">1595</span> pendingAssignQueue.add(regionNode);<a name="line.1595"></a>
-<span class="sourceLineNo">1596</span> if (regionNode.isSystemTable() ||<a name="line.1596"></a>
-<span class="sourceLineNo">1597</span> pendingAssignQueue.size() == 1 ||<a name="line.1597"></a>
-<span class="sourceLineNo">1598</span> pendingAssignQueue.size() >= assignDispatchWaitQueueMaxSize) {<a name="line.1598"></a>
-<span class="sourceLineNo">1599</span> assignQueueFullCond.signal();<a name="line.1599"></a>
-<span class="sourceLineNo">1600</span> }<a name="line.1600"></a>
-<span class="sourceLineNo">1601</span> } finally {<a name="line.1601"></a>
-<span class="sourceLineNo">1602</span> assignQueueLock.unlock();<a name="line.1602"></a>
-<span class="sourceLineNo">1603</span> }<a name="line.1603"></a>
-<span class="sourceLineNo">1604</span> }<a name="line.1604"></a>
-<span class="sourceLineNo">1605</span><a name="line.1605"></a>
-<span class="sourceLineNo">1606</span> private void startAssignmentThread() {<a name="line.1606"></a>
-<span class="sourceLineNo">1607</span> // Get Server Thread name. Sometimes the Server is mocked so may not implement HasThread.<a name="line.1607"></a>
-<span class="sourceLineNo">1608</span> // For example, in tests.<a name="line.1608"></a>
-<span class="sourceLineNo">1609</span> String name = master instanceof HasThread? ((HasThread)master).getName():<a name="line.1609"></a>
-<span class="sourceLineNo">1610</span> master.getServerName().toShortString();<a name="line.1610"></a>
-<span class="sourceLineNo">1611</span> assignThread = new Thread(name) {<a name="line.1611"></a>
-<span class="sourceLineNo">1612</span> @Override<a name="line.1612"></a>
-<span class="sourceLineNo">1613</span> public void run() {<a name="line.1613"></a>
-<span class="sourceLineNo">1614</span> while (isRunning()) {<a name="line.1614"></a>
-<span class="sourceLineNo">1615</span> processAssignQueue();<a name="line.1615"></a>
-<span class="sourceLineNo">1616</span> }<a name="line.1616"></a>
-<span class="sourceLineNo">1617</span> pendingAssignQueue.clear();<a name="line.1617"></a>
-<span class="sourceLineNo">1618</span> }<a name="line.1618"></a>
-<span class="sourceLineNo">1619</span> };<a name="line.1619"></a>
-<span class="sourceLineNo">1620</span> assignThread.setDaemon(true);<a name="line.1620"></a>
-<span class="sourceLineNo">1621</span> assignThread.start();<a name="line.1621"></a>
-<span class="sourceLineNo">1622</span> }<a name="line.1622"></a>
-<span class="sourceLineNo">1623</span><a name="line.1623"></a>
-<span class="sourceLineNo">1624</span> private void stopAssignmentThread() {<a name="line.1624"></a>
-<span class="sourceLineNo">1625</span> assignQueueSignal();<a name="line.1625"></a>
-<span class="sourceLineNo">1626</span> try {<a name="line.1626"></a>
-<span class="sourceLineNo">1627</span> while (assignThread.isAlive()) {<a name="line.1627"></a>
-<span class="sourceLineNo">1628</span> assignQueueSignal();<a name="line.1628"></a>
-<span class="sourceLineNo">1629</span> assignThread.join(250);<a name="line.1629"></a>
-<span class="sourceLineNo">1630</span> }<a name="line.1630"></a>
-<span class="sourceLineNo">1631</span> } catch (InterruptedException e) {<a name="line.1631"></a>
-<span class="sourceLineNo">1632</span> LOG.warn("join interrupted", e);<a name="line.1632"></a>
-<span class="sourceLineNo">1633</span> Thread.currentThread().interrupt();<a name="line.1633"></a>
-<span class="sourceLineNo">1634</span> }<a name="line.1634"></a>
-<span class="sourceLineNo">1635</span> }<a name="line.1635"></a>
-<span class="sourceLineNo">1636</span><a name="line.1636"></a>
-<span class="sourceLineNo">1637</span> private void assignQueueSignal() {<a name="line.1637"></a>
-<span class="sourceLineNo">1638</span> assignQueueLock.lock();<a name="line.1638"></a>
-<span class="sourceLineNo">1639</span> try {<a name="line.1639"></a>
-<span class="sourceLineNo">1640</span> assignQueueFullCond.signal();<a name="line.1640"></a>
-<span class="sourceLineNo">1641</span> } finally {<a name="line.1641"></a>
-<span class="sourceLineNo">1642</span> assignQueueLock.unlock();<a name="line.1642"></a>
-<span class="sourceLineNo">1643</span> }<a name="line.1643"></a>
-<span class="sourceLineNo">1644</span> }<a name="line.1644"></a>
-<span class="sourceLineNo">1645</span><a name="line.1645"></a>
-<span class="sourceLineNo">1646</span> @edu.umd.cs.findbugs.annotations.SuppressWarnings("WA_AWAIT_NOT_IN_LOOP")<a name="line.1646"></a>
-<span class="sourceLineNo">1647</span> private HashMap<RegionInfo, RegionStateNode> waitOnAssignQueue() {<a name="line.1647"></a>
-<span class="sourceLineNo">1648</span> HashMap<RegionInfo, RegionStateNode> regions = null;<a name="line.1648"></a>
-<span class="sourceLineNo">1649</span><a name="line.1649"></a>
-<span class="sourceLineNo">1650</span> assignQueueLock.lock();<a name="line.1650"></a>
-<span class="sourceLineNo">1651</span> try {<a name="line.1651"></a>
-<span class="sourceLineNo">1652</span> if (pendingAssignQueue.isEmpty() && isRunning()) {<a name="line.1652"></a>
-<span class="sourceLineNo">1653</span> assignQueueFullCond.await();<a name="line.1653"></a>
-<span class="sourceLineNo">1654</span> }<a name="line.1654"></a>
-<span class="sourceLineNo">1655</span><a name="line.1655"></a>
-<span class="sourceLineNo">1656</span> if (!isRunning()) return null;<a name="line.1656"></a>
-<span class="sourceLineNo">1657</span> assignQueueFullCond.await(assignDispatchWaitMillis, TimeUnit.MILLISECONDS);<a name="line.1657"></a>
-<span class="sourceLineNo">1658</span> regions = new HashMap<RegionInfo, RegionStateNode>(pendingAssignQueue.size());<a name="line.1658"></a>
-<span class="sourceLineNo">1659</span> for (RegionStateNode regionNode: pendingAssignQueue) {<a name="line.1659"></a>
-<span class="sourceLineNo">1660</span> regions.put(regionNode.getRegionInfo(), regionNode);<a name="line.1660"></a>
-<span class="sourceLineNo">1661</span> }<a name="line.1661"></a>
-<span class="sourceLineNo">1662</span> pendingAssignQueue.clear();<a name="line.1662"></a>
-<span class="sourceLineNo">1663</span> } catch (InterruptedException e) {<a name="line.1663"></a>
-<span class="sourceLineNo">1664</span> LOG.warn("got interrupted ", e);<a name="line.1664"></a>
-<span class="sourceLineNo">1665</span> Thread.currentThread().interrupt();<a name="line.1665"></a>
-<span class="sourceLineNo">1666</span> } finally {<a name="line.1666"></a>
-<span class="sourceLineNo">1667</span> assignQueueLock.unlock();<a name="line.1667"></a>
-<span class="sourceLineNo">1668</span> }<a name="line.1668"></a>
-<span class="sourceLineNo">1669</span> return regions;<a name="line.1669"></a>
+<span class="sourceLineNo">1500</span> void regionOpened(RegionStateNode regionNode) throws IOException {<a name="line.1500"></a>
+<span class="sourceLineNo">1501</span> // TODO: OPENING Updates hbase:meta too... we need to do both here and there?<a name="line.1501"></a>
+<span class="sourceLineNo">1502</span> // That is a lot of hbase:meta writing.<a name="line.1502"></a>
+<span class="sourceLineNo">1503</span> transitStateAndUpdate(regionNode, State.OPEN, STATES_EXPECTED_ON_OPEN);<a name="line.1503"></a>
+<span class="sourceLineNo">1504</span> RegionInfo hri = regionNode.getRegionInfo();<a name="line.1504"></a>
+<span class="sourceLineNo">1505</span> if (isMetaRegion(hri)) {<a name="line.1505"></a>
+<span class="sourceLineNo">1506</span> // Usually we'd set a table ENABLED at this stage but hbase:meta is ALWAYs enabled, it<a name="line.1506"></a>
+<span class="sourceLineNo">1507</span> // can't be disabled -- so skip the RPC (besides... enabled is managed by TableStateManager<a name="line.1507"></a>
+<span class="sourceLineNo">1508</span> // which is backed by hbase:meta... Avoid setting ENABLED to avoid having to update state<a name="line.1508"></a>
+<span class="sourceLineNo">1509</span> // on table that contains state.<a name="line.1509"></a>
+<span class="sourceLineNo">1510</span> setMetaAssigned(hri, true);<a name="line.1510"></a>
+<span class="sourceLineNo">1511</span> }<a name="line.1511"></a>
+<span class="sourceLineNo">1512</span> regionStates.addRegionToServer(regionNode);<a name="line.1512"></a>
+<span class="sourceLineNo">1513</span> regionStates.removeFromFailedOpen(hri);<a name="line.1513"></a>
+<span class="sourceLineNo">1514</span> }<a name="line.1514"></a>
+<span class="sourceLineNo">1515</span><a name="line.1515"></a>
+<span class="sourceLineNo">1516</span> // should be called within the synchronized block of RegionStateNode<a name="line.1516"></a>
+<span class="sourceLineNo">1517</span> void regionClosing(RegionStateNode regionNode) throws IOException {<a name="line.1517"></a>
+<span class="sourceLineNo">1518</span> transitStateAndUpdate(regionNode, State.CLOSING, STATES_EXPECTED_ON_CLOSING);<a name="line.1518"></a>
+<span class="sourceLineNo">1519</span><a name="line.1519"></a>
+<span class="sourceLineNo">1520</span> RegionInfo hri = regionNode.getRegionInfo();<a name="line.1520"></a>
+<span class="sourceLineNo">1521</span> // Set meta has not initialized early. so people trying to create/edit tables will wait<a name="line.1521"></a>
+<span class="sourceLineNo">1522</span> if (isMetaRegion(hri)) {<a name="line.1522"></a>
+<span class="sourceLineNo">1523</span> setMetaAssigned(hri, false);<a name="line.1523"></a>
+<span class="sourceLineNo">1524</span> }<a name="line.1524"></a>
+<span class="sourceLineNo">1525</span> regionStates.addRegionToServer(regionNode);<a name="line.1525"></a>
+<span class="sourceLineNo">1526</span> // update the operation count metrics<a name="line.1526"></a>
+<span class="sourceLineNo">1527</span> metrics.incrementOperationCounter();<a name="line.1527"></a>
+<span class="sourceLineNo">1528</span> }<a name="line.1528"></a>
+<span class="sourceLineNo">1529</span><a name="line.1529"></a>
+<span class="sourceLineNo">1530</span> // should be called within the synchronized block of RegionStateNode<a name="line.1530"></a>
+<span class="sourceLineNo">1531</span> // The parameter 'normally' means whether we are closed cleanly, if it is true, then it means that<a name="line.1531"></a>
+<span class="sourceLineNo">1532</span> // we are closed due to a RS crash.<a name="line.1532"></a>
+<span class="sourceLineNo">1533</span> void regionClosed(RegionStateNode regionNode, boolean normally) throws IOException {<a name="line.1533"></a>
+<span class="sourceLineNo">1534</span> RegionState.State state = regionNode.getState();<a name="line.1534"></a>
+<span class="sourceLineNo">1535</span> ServerName regionLocation = regionNode.getRegionLocation();<a name="line.1535"></a>
+<span class="sourceLineNo">1536</span> if (normally) {<a name="line.1536"></a>
+<span class="sourceLineNo">1537</span> regionNode.transitionState(State.CLOSED, STATES_EXPECTED_ON_CLOSED);<a name="line.1537"></a>
+<span class="sourceLineNo">1538</span> } else {<a name="line.1538"></a>
+<span class="sourceLineNo">1539</span> // For SCP<a name="line.1539"></a>
+<span class="sourceLineNo">1540</span> regionNode.transitionState(State.ABNORMALLY_CLOSED);<a name="line.1540"></a>
+<span class="sourceLineNo">1541</span> }<a name="line.1541"></a>
+<span class="sourceLineNo">1542</span> regionNode.setRegionLocation(null);<a name="line.1542"></a>
+<span class="sourceLineNo">1543</span> boolean succ = false;<a name="line.1543"></a>
+<span class="sourceLineNo">1544</span> try {<a name="line.1544"></a>
+<span class="sourceLineNo">1545</span> regionStateStore.updateRegionLocation(regionNode);<a name="line.1545"></a>
+<span class="sourceLineNo">1546</span> succ = true;<a name="line.1546"></a>
+<span class="sourceLineNo">1547</span> } finally {<a name="line.1547"></a>
+<span class="sourceLineNo">1548</span> if (!succ) {<a name="line.1548"></a>
+<span class="sourceLineNo">1549</span> // revert<a name="line.1549"></a>
+<span class="sourceLineNo">1550</span> regionNode.setState(state);<a name="line.1550"></a>
+<span class="sourceLineNo">1551</span> regionNode.setRegionLocation(regionLocation);<a name="line.1551"></a>
+<span class="sourceLineNo">1552</span> }<a name="line.1552"></a>
+<span class="sourceLineNo">1553</span> }<a name="line.1553"></a>
+<span class="sourceLineNo">1554</span> if (regionLocation != null) {<a name="line.1554"></a>
+<span class="sourceLineNo">1555</span> regionNode.setLastHost(regionLocation);<a name="line.1555"></a>
+<span class="sourceLineNo">1556</span> regionStates.removeRegionFromServer(regionLocation, regionNode);<a name="line.1556"></a>
+<span class="sourceLineNo">1557</span> }<a name="line.1557"></a>
+<span class="sourceLineNo">1558</span> }<a name="line.1558"></a>
+<span class="sourceLineNo">1559</span><a name="line.1559"></a>
+<span class="sourceLineNo">1560</span> public void markRegionAsSplit(final RegionInfo parent, final ServerName serverName,<a name="line.1560"></a>
+<span class="sourceLineNo">1561</span> final RegionInfo daughterA, final RegionInfo daughterB) throws IOException {<a name="line.1561"></a>
+<span class="sourceLineNo">1562</span> // Update hbase:meta. Parent will be marked offline and split up in hbase:meta.<a name="line.1562"></a>
+<span class="sourceLineNo">1563</span> // The parent stays in regionStates until cleared when removed by CatalogJanitor.<a name="line.1563"></a>
+<span class="sourceLineNo">1564</span> // Update its state in regionStates to it shows as offline and split when read<a name="line.1564"></a>
+<span class="sourceLineNo">1565</span> // later figuring what regions are in a table and what are not: see<a name="line.1565"></a>
+<span class="sourceLineNo">1566</span> // regionStates#getRegionsOfTable<a name="line.1566"></a>
+<span class="sourceLineNo">1567</span> final RegionStateNode node = regionStates.getOrCreateRegionStateNode(parent);<a name="line.1567"></a>
+<span class="sourceLineNo">1568</span> node.setState(State.SPLIT);<a name="line.1568"></a>
+<span class="sourceLineNo">1569</span> final RegionStateNode nodeA = regionStates.getOrCreateRegionStateNode(daughterA);<a name="line.1569"></a>
+<span class="sourceLineNo">1570</span> nodeA.setState(State.SPLITTING_NEW);<a name="line.1570"></a>
+<span class="sourceLineNo">1571</span> final RegionStateNode nodeB = regionStates.getOrCreateRegionStateNode(daughterB);<a name="line.1571"></a>
+<span class="sourceLineNo">1572</span> nodeB.setState(State.SPLITTING_NEW);<a name="line.1572"></a>
+<span class="sourceLineNo">1573</span><a name="line.1573"></a>
+<span class="sourceLineNo">1574</span> regionStateStore.splitRegion(parent, daughterA, daughterB, serverName);<a name="line.1574"></a>
+<span class="sourceLineNo">1575</span> if (shouldAssignFavoredNodes(parent)) {<a name="line.1575"></a>
+<span class="sourceLineNo">1576</span> List<ServerName> onlineServers = this.master.getServerManager().getOnlineServersList();<a name="line.1576"></a>
+<span class="sourceLineNo">1577</span> ((FavoredNodesPromoter)getBalancer()).<a name="line.1577"></a>
+<span class="sourceLineNo">1578</span> generateFavoredNodesForDaughter(onlineServers, parent, daughterA, daughterB);<a name="line.1578"></a>
+<span class="sourceLineNo">1579</span> }<a name="line.1579"></a>
+<span class="sourceLineNo">1580</span> }<a name="line.1580"></a>
+<span class="sourceLineNo">1581</span><a name="line.1581"></a>
+<span class="sourceLineNo">1582</span> /**<a name="line.1582"></a>
+<span class="sourceLineNo">1583</span> * When called here, the merge has happened. The two merged regions have been<a name="line.1583"></a>
+<span class="sourceLineNo">1584</span> * unassigned and the above markRegionClosed has been called on each so they have been<a name="line.1584"></a>
+<span class="sourceLineNo">1585</span> * disassociated from a hosting Server. The merged region will be open after this call. The<a name="line.1585"></a>
+<span class="sourceLineNo">1586</span> * merged regions are removed from hbase:meta below> Later they are deleted from the filesystem<a name="line.1586"></a>
+<span class="sourceLineNo">1587</span> * by the catalog janitor running against hbase:meta. It notices when the merged region no<a name="line.1587"></a>
+<span class="sourceLineNo">1588</span> * longer holds references to the old regions.<a name="line.1588"></a>
+<span class="sourceLineNo">1589</span> */<a name="line.1589"></a>
+<span class="sourceLineNo">1590</span> public void markRegionAsMerged(final RegionInfo child, final ServerName serverName,<a name="line.1590"></a>
+<span class="sourceLineNo">1591</span> final RegionInfo mother, final RegionInfo father) throws IOException {<a name="line.1591"></a>
+<span class="sourceLineNo">1592</span> final RegionStateNode node = regionStates.getOrCreateRegionStateNode(child);<a name="line.1592"></a>
+<span class="sourceLineNo">1593</span> node.setState(State.MERGED);<a name="line.1593"></a>
+<span class="sourceLineNo">1594</span> regionStates.deleteRegion(mother);<a name="line.1594"></a>
+<span class="sourceLineNo">1595</span> regionStates.deleteRegion(father);<a name="line.1595"></a>
+<span class="sourceLineNo">1596</span> regionStateStore.mergeRegions(child, mother, father, serverName);<a name="line.1596"></a>
+<span class="sourceLineNo">1597</span> if (shouldAssignFavoredNodes(child)) {<a name="line.1597"></a>
+<span class="sourceLineNo">1598</span> ((FavoredNodesPromoter)getBalancer()).<a name="line.1598"></a>
+<span class="sourceLineNo">1599</span> generateFavoredNodesForMergedRegion(child, mother, father);<a name="line.1599"></a>
+<span class="sourceLineNo">1600</span> }<a name="line.1600"></a>
+<span class="sourceLineNo">1601</span> }<a name="line.1601"></a>
+<span class="sourceLineNo">1602</span><a name="line.1602"></a>
+<span class="sourceLineNo">1603</span> /*<a name="line.1603"></a>
+<span class="sourceLineNo">1604</span> * Favored nodes should be applied only when FavoredNodes balancer is configured and the region<a name="line.1604"></a>
+<span class="sourceLineNo">1605</span> * belongs to a non-system table.<a name="line.1605"></a>
+<span class="sourceLineNo">1606</span> */<a name="line.1606"></a>
+<span class="sourceLineNo">1607</span> private boolean shouldAssignFavoredNodes(RegionInfo region) {<a name="line.1607"></a>
+<span class="sourceLineNo">1608</span> return this.shouldAssignRegionsWithFavoredNodes &&<a name="line.1608"></a>
+<span class="sourceLineNo">1609</span> FavoredNodesManager.isFavoredNodeApplicable(region);<a name="line.1609"></a>
+<span class="sourceLineNo">1610</span> }<a name="line.1610"></a>
+<span class="sourceLineNo">1611</span><a name="line.1611"></a>
+<span class="sourceLineNo">1612</span> // ============================================================================================<a name="line.1612"></a>
+<span class="sourceLineNo">1613</span> // Assign Queue (Assign/Balance)<a name="line.1613"></a>
+<span class="sourceLineNo">1614</span> // ============================================================================================<a name="line.1614"></a>
+<span class="sourceLineNo">1615</span> private final ArrayList<RegionStateNode> pendingAssignQueue = new ArrayList<RegionStateNode>();<a name="line.1615"></a>
+<span class="sourceLineNo">1616</span> private final ReentrantLock assignQueueLock = new ReentrantLock();<a name="line.1616"></a>
+<span class="sourceLineNo">1617</span> private final Condition assignQueueFullCond = assignQueueLock.newCondition();<a name="line.1617"></a>
+<span class="sourceLineNo">1618</span><a name="line.1618"></a>
+<span class="sourceLineNo">1619</span> /**<a name="line.1619"></a>
+<span class="sourceLineNo">1620</span> * Add the assign operation to the assignment queue.<a name="line.1620"></a>
+<span class="sourceLineNo">1621</span> * The pending assignment operation will be processed,<a name="line.1621"></a>
+<span class="sourceLineNo">1622</span> * and each region will be assigned by a server using the balancer.<a name="line.1622"></a>
+<span class="sourceLineNo">1623</span> */<a name="line.1623"></a>
+<span class="sourceLineNo">1624</span> protected void queueAssign(final RegionStateNode regionNode) {<a name="line.1624"></a>
+<span class="sourceLineNo">1625</span> regionNode.getProcedureEvent().suspend();<a name="line.1625"></a>
+<span class="sourceLineNo">1626</span><a name="line.1626"></a>
+<span class="sourceLineNo">1627</span> // TODO: quick-start for meta and the other sys-tables?<a name="line.1627"></a>
+<span class="sourceLineNo">1628</span> assignQueueLock.lock();<a name="line.1628"></a>
+<span class="sourceLineNo">1629</span> try {<a name="line.1629"></a>
+<span class="sourceLineNo">1630</span> pendingAssignQueue.add(regionNode);<a name="line.1630"></a>
+<span class="sourceLineNo">1631</span> if (regionNode.isSystemTable() ||<a name="line.1631"></a>
+<span class="sourceLineNo">1632</span> pendingAssignQueue.size() == 1 ||<a name="line.1632"></a>
+<span class="sourceLineNo">1633</span> pendingAssignQueue.size() >= assignDispatchWaitQueueMaxSize) {<a name="line.1633"></a>
+<span class="sourceLineNo">1634</span> assignQueueFullCond.signal();<a name="line.1634"></a>
+<span class="sourceLineNo">1635</span> }<a name="line.1635"></a>
+<span class="sourceLineNo">1636</span> } finally {<a name="line.1636"></a>
+<span class="sourceLineNo">1637</span> assignQueueLock.unlock();<a name="line.1637"></a>
+<span class="sourceLineNo">1638</span> }<a name="line.1638"></a>
+<span class="sourceLineNo">1639</span> }<a name="line.1639"></a>
+<span class="sourceLineNo">1640</span><a name="line.1640"></a>
+<span class="sourceLineNo">1641</span> private void startAssignmentThread() {<a name="line.1641"></a>
+<span class="sourceLineNo">1642</span> // Get Server Thread name. Sometimes the Server is mocked so may not implement HasThread.<a name="line.1642"></a>
+<span class="sourceLineNo">1643</span> // For example, in tests.<a name="line.1643"></a>
+<span class="sourceLineNo">1644</span> String name = master instanceof HasThread? ((HasThread)master).getName():<a name="line.1644"></a>
+<span class="sourceLineNo">1645</span> master.getServerName().toShortString();<a name="line.1645"></a>
+<span class="sourceLineNo">1646</span> assignThread = new Thread(name) {<a name="line.1646"></a>
+<span class="sourceLineNo">1647</span> @Override<a name="line.1647"></a>
+<span class="sourceLineNo">1648</span> public void run() {<a name="line.1648"></a>
+<span class="sourceLineNo">1649</span> while (isRunning()) {<a name="line.1649"></a>
+<span class="sourceLineNo">1650</span> processAssignQueue();<a name="line.1650"></a>
+<span class="sourceLineNo">1651</span> }<a name="line.1651"></a>
+<span class="sourceLineNo">1652</span> pendingAssignQueue.clear();<a name="line.1652"></a>
+<span class="sourceLineNo">1653</span> }<a name="line.1653"></a>
+<span class="sourceLineNo">1654</span> };<a name="line.1654"></a>
+<span class="sourceLineNo">1655</span> assignThread.setDaemon(true);<a name="line.1655"></a>
+<span class="sourceLineNo">1656</span> assignThread.start();<a name="line.1656"></a>
+<span class="sourceLineNo">1657</span> }<a name="line.1657"></a>
+<span class="sourceLineNo">1658</span><a name="line.1658"></a>
+<span class="sourceLineNo">1659</span> private void stopAssignmentThread() {<a name="line.1659"></a>
+<span class="sourceLineNo">1660</span> assignQueueSignal();<a name="line.1660"></a>
+<span class="sourceLineNo">1661</span> try {<a name="line.1661"></a>
+<span class="sourceLineNo">1662</span> while (assignThread.isAlive()) {<a name="line.1662"></a>
+<span class="sourceLineNo">1663</span> assignQueueSignal();<a name="line.1663"></a>
+<span class="sourceLineNo">1664</span> assignThread.join(250);<a name="line.1664"></a>
+<span class="sourceLineNo">1665</span> }<a name="line.1665"></a>
+<span class="sourceLineNo">1666</span> } catch (InterruptedException e) {<a name="line.1666"></a>
+<span class="sourceLineNo">1667</span> LOG.warn("join interrupted", e);<a name="line.1667"></a>
+<span class="sourceLineNo">1668</span> Thread.currentThread().interrupt();<a name="line.1668"></a>
+<span class="sourceLineNo">1669</span> }<a name="line.1669"></a>
<span class="sourceLineNo">1670</span> }<a name="line.1670"></a>
<span class="sourceLineNo">1671</span><a name="line.1671"></a>
-<span class="sourceLineNo">1672</span> private void processAssignQueue() {<a name="line.1672"></a>
-<span class="sourceLineNo">1673</span> final HashMap<RegionInfo, RegionStateNode> regions = waitOnAssignQueue();<a name="line.1673"></a>
-<span class="sourceLineNo">1674</span> if (regions == null || regions.size() == 0 || !isRunning()) {<a name="line.1674"></a>
-<span class="sourceLineNo">1675</span> return;<a name="line.1675"></a>
-<span class="sourceLineNo">1676</span> }<a name="line.1676"></a>
-<span class="sourceLineNo">1677</span><a name="line.1677"></a>
-<span class="sourceLineNo">1678</span> if (LOG.isTraceEnabled()) {<a name="line.1678"></a>
-<span class="sourceLineNo">1679</span> LOG.trace("PROCESS ASSIGN QUEUE regionCount=" + regions.size());<a name="line.1679"></a>
-<span class="sourceLineNo">1680</span> }<a name="line.1680"></a>
-<span class="sourceLineNo">1681</span><a name="line.1681"></a>
-<span class="sourceLineNo">1682</span> // TODO: Optimize balancer. pass a RegionPlan?<a name="line.1682"></a>
-<span class="sourceLineNo">1683</span> final HashMap<RegionInfo, ServerName> retainMap = new HashMap<>();<a name="line.1683"></a>
-<span class="sourceLineNo">1684</span> final List<RegionInfo> userHRIs = new ArrayList<>(regions.size());<a name="line.1684"></a>
-<span class="sourceLineNo">1685</span> // Regions for system tables requiring reassignment<a name="line.1685"></a>
-<span class="sourceLineNo">1686</span> final List<RegionInfo> systemHRIs = new ArrayList<>();<a name="line.1686"></a>
-<span class="sourceLineNo">1687</span> for (RegionStateNode regionStateNode: regions.values()) {<a name="line.1687"></a>
-<span class="sourceLineNo">1688</span> boolean sysTable = regionStateNode.isSystemTable();<a name="line.1688"></a>
-<span class="sourceLineNo">1689</span> final List<RegionInfo> hris = sysTable? systemHRIs: userHRIs;<a name="line.1689"></a>
-<span class="sourceLineNo">1690</span> if (regionStateNode.getRegionLocation() != null) {<a name="line.1690"></a>
-<span class="sourceLineNo">1691</span> retainMap.put(regionStateNode.getRegionInfo(), regionStateNode.getRegionLocation());<a name="line.1691"></a>
-<span class="sourceLineNo">1692</span> } else {<a name="line.1692"></a>
-<span class="sourceLineNo">1693</span> hris.add(regionStateNode.getRegionInfo());<a name="line.1693"></a>
-<span class="sourceLineNo">1694</span> }<a name="line.1694"></a>
-<span class="sourceLineNo">1695</span> }<a name="line.1695"></a>
-<span class="sourceLineNo">1696</span><a name="line.1696"></a>
-<span class="sourceLineNo">1697</span> // TODO: connect with the listener to invalidate the cache<a name="line.1697"></a>
-<span class="sourceLineNo">1698</span><a name="line.1698"></a>
-<span class="sourceLineNo">1699</span> // TODO use events<a name="line.1699"></a>
-<span class="sourceLineNo">1700</span> List<ServerName> servers = master.getServerManager().createDestinationServersList();<a name="line.1700"></a>
-<span class="sourceLineNo">1701</span> for (int i = 0; servers.size() < 1; ++i) {<a name="line.1701"></a>
-<span class="sourceLineNo">1702</span> // Report every fourth time around this loop; try not to flood log.<a name="line.1702"></a>
-<span class="sourceLineNo">1703</span> if (i % 4 == 0) {<a name="line.1703"></a>
-<span class="sourceLineNo">1704</span> LOG.warn("No servers available; cannot place " + regions.size() + " unassigned regions.");<a name="line.1704"></a>
-<span class="sourceLineNo">1705</span> }<a name="line.1705"></a>
+<span class="sourceLineNo">1672</span> private void assignQueueSignal() {<a name="line.1672"></a>
+<span class="sourceLineNo">1673</span> assignQueueLock.lock();<a name="line.1673"></a>
+<span class="sourceLineNo">1674</span> try {<a name="line.1674"></a>
+<span class="sourceLineNo">1675</span> assignQueueFullCond.signal();<a name="line.1675"></a>
+<span class="sourceLineNo">1676</span> } finally {<a name="line.1676"></a>
+<span class="sourceLineNo">1677</span> assignQueueLock.unlock();<a name="line.1677"></a>
+<span class="sourceLineNo">1678</span> }<a name="line.1678"></a>
+<span class="sourceLineNo">1679</span> }<a name="line.1679"></a>
+<span class="sourceLineNo">1680</span><a name="line.1680"></a>
+<span class="sourceLineNo">1681</span> @edu.umd.cs.findbugs.annotations.SuppressWarnings("WA_AWAIT_NOT_IN_LOOP")<a name="line.1681"></a>
+<span class="sourceLineNo">1682</span> private HashMap<RegionInfo, RegionStateNode> waitOnAssignQueue() {<a name="line.1682"></a>
+<span class="sourceLineNo">1683</span> HashMap<RegionInfo, RegionStateNode> regions = null;<a name="line.1683"></a>
+<span class="sourceLineNo">1684</span><a name="line.1684"></a>
+<span class="sourceLineNo">1685</span> assignQueueLock.lock();<a name="line.1685"></a>
+<span class="sourceLineNo">1686</span> try {<a name="line.1686"></a>
+<span class="sourceLineNo">1687</span> if (pendingAssignQueue.isEmpty() && isRunning()) {<a name="line.1687"></a>
+<span class="sourceLineNo">1688</span> assignQueueFullCond.await();<a name="line.1688"></a>
+<span class="sourceLineNo">1689</span> }<a name="line.1689"></a>
+<span class="sourceLineNo">1690</span><a name="line.1690"></a>
+<span class="sourceLineNo">1691</span> if (!isRunning()) return null;<a name="line.1691"></a>
+<span class="sourceLineNo">1692</span> assignQueueFullCond.await(assignDispatchWaitMillis, TimeUnit.MILLISECONDS);<a name="line.1692"></a>
+<span class="sourceLineNo">1693</span> regions = new HashMap<RegionInfo, RegionStateNode>(pendingAssignQueue.size());<a name="line.1693"></a>
+<span class="sourceLineNo">1694</span> for (RegionStateNode regionNode: pendingAssignQueue) {<a name="line.1694"></a>
+<span class="sourceLineNo">1695</span> regions.put(regionNode.getRegionInfo(), regionNode);<a name="line.1695"></a>
+<span class="sourceLineNo">1696</span> }<a name="line.1696"></a>
+<span class="sourceLineNo">1697</span> pendingAssignQueue.clear();<a name="line.1697"></a>
+<span class="sourceLineNo">1698</span> } catch (InterruptedException e) {<a name="line.1698"></a>
+<span class="sourceLineNo">1699</span> LOG.warn("got interrupted ", e);<a name="line.1699"></a>
+<span class="sourceLineNo">1700</span> Thread.currentThread().interrupt();<a name="line.1700"></a>
+<span class="sourceLineNo">1701</span> } finally {<a name="line.1701"></a>
+<span class="sourceLineNo">1702</span> assignQueueLock.unlock();<a name="line.1702"></a>
+<span class="sourceLineNo">1703</span> }<a name="line.1703"></a>
+<span class="sourceLineNo">1704</span> return regions;<a name="line.1704"></a>
+<span class="sourceLineNo">1705</span> }<a name="line.1705"></a>
<span class="sourceLineNo">1706</span><a name="line.1706"></a>
-<span class="sourceLineNo">1707</span> if (!isRunning()) {<a name="line.1707"></a>
-<span class="sourceLineNo">1708</span> LOG.debug("Stopped! Dropping assign of " + regions.size() + " queued regions.");<a name="line.1708"></a>
-<span class="sourceLineNo">1709</span> return;<a name="line.1709"></a>
-<span class="sourceLineNo">1710</span> }<a name="line.1710"></a>
-<span class="sourceLineNo">1711</span> Threads.sleep(250);<a name="line.1711"></a>
-<span class="sourceLineNo">1712</span> servers = master.getServerManager().createDestinationServersList();<a name="line.1712"></a>
-<span class="sourceLineNo">1713</span> }<a name="line.1713"></a>
-<span class="sourceLineNo">1714</span><a name="line.1714"></a>
-<span class="sourceLineNo">1715</span> if (!systemHRIs.isEmpty()) {<a name="line.1715"></a>
-<span class="sourceLineNo">1716</span> // System table regions requiring reassignment are present, get region servers<a name="line.1716"></a>
-<span class="sourceLineNo">1717</span> // not available for system table regions<a name="line.1717"></a>
-<span class="sourceLineNo">1718</span> final List<ServerName> excludeServers = getExcludedServersForSystemTable();<a name="line.1718"></a>
-<span class="sourceLineNo">1719</span> List<ServerName> serversForSysTables = servers.stream()<a name="line.1719"></a>
-<span class="sourceLineNo">1720</span> .filter(s -> !excludeServers.contains(s)).collect(Collectors.toList());<a name="line.1720"></a>
-<span class="sourceLineNo">1721</span> if (serversForSysTables.isEmpty()) {<a name="line.1721"></a>
-<span class="sourceLineNo">1722</span> LOG.warn("Filtering old server versions and the excluded produced an empty set; " +<a name="line.1722"></a>
-<span class="sourceLineNo">1723</span> "instead considering all candidate servers!");<a name="line.1723"></a>
-<span class="sourceLineNo">1724</span> }<a name="line.1724"></a>
-<span class="sourceLineNo">1725</span> LOG.debug("Processing assignQueue; systemServersCount=" + serversForSysTables.size() +<a name="line.1725"></a>
-<span class="sourceLineNo">1726</span> ", allServersCount=" + servers.size());<a name="line.1726"></a>
-<span class="sourceLineNo">1727</span> processAssignmentPlans(regions, null, systemHRIs,<a name="line.1727"></a>
-<span class="sourceLineNo">1728</span> serversForSysTables.isEmpty()? servers: serversForSysTables);<a name="line.1728"></a>
-<span class="sourceLineNo">1729</span> }<a name="line.1729"></a>
-<span class="sourceLineNo">1730</span><a name="line.1730"></a>
-<span class="sourceLineNo">1731</span> processAssignmentPlans(regions, retainMap, userHRIs, servers);<a name="line.1731"></a>
-<span class="sourceLineNo">1732</span> }<a name="line.1732"></a>
+<span class="sourceLineNo">1707</span> private void processAssignQueue() {<a name="line.1707"></a>
+<span class="sourceLineNo">1708</span> final HashMap<RegionInfo, RegionStateNode> regions = waitOnAssignQueue();<a name="line.1708"></a>
+<span class="sourceLineNo">1709</span> if (regions == null || regions.size() == 0 || !isRunning()) {<a name="line.1709"></a>
+<span class="sourceLineNo">1710</span> return;<a name="line.1710"></a>
+<span class="sourceLineNo">1711</span> }<a name="line.1711"></a>
+<span class="sourceLineNo">1712</span><a name="line.1712"></a>
+<span class="sourceLineNo">1713</span> if (LOG.isTraceEnabled()) {<a name="line.1713"></a>
+<span class="sourceLineNo">1714</span> LOG.trace("PROCESS ASSIGN QUEUE regionCount=" + regions.size());<a name="line.1714"></a>
+<span class="sourceLineNo">1715</span> }<a name="line.1715"></a>
+<span class="sourceLineNo">1716</span><a name="line.1716"></a>
+<span class="sourceLineNo">1717</span> // TODO: Optimize balancer. pass a RegionPlan?<a name="line.1717"></a>
+<span class="sourceLineNo">1718</span> final HashMap<RegionInfo, ServerName> retainMap = new HashMap<>();<a name="line.1718"></a>
+<span class="sourceLineNo">1719</span> final List<RegionInfo> userHRIs = new ArrayList<>(regions.size());<a name="line.1719"></a>
+<span class="sourceLineNo">1720</span> // Regions for system tables requiring reassignment<a name="line.1720"></a>
+<span class="sourceLineNo">1721</span> final List<RegionInfo> systemHRIs = new ArrayList<>();<a name="line.1721"></a>
+<span class="sourceLineNo">1722</span> for (RegionStateNode regionStateNode: regions.values()) {<a name="line.1722"></a>
+<span class="sourceLineNo">1723</span> boolean sysTable = regionStateNode.isSystemTable();<a name="line.1723"></a>
+<span class="sourceLineNo">1724</span> final List<RegionInfo> hris = sysTable? systemHRIs: userHRIs;<a name="line.1724"></a>
+<span class="sourceLineNo">1725</span> if (regionStateNode.getRegionLocation() != null) {<a name="line.1725"></a>
+<span class="sourceLineNo">1726</span> retainMap.put(regionStateNode.getRegionInfo(), regionStateNode.getRegionLocation());<a name="line.1726"></a>
+<span class="sourceLineNo">1727</span> } else {<a name="line.1727"></a>
+<span class="sourceLineNo">1728</span> hris.add(regionStateNode.getRegionInfo());<a name="line.1728"></a>
+<span class="sourceLineNo">1729</span> }<a name="line.1729"></a>
+<span class="sourceLineNo">1730</span> }<a name="line.1730"></a>
+<span class="sourceLineNo">1731</span><a name="line.1731"></a>
+<span class="sourceLineNo">1732</span> // TODO: connect with the listener to invalidate the cache<a name="line.1732"></a>
<span class="sourceLineNo">1733</span><a name="line.1733"></a>
-<span class="sourceLineNo">1734</span> private void processAssignmentPlans(final HashMap<RegionInfo, RegionStateNode> regions,<a name="line.1734"></a>
-<span class="sourceLineNo">1735</span> final HashMap<RegionInfo, ServerName> retainMap, final List<RegionInfo> hris,<a name="line.1735"></a>
-<span class="sourceLineNo">1736</span> final List<ServerName> servers) {<a name="line.1736"></a>
-<span class="sourceLineNo">1737</span> boolean isTraceEnabled = LOG.isTraceEnabled();<a name="line.1737"></a>
-<span class="sourceLineNo">1738</span> if (isTraceEnabled) {<a name="line.1738"></a>
-<span class="sourceLineNo">1739</span> LOG.trace("Available servers count=" + servers.size() + ": " + servers);<a name="line.1739"></a>
-<span class="sourceLineNo">1740</span> }<a name="line.1740"></a>
+<span class="sourceLineNo">1734</span> // TODO use events<a name="line.1734"></a>
+<span class="sourceLineNo">1735</span> List<ServerName> servers = master.getServerManager().createDestinationServersList();<a name="line.1735"></a>
+<span class="sourceLineNo">1736</span> for (int i = 0; servers.size() < 1; ++i) {<a name="line.1736"></a>
+<span class="sourceLineNo">1737</span> // Report every fourth time around this loop; try not to flood log.<a name="line.1737"></a>
+<span class="sourceLineNo">1738</span> if (i % 4 == 0) {<a name="line.1738"></a>
+<span class="sourceLineNo">1739</span> LOG.warn("No servers available; cannot place " + regions.size() + " unassigned regions.");<a name="line.1739"></a>
+<span class="sourceLineNo">1740</span> }<a name="line.1740"></a>
<span class="sourceLineNo">1741</span><a name="line.1741"></a>
-<span class="sourceLineNo">1742</span> final LoadBalancer balancer = getBalancer();<a name="line.1742"></a>
-<span class="sourceLineNo">1743</span> // ask the balancer where to place regions<a name="line.1743"></a>
-<span class="sourceLineNo">1744</span> if (retainMap != null && !retainMap.isEmpty()) {<a name="line.1744"></a>
-<span class="sourceLineNo">1745</span> if (isTraceEnabled) {<a name="line.1745"></a>
-<span class="sourceLineNo">1746</span> LOG.trace("retain assign regions=" + retainMap);<a name="line.1746"></a>
-<span class="sourceLineNo">1747</span> }<a name="line.1747"></a>
-<span class="sourceLineNo">1748</span> try {<a name="line.1748"></a>
-<span class="sourceLineNo">1749</span> acceptPlan(regions, balancer.retainAssignment(retainMap, servers));<a name="line.1749"></a>
-<span class="sourceLineNo">1750</span> } catch (HBaseIOException e) {<a name="line.1750"></a>
-<span class="sourceLineNo">1751</span> LOG.warn("unable to retain assignment", e);<a name="line.1751"></a>
-<span class="sourceLineNo">1752</span> addToPendingAssignment(regions, retainMap.keySet());<a name="line.1752"></a>
-<span class="sourceLineNo">1753</span> }<a name="line.1753"></a>
-<span class="sourceLineNo">1754</span> }<a name="line.1754"></a>
-<span class="sourceLineNo">1755</span><a name="line.1755"></a>
-<span class="sourceLineNo">1756</span> // TODO: Do we need to split retain and round-robin?<a name="line.1756"></a>
-<span class="sourceLineNo">1757</span> // the retain seems to fallback to round-robin/random if the region is not in the map.<a name="line.1757"></a>
-<span class="sourceLineNo">1758</span> if (!hris.isEmpty()) {<a name="line.1758"></a>
-<span class="sourceLineNo">1759</span> Collections.sort(hris, RegionInfo.COMPARATOR);<a name="line.1759"></a>
-<span class="sourceLineNo">1760</span> if (isTraceEnabled) {<a name="line.1760"></a>
-<span class="sourceLineNo">1761</span> LOG.trace("round robin regions=" + hris);<a name="line.1761"></a>
-<span class="sourceLineNo">1762</span> }<a name="line.1762"></a>
-<span class="sourceLineNo">1763</span> try {<a name="line.1763"></a>
-<span class="sourceLineNo">1764</span> acceptPlan(regions, balancer.roundRobinAssignment(hris, servers));<a name="line.1764"></a>
-<span class="sourceLineNo">1765</span> } catch (HBaseIOException e) {<a name="line.1765"></a>
-<span class="sourceLineNo">1766</span> LOG.warn("unable to round-robin assignment", e);<a name="line.1766"></a>
-<span class="sourceLineNo">1767</span> addToPendingAssignment(regions, hris);<a name="line.1767"></a>
-<span class="sourceLineNo">1768</span> }<a name="line.1768"></a>
-<span class="sourceLineNo">1769</span> }<a name="line.1769"></a>
-<span class="sourceLineNo">1770</span> }<a name="line.1770"></a>
-<span class="sourceLineNo">1771</span><a name="line.1771"></a>
-<span class="sourceLineNo">1772</span> private void acceptPlan(final HashMap<RegionInfo, RegionStateNode> regions,<a name="line.1772"></a>
-<span class="sourceLineNo">1773</span> final Map<ServerName, List<RegionInfo>> plan) throws HBaseIOException {<a name="line.1773"></a>
-<span class="sourceLineNo">1774</span> final ProcedureEvent<?>[] events = new ProcedureEvent[regions.size()];<a name="line.1774"></a>
-<span class="sourceLineNo">1775</span> final long st = System.currentTimeMillis();<a name="line.1775"></a>
+<span class="sourceLineNo">1742</span> if (!isRunning()) {<a name="line.1742"></a>
+<span class="sourceLineNo">1743</span> LOG.debug("Stopped! Dropping assign of " + regions.size() + " queued regions.");<a name="line.1743"></a>
+<span class="sourceLineNo">1744</span> return;<a name="line.1744"></a>
+<span class="sourceLineNo">1745</span> }<a name="line.1745"></a>
+<span class="sourceLineNo">1746</span> Threads.sleep(250);<a name="line.1746"></a>
+<span class="sourceLineNo">1747</span> servers = master.getServerManager().createDestinationServersList();<a name="line.1747"></a>
+<span class="sourceLineNo">1748</span> }<a name="line.1748"></a>
+<span class="sourceLineNo">1749</span><a name="line.1749"></a>
+<span class="sourceLineNo">1750</span> if (!systemHRIs.isEmpty()) {<a name="line.1750"></a>
+<span class="sourceLineNo">1751</span> // System table regions requiring reassignment are present, get region servers<a name="line.1751"></a>
+<span class="sourceLineNo">1752</span> // not available for system table regions<a name="line.1752"></a>
+<span class="sourceLineNo">1753</span> final List<ServerName> excludeServers = getExcludedServersForSystemTable();<a name="line.1753"></a>
+<span class="sourceLineNo">1754</span> List<ServerName> serversForSysTables = servers.stream()<a name="line.1754"></a>
+<span class="sourceLineNo">1755</span> .filter(s -> !excludeServers.contains(s)).collect(Collectors.toList());<a name="line.1755"></a>
+<span class="sourceLineNo">1756</span> if (serversForSysTables.isEmpty()) {<a name="line.1756"></a>
+<span class="sourceLineNo">1757</span> LOG.warn("Filtering old server versions and the excluded produced an empty set; " +<a name="line.1757"></a>
+<span class="sourceLineNo">1758</span> "instead considering all candidate servers!");<a name="line.1758"></a>
+<span class="sourceLineNo">1759</span> }<a name="line.1759"></a>
+<span class="sourceLineNo">1760</span> LOG.debug("Processing assignQueue; systemServersCount=" + serversForSysTables.size() +<a name="line.1760"></a>
+<span class="sourceLineNo">1761</span> ", allServersCount=" + servers.size());<a name="line.1761"></a>
+<span class="sourceLineNo">1762</span> processAssignmentPlans(regions, null, systemHRIs,<a name="line.1762"></a>
+<span class="sourceLineNo">1763</span> serversForSysTables.isEmpty()? servers: serversForSysTables);<a name="line.1763"></a>
+<span class="sourceLineNo">1764</span> }<a name="line.1764"></a>
+<span class="sourceLineNo">1765</span><a name="line.1765"></a>
+<span class="sourceLineNo">1766</span> processAssignmentPlans(regions, retainMap, userHRIs, servers);<a name="line.1766"></a>
+<span class="sourceLineNo">1767</span> }<a name="line.1767"></a>
+<span class="sourceLineNo">1768</span><a name="line.1768"></a>
+<span class="sourceLineNo">1769</span> private void processAssignmentPlans(final HashMap<RegionInfo, RegionStateNode> regions,<a name="line.1769"></a>
+<span class="sourceLineNo">1770</span> final HashMap<RegionInfo, ServerName> retainMap, final List<RegionInfo> hris,<a name="line.1770"></a>
+<span class="sourceLineNo">1771</span> final List<ServerName> servers) {<a name="line.1771"></a>
+<span class="sourceLineNo">1772</span> boolean isTraceEnabled = LOG.isTraceEnabled();<a name="line.1772"></a>
+<span class="sourceLineNo">1773</span> if (isTraceEnabled) {<a name="line.1773"></a>
+<span class="sourceLineNo">1774</span> LOG.trace("Available servers count=" + servers.size() + ": " + servers);<a name="line.1774"></a>
+<span class="sourceLineNo">1775</span> }<a name="line.1775"></a>
<span class="sourceLineNo">1776</span><a name="line.1776"></a>
-<span class="sourceLineNo">1777</span> if (plan == null) {<a name="line.1777"></a>
-<span class="sourceLineNo">1778</span> throw new HBaseIOException("unable to compute plans for regions=" + regions.size());<a name="line.1778"></a>
-<span class="sourceLineNo">1779</span> }<a name="line.1779"></a>
-<span class="sourceLineNo">1780</span><a name="line.1780"></a>
-<span class="sourceLineNo">1781</span> if (plan.isEmpty()) return;<a name="line.1781"></a>
-<span class="sourceLineNo">1782</span><a name="line.1782"></a>
-<span class="sourceLineNo">1783</span> int evcount = 0;<a name="line.1783"></a>
-<span class="sourceLineNo">1784</span> for (Map.Entry<ServerName, List<RegionInfo>> entry: plan.entrySet()) {<a name="line.1784"></a>
-<span class="sourceLineNo">1785</span> final ServerName server = entry.getKey();<a name="line.1785"></a>
-<span class="sourceLineNo">1786</span> for (RegionInfo hri: entry.getValue()) {<a name="line.1786"></a>
-<span class="sourceLineNo">1787</span> final RegionStateNode regionNode = regions.get(hri);<a name="line.1787"></a>
-<span class="sourceLineNo">1788</span> regionNode.setRegionLocation(server);<a name="line.1788"></a>
-<span class="sourceLineNo">1789</span> events[evcount++] = regionNode.getProcedureEvent();<a name="line.1789"></a>
-<span class="sourceLineNo">1790</span> }<a name="line.1790"></a>
-<span class="sourceLineNo">1791</span> }<a name="line.1791"></a>
-<span class="sourceLineNo">1792</span> ProcedureEvent.wakeEvents(getProcedureScheduler(), events);<a name="line.1792"></a>
-<span class="sourceLineNo">1793</span><a name="line.1793"></a>
-<span class="sourceLineNo">1794</span> final long et = System.currentTimeMillis();<a name="line.1794"></a>
-<span class="sourceLineNo">1795</span> if (LOG.isTraceEnabled()) {<a name="line.1795"></a>
-<span class="sourceLineNo">1796</span> LOG.trace("ASSIGN ACCEPT " + events.length + " -> " +<a name="line.1796"></a>
-<span class="sourceLineNo">1797</span> StringUtils.humanTimeDiff(et - st));<a name="line.1797"></a>
-<span class="sourceLineNo">1798</span> }<a name="line.1798"></a>
-<span class="sourceLineNo">1799</span> }<a name="line.1799"></a>
-<span class="sourceLineNo">1800</span><a name="line.1800"></a>
-<span class="sourceLineNo">1801</span> private void addToPendingAssignment(final HashMap<RegionInfo, RegionStateNode> regions,<a name="line.1801"></a>
-<span class="sourceLineNo">1802</span> final Collection<RegionInfo> pendingRegions) {<a name="line.1802"></a>
-<span class="sourceLineNo">1803</span> assignQueueLock.lock();<a name="line.1803"></a>
-<span class="sourceLineNo">1804</span> try {<a name="line.1804"></a>
-<span class="sourceLineNo">1805</span> for (RegionInfo hri: pendingRegions) {<a name="line.1805"></a>
-<span class="sourceLineNo">1806</span> pendingAssignQueue.add(regions.get(hri));<a name="line.1806"></a>
-<span class="sourceLineNo">1807</span> }<a name="line.1807"></a>
-<span class="sourceLineNo">1808</span> } finally {<a name="line.1808"></a>
-<span class="sourceLineNo">1809</span> assignQueueLock.unlock();<a name="line.1809"></a>
-<span class="sourceLineNo">1810</span> }<a name="line.1810"></a>
-<span class="sourceLineNo">1811</span> }<a name="line.1811"></a>
-<span class="sourceLineNo">1812</span><a name="line.1812"></a>
-<span class="sourceLineNo">1813</span> /**<a name="line.1813"></a>
-<span class="sourceLineNo">1814</span> * Get a list of servers that this region cannot be assigned to.<a name="line.1814"></a>
-<span class="sourceLineNo">1815</span> * For system tables, we must assign them to a server with highest version.<a name="line.1815"></a>
-<span class="sourceLineNo">1816</span> */<a name="line.1816"></a>
-<span class="sourceLineNo">1817</span> public List<ServerName> getExcludedServersForSystemTable() {<a name="line.1817"></a>
-<span class="sourceLineNo">1818</span> // TODO: This should be a cached list kept by the ServerManager rather than calculated on each<a name="line.1818"></a>
-<span class="sourceLineNo">1819</span> // move or system region assign. The RegionServerTracker keeps list of online Servers with<a name="line.1819"></a>
-<span class="sourceLineNo">1820</span> // RegionServerInfo that includes Version.<a name="line.1820"></a>
-<span class="sourceLineNo">1821</span> List<Pair<ServerName, String>> serverList = master.getServerManager().getOnlineServersList()<a name="line.1821"></a>
-<span class="sourceLineNo">1822</span> .stream()<a name="line.1822"></a>
-<span class="sourceLineNo">1823</span> .map((s)->new Pair<>(s, master.getRegionServerVersion(s)))<a name="line.1823"></a>
-<span class="sourceLineNo">1824</span> .collect(Collectors.toList());<a name="line.1824"></a>
-<span class="sourceLineNo">1825</span> if (serverList.isEmpty()) {<a name="line.1825"></a>
-<span class="sourceLineNo">1826</span> return Collections.emptyList();<a name="line.1826"></a>
-<span class="sourceLineNo">1827</span> }<a name="line.1827"></a>
-<span class="sourceLineNo">1828</span> String highestVersion = Collections.max(serverList,<a name="line.1828"></a>
-<span class="sourceLineNo">1829</span> (o1, o2) -> VersionInfo.compareVersion(o1.getSecond(), o2.getSecond())).getSecond();<a name="line.1829"></a>
-<span class="sourceLineNo">1830</span> return serverList.stream()<a name="line.1830"></a>
-<span class="sourceLineNo">1831</span> .filter((p)->!p.getSecond().equals(highestVersion))<a name="line.1831"></a>
-<span class="sourceLineNo">1832</span> .map(Pair::getFirst)<a name="line.1832"></a>
-<span class="sourceLineNo">1833</span> .collect(Collectors.toList());<a name="line.1833"></a>
+<span class="sourceLineNo">1777</span> final LoadBalancer balancer = getBalancer();<a name="line.1777"></a>
+<span class="sourceLineNo">1778</span> // ask the balancer where to place regions<a name="line.1778"></a>
+<span class="sourceLineNo">1779</span> if (retainMap != null && !retainMap.isEmpty()) {<a name="line.1779"></a>
+<span class="sourceLineNo">1780</span> if (isTraceEnabled) {<a name="line.1780"></a>
+<span class="sourceLineNo">1781</span> LOG.trace("retain assign regions=" + retainMap);<a name="line.1781"></a>
+<span class="sourceLineNo">1782</span> }<a name="line.1782"></a>
+<span class="sourceLineNo">1783</span> try {<a name="line.1783"></a>
+<span class="sourceLineNo">1784</span> acceptPlan(regions, balancer.retainAssignment(retainMap, servers));<a name="line.1784"></a>
+<span class="sourceLineNo">1785</span> } catch (HBaseIOException e) {<a name="line.1785"></a>
+<span class="sourceLineNo">1786</span> LOG.warn("unable to retain assignment", e);<a name="line.1786"></a>
+<span class="sourceLineNo">1787</span> addToPendingAssignment(regions, retainMap.keySet());<a name="line.1787"></a>
+<span class="sourceLineNo">1788</span> }<a name="line.1788"></a>
+<span class="sourceLineNo">1789</span> }<a name="line.1789"></a>
+<span class="sourceLineNo">1790</span><a name="line.1790"></a>
+<span class="sourceLineNo">1791</span> // TODO: Do we need to split retain and round-robin?<a name="line.1791"></a>
+<span class="sourceLineNo">1792</span> // the retain seems to fallback to round-robin/random if the region is not in the map.<a name="line.1792"></a>
+<span class="sourceLineNo">1793</span> if (!hris.isEmpty()) {<a name="line.1793"></a>
+<span class="sourceLineNo">1794</span> Collections.sort(hris, RegionInfo.COMPARATOR);<a name="line.1794"></a>
+<span class="sourceLineNo">1795</span> if (isTraceEnabled) {<a name="line.1795"></a>
+<span class="sourceLineNo">1796</span> LOG.trace("round robin regions=" + hris);<a name="line.1796"></a>
+<span class="sourceLineNo">1797</span> }<a name="line.1797"></a>
+<span class="sourceLineNo">1798</span> try {<a name="line.1798"></a>
+<span class="sourceLineNo">1799</span> acceptPlan(regions, balancer.roundRobinAssignment(hris, servers));<a name="line.1799"></a>
+<span class="sourceLineNo">1800</span> } catch (HBaseIOException e) {<a name="line.1800"></a>
+<span class="sourceLineNo">1801</span> LOG.warn("unable to round-robin assignment", e);<a name="line.1801"></a>
+<span class="sourceLineNo">1802</span> addToPendingAssignment(regions, hris);<a name="line.1802"></a>
+<span class="sourceLineNo">1803</span> }<a name="line.1803"></a>
+<span class="sourceLineNo">1804</span> }<a name="line.1804"></a>
+<span class="sourceLineNo">1805</span> }<a name="line.1805"></a>
+<span class="sourceLineNo">1806</span><a name="line.1806"></a>
+<span class="sourceLineNo">1807</span> private void acceptPlan(final HashMap<RegionInfo, RegionStateNode> regions,<a name="line.1807"></a>
+<span class="sourceLineNo">1808</span> final Map<ServerName, List<RegionInfo>> plan) throws HBaseIOException {<a name="line.1808"></a>
+<span class="sourceLineNo">1809</span> final ProcedureEvent<?>[] events = new ProcedureEvent[regions.size()];<a name="line.1809"></a>
+<span class="sourceLineNo">1810</span> final long st = System.currentTimeMillis();<a name="line.1810"></a>
+<span class="sourceLineNo">1811</span><a name="line.1811"></a>
+<span class="sourceLineNo">1812</span> if (plan == null) {<a name="line.1812"></a>
+<span class="sourceLineNo">1813</span> throw new HBaseIOException("unable to compute plans for regions=" + regions.size());<a name="line.1813"></a>
+<span class="sourceLineNo">1814</span> }<a name="line.1814"></a>
+<span class="sourceLineNo">1815</span><a name="line.1815"></a>
+<span class="sourceLineNo">1816</span> if (plan.isEmpty()) return;<a name="line.1816"></a>
+<span class="sourceLineNo">1817</span><a name="line.1817"></a>
+<span class="sourceLineNo">1818</span> int evcount = 0;<a name="line.1818"></a>
+<span class="sourceLineNo">1819</span> for (Map.Entry<ServerName, List<RegionInfo>> entry: plan.entrySet()) {<a name="line.1819"></a>
+<span class="sourceLineNo">1820</span> final ServerName server = entry.getKey();<a name="line.1820"></a>
+<span class="sourceLineNo">1821</span> for (RegionInfo hri: entry.getValue()) {<a name="line.1821"></a>
+<span class="sourceLineNo">1822</span> final RegionStateNode regionNode = regions.get(hri);<a name="line.1822"></a>
+<span class="sourceLineNo">1823</span> regionNode.setRegionLocation(server);<a name="line.1823"></a>
+<span class="sourceLineNo">1824</span> events[evcount++] = regionNode.getProcedureEvent();<a name="line.1824"></a>
+<span class="sourceLineNo">1825</span> }<a name="line.1825"></a>
+<span class="sourceLineNo">1826</span> }<a name="line.1826"></a>
+<span class="so
<TRUNCATED>