You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/07 19:18:04 UTC

[GitHub] [airflow] Taragolis commented on a diff in pull request #28187: Add IAM authentication to Amazon Redshift Connection by AWS Connection

Taragolis commented on code in PR #28187:
URL: https://github.com/apache/airflow/pull/28187#discussion_r1042589864


##########
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##########
@@ -22,6 +22,8 @@
 from sqlalchemy.engine.url import URL
 
 from airflow.compat.functools import cached_property
+from airflow.models.connection import Connection

Review Comment:
   Me use Connection only for annotation so we could specify that it uses only for it
   
   https://github.com/apache/airflow/blob/5802469fbc452a5727c938f033f2753571989d92/airflow/providers/amazon/aws/hooks/base_aws.py#L56-L59
   
   In this module there is small chance that we got circular import error but still better to use it inside `if TYPE_CHECKING` block



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org