You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by gr...@apache.org on 2019/05/02 12:45:54 UTC
[kudu] 03/04: [backup] Hide scanLeaderOnly option
This is an automated email from the ASF dual-hosted git repository.
granthenke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit d256cd1e40570820ab460210a92cd5f347617b10
Author: Grant Henke <gr...@apache.org>
AuthorDate: Fri Apr 26 12:50:32 2019 -0500
[backup] Hide scanLeaderOnly option
Marks the scanLeaderOnly option as hidden given
we don’t expect it to be used in the common case.
Change-Id: Ia4cdd1ec95fee09de248452bce198682b4d150dd
Reviewed-on: http://gerrit.cloudera.org:8080/13172
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
.../src/main/scala/org/apache/kudu/backup/Options.scala | 13 +++++++------
.../src/test/scala/org/apache/kudu/backup/TestOptions.scala | 2 --
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala b/java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
index b8e1a15..df9eaee 100644
--- a/java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
+++ b/java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
@@ -110,18 +110,19 @@ object BackupOptions {
"Default: " + DefaultScanRequestTimeoutMs)
.optional()
- opt[Boolean]("scanLeaderOnly")
- .action((v, o) => o.copy(scanLeaderOnly = v))
- .text("If true scans will only use the leader replica, otherwise scans will take place " +
- "at the closest replica. Default: " + DefaultScanLeaderOnly)
- .optional()
-
opt[Long]("keepAlivePeriodMs")
.action((v, o) => o.copy(keepAlivePeriodMs = v))
.text("Sets the period at which to send keep-alive requests to the tablet server to " +
"ensure that scanners do not time out. Default: " + DefaultKeepAlivePeriodMs)
.optional()
+ opt[Boolean]("scanLeaderOnly")
+ .action((v, o) => o.copy(scanLeaderOnly = v))
+ .text("If true scans will only use the leader replica, otherwise scans will take place " +
+ "at the closest replica. Default: " + DefaultScanLeaderOnly)
+ .hidden()
+ .optional()
+
opt[String]("format")
.action((v, o) => o.copy(format = v))
.text("The file format to use when writing the data. Default: " + DefaultFormat)
diff --git a/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala b/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala
index ea5f053..dd7e28e 100644
--- a/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala
+++ b/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala
@@ -36,8 +36,6 @@ class TestOptions extends KuduTestSuite {
| --scanBatchSize <value> The maximum number of bytes returned by the scanner, on each batch. Default: 20971520
| --scanRequestTimeoutMs <value>
| Sets how long in milliseconds each scan request to a server can last. Default: 30000
- | --scanLeaderOnly <value>
- | If true scans will only use the leader replica, otherwise scans will take place at the closest replica. Default: false
| --keepAlivePeriodMs <value>
| Sets the period at which to send keep-alive requests to the tablet server to ensure that scanners do not time out. Default: 15000
| --help prints this usage text