[GitHub] [tvm] stoa commented on a change in pull request #9363: STM32 performance and validation apps examples

[GitBox <gi...@apache.org>]

stoa commented on a change in pull request #9363:
URL: https://github.com/apache/tvm/pull/9363#discussion_r736625985



##########
File path: apps/microtvm/stm32/Src/Validation/pb_decode.c
##########
@@ -0,0 +1,1528 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file pb_decode.c
+ * \brief decode a protobuf using minimal resources.
+ *        2011 Petteri Aimonen <jp...@kapsi.fi>
+ */

Review comment:
       @tkonolige @delorme-jm
   True.
   The nanopb license allows to use the files provided the original copyright is included.
   There are 5 files related to the nanopb project. 
   3 of them: pb_common.c, pb_encoder.c, and pb_decoder.c come from the project source. We do not update them and would like to avoid having to keep up with the original project - we simply use a particular fixed version. This could be added as a 3rdparty submodule, although it seems too heavy relative to the use we make of them.
   The 2 other files: stm32msg.pb.c, stm32msg_pb2.py are generated via the nanopb. Therefore cannot be included with the 3rdparty submodule, however require the original copyright notice.
   I would prefer to include the notice with the 5 files - this is allowed and corresponds exactly to the way these files are used. However, I do not know how to make the TVM admit files with a nanopb copyright notice. Can you tell me how to do it ?
   Arthur




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org