You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "fishy (via GitHub)" <gi...@apache.org> on 2023/04/09 18:13:22 UTC

[GitHub] [thrift] fishy commented on a diff in pull request #2779: java lib and build tool chain: gradle 8.0.2 and JDK 19

fishy commented on code in PR #2779:
URL: https://github.com/apache/thrift/pull/2779#discussion_r1161322478


##########
.github/workflows/build.yml:
##########
@@ -137,14 +137,14 @@ jobs:
     needs: compiler
     runs-on: ubuntu-20.04
     env:
-      GRADLE_VERSION: "7.6"
+      GRADLE_VERSION: "8.0.2"
     steps:
       - uses: actions/checkout@v3
 
       - uses: actions/setup-java@v3
         with:
           distribution: temurin
-          java-version: 17
+          java-version: 19

Review Comment:
   19 is not an LTS version, we should stick with LTS versions? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org