[GitHub] [beam] pabloem commented on a change in pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #15761:
URL: https://github.com/apache/beam/pull/15761#discussion_r733013050



##########
File path: settings.gradle.kts
##########
@@ -187,6 +187,9 @@ include(":sdks:java:testing:load-tests")
 include(":sdks:java:testing:test-utils")
 include(":sdks:java:testing:tpcds")
 include(":sdks:java:testing:watermarks")
+include(":playground")
+include(":playground:backend")
+include(":playground:frontend")

Review comment:
       can you add these in alphabetical order? this would make it appear before sdks, since p goes before s : )

##########
File path: build.gradle.kts
##########
@@ -249,6 +247,17 @@ task("goIntegrationTests") {
   dependsOn(":runners:google-cloud-dataflow-java:worker:shadowJar")
 }
 
+task("playgroundPreCommit") {
+  dependsOn(":playground:backend:format")

Review comment:
       would format modify the code? if so, then it should not be part of precommit




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org