You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Aleksei-grovety (via GitHub)" <gi...@apache.org> on 2023/06/26 14:02:49 UTC
[GitHub] [tvm] Aleksei-grovety opened a new pull request, #15159: [microNPU][ETHOSU] Fix compiler attributes types
Aleksei-grovety opened a new pull request, #15159:
URL: https://github.com/apache/tvm/pull/15159
The bool type is replaced with tvm::Bool to pass these parameters to tvmc via the command line.
cc @neildhickey, @lhutton1, @ekalda, @leandron
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Aleksei-grovety commented on a diff in pull request #15159: [microNPU][ETHOSU] Fix compiler attributes types
Posted by "Aleksei-grovety (via GitHub)" <gi...@apache.org>.
Aleksei-grovety commented on code in PR #15159:
URL: https://github.com/apache/tvm/pull/15159#discussion_r1244957475
##########
tests/python/driver/tvmc/test_target_options.py:
##########
@@ -96,6 +96,21 @@ def test_include_known_codegen():
}
+@tvm.testing.requires_ethosu
+def test_ethosu_compiler_attrs():
+ # It is checked that the represented string and boolean types in the
+ # EthosUCompilerConfigNode structure can be passed via the command line
+ parser = argparse.ArgumentParser()
+ generate_target_args(parser)
+ parsed, _ = parser.parse_known_args(
+ ["--target-ethos-u-accelerator_config=ethos-u55-32", "--target-ethos-u-enable_cascader=1"]
+ )
+ print(reconstruct_target_args(parsed))
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on a diff in pull request #15159: [microNPU][ETHOSU] Fix compiler attributes types
Posted by "lhutton1 (via GitHub)" <gi...@apache.org>.
lhutton1 commented on code in PR #15159:
URL: https://github.com/apache/tvm/pull/15159#discussion_r1244908917
##########
tests/python/driver/tvmc/test_target_options.py:
##########
@@ -96,6 +96,21 @@ def test_include_known_codegen():
}
+@tvm.testing.requires_ethosu
+def test_ethosu_compiler_attrs():
+ # It is checked that the represented string and boolean types in the
+ # EthosUCompilerConfigNode structure can be passed via the command line
+ parser = argparse.ArgumentParser()
+ generate_target_args(parser)
+ parsed, _ = parser.parse_known_args(
+ ["--target-ethos-u-accelerator_config=ethos-u55-32", "--target-ethos-u-enable_cascader=1"]
+ )
+ print(reconstruct_target_args(parsed))
Review Comment:
nit: remove print
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #15159: [microNPU][ETHOSU] Fix compiler attributes types
Posted by "lhutton1 (via GitHub)" <gi...@apache.org>.
lhutton1 commented on PR #15159:
URL: https://github.com/apache/tvm/pull/15159#issuecomment-1612624166
Thanks @Aleksei-grovety!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #15159: [microNPU][ETHOSU] Fix compiler attributes types
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15159:
URL: https://github.com/apache/tvm/pull/15159#issuecomment-1607560396
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @Mousius, @leandron <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 merged pull request #15159: [microNPU][ETHOSU] Fix compiler attributes types
Posted by "lhutton1 (via GitHub)" <gi...@apache.org>.
lhutton1 merged PR #15159:
URL: https://github.com/apache/tvm/pull/15159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org