You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by "Jake Maes (JIRA)" <ji...@apache.org> on 2017/06/26 22:39:00 UTC

[jira] [Created] (SAMZA-1347) GroupByContainerIds NPE if containerIds list is null

Jake Maes created SAMZA-1347:
--------------------------------

             Summary: GroupByContainerIds NPE if containerIds list is null
                 Key: SAMZA-1347
                 URL: https://issues.apache.org/jira/browse/SAMZA-1347
             Project: Samza
          Issue Type: Improvement
            Reporter: Jake Maes
            Assignee: Jake Maes


Another low-hanging fruit. The null check in group() happens AFTER checking the size of containerIds. These statements should be reordered. 

Also, Since the group(tasks) method always calls the group(tasks, containerIds) method, lets just move all the safety checks there.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)