You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/07 19:01:41 UTC

[GitHub] [druid] abhishekrb19 commented on issue #9622: Preserve the null values for numeric type dimensions post-compaction.

abhishekrb19 commented on issue #9622: Preserve the null values for numeric type dimensions post-compaction.
URL: https://github.com/apache/druid/pull/9622#issuecomment-610564783
 
 
   @clintropolis, thanks for the pointer! I went ahead and followed one of your suggestions to add similar selector `TestNullable*ColumnSelector` for each type that returns `null` based on the values initialized. 
   
   I verified that the newly added test cases didn't work as expected _before_ the fix in this patch, but does _after_ the fix.
   
   Could you please take a look? Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org