You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemml.apache.org by Luciano Resende <lu...@gmail.com> on 2017/01/20 23:56:31 UTC
Building releases now that we have branches
I just saw a commit into master :
[maven-release-plugin] prepare release v0.12.0-incubating-rc2” --tag
Please be very careful with what we are trying to do. After 0.12 RC, we
have moved the development of 0.12 wich is based on Spark 1.6.x to a 0.12
branch, but the commit info above makes me think that we are trying to cut
a 0.12 RC2 from master which then will bring the Spark 2.0 support which is
not desirable and is scheduled for 0.12.
Also note that master is now in a corrupted state, where the pom is
corrupted (particularly the scmelement)
<scm> <connection>scm:git:git@github.com:apache/incubator-systemml</
connection> <developerConnection>scm:git:
https://git-wip-us.apache.org/repos/asf/incubator-systemml</
developerConnection> <url>
https://git-wip-us.apache.org/repos/asf?p=incubator-systemml.git</url>
<tag>v0.12.0-incubating-rc2”
--tag</tag> </scm>
Please revert the commit in master
(083c9c4ca0bc3deeb04f2552470a9e187b80bcf4)
Now, for the RC2, we will probably need to make the RC based on the commit
hash from the top of the 0.12 branch and do a little investigation/research
if there is any other changes to make the release prepare to modify the pom
from the branch and google is probably your friend here.
--
Luciano Resende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: Building releases now that we have branches
Posted by Luciano Resende <lu...@gmail.com>.
On Wed, Jan 25, 2017 at 1:25 PM, <du...@gmail.com> wrote:
> Yeah as long as the branch is checked out with Git, Maven should work as
> intended.
>
>
Do you need to change the scm section in pom in any way ?
--
Luciano Resende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: Building releases now that we have branches
Posted by du...@gmail.com.
Yeah as long as the branch is checked out with Git, Maven should work as intended.
--
Mike Dusenberry
GitHub: github.com/dusenberrymw
LinkedIn: linkedin.com/in/mikedusenberry
Sent from my iPhone.
> On Jan 23, 2017, at 10:32 AM, Arvind Surve <ac...@yahoo.com.INVALID> wrote:
>
> I have reverted the changes on master branch on Friday.
> Investigating the maven changes
>
> ------------------ Arvind Surve Spark Technology Center http://www.spark.tc/
>
> From: Luciano Resende <lu...@gmail.com>
> To: dev@systemml.incubator.apache.org
> Sent: Friday, January 20, 2017 5:00 PM
> Subject: Re: Building releases now that we have branches
>
>> On Fri, Jan 20, 2017 at 4:51 PM, <fs...@posteo.de> wrote:
>>
>> Yes, this commit probably shouldn't have gone to master...
>> Can one of the commiters revert it?
>>
>>
> I would leave for the Release manager to revert it
>
>
>> Now, for the RC2, we will probably need to make the RC based on the commit
>>> hash from the top of the 0.12 branch and do a little
>>> investigation/research
>>> if there is any other changes to make the release prepare to modify the
>>> pom
>>> from the branch and google is probably your friend here.
>>>
>>
>> Not sure what you mean here - can't we tag a new release candidate on the
>> branch-0.12? What (except for the tag) would have to change in the pom?
>>
>> -Felix
>>
>>
> We currently use a script to create the release, and it will call maven
> release:prepare which change the pom version to release version, and them
> modify to the new development version. I just want to make sure it will
> make these changes on the branch and not on master. Not sure if maven needs
> any additional magic for that, it will be our first time running the script
> on a branch.
>
> --
> Luciano Resende
> http://twitter.com/lresende1975
> http://lresende.blogspot.com/
>
>
Re: Building releases now that we have branches
Posted by Arvind Surve <ac...@yahoo.com.INVALID>.
I have reverted the changes on master branch on Friday.
Investigating the maven changes
------------------ Arvind Surve Spark Technology Center http://www.spark.tc/
From: Luciano Resende <lu...@gmail.com>
To: dev@systemml.incubator.apache.org
Sent: Friday, January 20, 2017 5:00 PM
Subject: Re: Building releases now that we have branches
On Fri, Jan 20, 2017 at 4:51 PM, <fs...@posteo.de> wrote:
> Yes, this commit probably shouldn't have gone to master...
> Can one of the commiters revert it?
>
>
I would leave for the Release manager to revert it
> Now, for the RC2, we will probably need to make the RC based on the commit
>> hash from the top of the 0.12 branch and do a little
>> investigation/research
>> if there is any other changes to make the release prepare to modify the
>> pom
>> from the branch and google is probably your friend here.
>>
>
> Not sure what you mean here - can't we tag a new release candidate on the
> branch-0.12? What (except for the tag) would have to change in the pom?
>
> -Felix
>
>
We currently use a script to create the release, and it will call maven
release:prepare which change the pom version to release version, and them
modify to the new development version. I just want to make sure it will
make these changes on the branch and not on master. Not sure if maven needs
any additional magic for that, it will be our first time running the script
on a branch.
--
Luciano Resende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: Building releases now that we have branches
Posted by Luciano Resende <lu...@gmail.com>.
On Fri, Jan 20, 2017 at 4:51 PM, <fs...@posteo.de> wrote:
> Yes, this commit probably shouldn't have gone to master...
> Can one of the commiters revert it?
>
>
I would leave for the Release manager to revert it
> Now, for the RC2, we will probably need to make the RC based on the commit
>> hash from the top of the 0.12 branch and do a little
>> investigation/research
>> if there is any other changes to make the release prepare to modify the
>> pom
>> from the branch and google is probably your friend here.
>>
>
> Not sure what you mean here - can't we tag a new release candidate on the
> branch-0.12? What (except for the tag) would have to change in the pom?
>
> -Felix
>
>
We currently use a script to create the release, and it will call maven
release:prepare which change the pom version to release version, and them
modify to the new development version. I just want to make sure it will
make these changes on the branch and not on master. Not sure if maven needs
any additional magic for that, it will be our first time running the script
on a branch.
--
Luciano Resende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: Building releases now that we have branches
Posted by fs...@posteo.de.
Yes, this commit probably shouldn't have gone to master...
Can one of the commiters revert it?
> Now, for the RC2, we will probably need to make the RC based on the
> commit
> hash from the top of the 0.12 branch and do a little
> investigation/research
> if there is any other changes to make the release prepare to modify the
> pom
> from the branch and google is probably your friend here.
Not sure what you mean here - can't we tag a new release candidate on
the branch-0.12? What (except for the tag) would have to change in the
pom?
-Felix
Am 21.01.2017 00:56 schrieb Luciano Resende:
> I just saw a commit into master :
> [maven-release-plugin] prepare release v0.12.0-incubating-rc2” --tag
>
> Please be very careful with what we are trying to do. After 0.12 RC, we
> have moved the development of 0.12 wich is based on Spark 1.6.x to a
> 0.12
> branch, but the commit info above makes me think that we are trying to
> cut
> a 0.12 RC2 from master which then will bring the Spark 2.0 support
> which is
> not desirable and is scheduled for 0.12.
>
> Also note that master is now in a corrupted state, where the pom is
> corrupted (particularly the scmelement)
>
> <scm> <connection>scm:git:git@github.com:apache/incubator-systemml</
> connection> <developerConnection>scm:git:
> https://git-wip-us.apache.org/repos/asf/incubator-systemml</
> developerConnection> <url>
> https://git-wip-us.apache.org/repos/asf?p=incubator-systemml.git</url>
> <tag>v0.12.0-incubating-rc2”
> --tag</tag> </scm>
>
> Please revert the commit in master
> (083c9c4ca0bc3deeb04f2552470a9e187b80bcf4)
>
>
> Now, for the RC2, we will probably need to make the RC based on the
> commit
> hash from the top of the 0.12 branch and do a little
> investigation/research
> if there is any other changes to make the release prepare to modify the
> pom
> from the branch and google is probably your friend here.