You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexey A. Ivanov (JIRA)" <ji...@apache.org> on 2007/01/17 08:02:27 UTC
[jira] Commented: (HARMONY-1767)
[classlib][swing]javax.swing.text.ComponentView(Element) throws unexpected
NullPointerException on user's implementation
[ https://issues.apache.org/jira/browse/HARMONY-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465369 ]
Alexey A. Ivanov commented on HARMONY-1767:
-------------------------------------------
Vasily,
Can you please update the test-case not to use html package classes and provide the test for StyleConstants where you put your fix?
> [classlib][swing]javax.swing.text.ComponentView(Element) throws unexpected NullPointerException on user's implementation
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1767
> URL: https://issues.apache.org/jira/browse/HARMONY-1767
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Svetlana Samoilenko
> Assigned To: Mark Hindess
> Priority: Trivial
> Attachments: ComponentViewTest.patch, Harmony-1767-Test.patch, Harmony-1767.patch
>
>
> Harmony throws unexpected NPE for ComponentView(Element) on user's Element implementation.
> RI works correctly.
> Test for reproducing:
> import junit.framework.TestCase;
> import javax.swing.text.*;
> import javax.swing.text.html.*;
> public class test extends TestCase {
>
> public void testSetParent_View(){
> HTMLDocument doc = new HTMLDocument();
> Element e=doc.getDefaultRootElement();
> ComponentView obj = new ComponentView(new testElement());
> obj.setParent(new ListView(e));
> }
> private class testElement implements Element {
> public boolean isLeaf() {
> return false;
> }
> public Element getElement(int p0) {
> return null;
> }
> public int getElementCount() {
> return 0;
> }
> public int getElementIndex(int p0) {
> return 0;
> }
> public int getEndOffset() {
> return 0;
> }
> public int getStartOffset() {
> return 0;
> }
> public AttributeSet getAttributes() {
> return null;
> }
> public String getName() {
> return "AA";
> }
> public Element getParentElement() {
> return null;
> }
> public Document getDocument() {
> return null;
> }
> }
> }
> HARMONY output:
> =============
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r450941, (Sep 28 2006), Windows/ia32/msvc 1310, release build
> http://incubator.apache.org/harmony
> .E
> Time: 0.578
> There was 1 error:
> 1) testSetParent_View(test)java.lang.NullPointerException
> at javax.swing.text.StyleConstants.getComponent(StyleConstants.java:202)
> at javax.swing.text.ComponentView.createComponent(ComponentView.java:182)
> at javax.swing.text.ComponentView.setParent(ComponentView.java:163)
> at test.testSetParent_View(test.java:9)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> FAILURES!!!
> Tests run: 1, Failures: 0, Errors: 1
> SUN output:
> ==========
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> .
> Time: 0.01
> OK (1 test
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (HARMONY-1767) [classlib][swing]javax.swing.text.ComponentView(Element) throws unexpected NullPointerException on user's implementation
Posted by Mark Hindess <ma...@googlemail.com>.
Done. And many thanks for taking the time to look at it.
-Mark.
On 18 January 2007 at 21:52, "Zakharov, Vasily M" <va...@intel.com> wrote:
> Mark,
>
> Could you please reopen the issue, so that I could attach another patch?
>
> Thank you!
>
> Vasily
>
>
> -----Original Message-----
> From: Alexey A. Ivanov (JIRA) [mailto:jira@apache.org]=20
> Sent: Wednesday, January 17, 2007 10:02 AM
> To: commits@harmony.apache.org
> Subject: [jira] Commented: (HARMONY-1767)
> [classlib][swing]javax.swing.text.ComponentView(Element) throws
> unexpected NullPointerException on user's implementation
>
>
> [
> https://issues.apache.org/jira/browse/HARMONY-1767?page=3Dcom.atlassian.j=
> i
> ra.plugin.system.issuetabpanels:comment-tabpanel#action_12465369 ]=20
>
> Alexey A. Ivanov commented on HARMONY-1767:
> -------------------------------------------
>
> Vasily,
> Can you please update the test-case not to use html package classes and
> provide the test for StyleConstants where you put your fix?
>
> > [classlib][swing]javax.swing.text.ComponentView(Element) throws
> unexpected NullPointerException on user's implementation
> >
> ------------------------------------------------------------------------
> ------------------------------------------------
> >
> > Key: HARMONY-1767
> > URL:
> https://issues.apache.org/jira/browse/HARMONY-1767
> > Project: Harmony
> > Issue Type: Bug
> > Components: Classlib
> > Reporter: Svetlana Samoilenko
> > Assigned To: Mark Hindess
> > Priority: Trivial
> > Attachments: ComponentViewTest.patch, Harmony-1767-Test.patch,
> Harmony-1767.patch
> >
> >
> > Harmony throws unexpected NPE for ComponentView(Element) on user's
> Element implementation.
> > RI works correctly.
> > Test for reproducing:
> > import junit.framework.TestCase;
> > import javax.swing.text.*;
> > import javax.swing.text.html.*;
> > public class test extends TestCase { =20
> > =20
> > public void testSetParent_View(){ =09
> > HTMLDocument doc =3D new HTMLDocument();
> > Element e=3Ddoc.getDefaultRootElement();
> > ComponentView obj =3D new ComponentView(new testElement());
> > obj.setParent(new ListView(e)); =20
> > } =20
> > private class testElement implements Element {
> > public boolean isLeaf() {
> > return false;
> > }
> > public Element getElement(int p0) {
> > return null;
> > }
> > public int getElementCount() {
> > return 0;
> > }
> > public int getElementIndex(int p0) {
> > return 0;
> > }
> > public int getEndOffset() {
> > return 0;
> > } =20
> > public int getStartOffset() {
> > return 0;
> > } =20
> > public AttributeSet getAttributes() {
> > return null;
> > }
> > public String getName() {
> > return "AA";
> > }
> > public Element getParentElement() {
> > return null;
> > }
> > public Document getDocument() {
> > return null;
> > }
> > }
> > }
> > HARMONY output:
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software
> Foundation or its licensors, as applicable.
> > java version "1.5.0"
> > pre-alpha : not complete or compatible
> > svn =3D r450941, (Sep 28 2006), Windows/ia32/msvc 1310, release build
> > http://incubator.apache.org/harmony
> > .E
> > Time: 0.578
> > There was 1 error:
> > 1) testSetParent_View(test)java.lang.NullPointerException
> > at
> javax.swing.text.StyleConstants.getComponent(StyleConstants.java:202)
> > at
> javax.swing.text.ComponentView.createComponent(ComponentView.java:182)
> > at
> javax.swing.text.ComponentView.setParent(ComponentView.java:163)
> > at test.testSetParent_View(test.java:9)
> > at
> java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> > FAILURES!!!
> > Tests run: 1, Failures: 0, Errors: 1
> > SUN output:
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > java version "1.5.0_06"
> > Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> > Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> > .
> > Time: 0.01
> > OK (1 test
>
> --=20
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> https://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
> =20
>
RE: [jira] Commented: (HARMONY-1767) [classlib][swing]javax.swing.text.ComponentView(Element) throws unexpected NullPointerException on user's implementation
Posted by "Zakharov, Vasily M" <va...@intel.com>.
Mark,
Could you please reopen the issue, so that I could attach another patch?
Thank you!
Vasily
-----Original Message-----
From: Alexey A. Ivanov (JIRA) [mailto:jira@apache.org]
Sent: Wednesday, January 17, 2007 10:02 AM
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-1767)
[classlib][swing]javax.swing.text.ComponentView(Element) throws
unexpected NullPointerException on user's implementation
[
https://issues.apache.org/jira/browse/HARMONY-1767?page=com.atlassian.ji
ra.plugin.system.issuetabpanels:comment-tabpanel#action_12465369 ]
Alexey A. Ivanov commented on HARMONY-1767:
-------------------------------------------
Vasily,
Can you please update the test-case not to use html package classes and
provide the test for StyleConstants where you put your fix?
> [classlib][swing]javax.swing.text.ComponentView(Element) throws
unexpected NullPointerException on user's implementation
>
------------------------------------------------------------------------
------------------------------------------------
>
> Key: HARMONY-1767
> URL:
https://issues.apache.org/jira/browse/HARMONY-1767
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Svetlana Samoilenko
> Assigned To: Mark Hindess
> Priority: Trivial
> Attachments: ComponentViewTest.patch, Harmony-1767-Test.patch,
Harmony-1767.patch
>
>
> Harmony throws unexpected NPE for ComponentView(Element) on user's
Element implementation.
> RI works correctly.
> Test for reproducing:
> import junit.framework.TestCase;
> import javax.swing.text.*;
> import javax.swing.text.html.*;
> public class test extends TestCase {
>
> public void testSetParent_View(){
> HTMLDocument doc = new HTMLDocument();
> Element e=doc.getDefaultRootElement();
> ComponentView obj = new ComponentView(new testElement());
> obj.setParent(new ListView(e));
> }
> private class testElement implements Element {
> public boolean isLeaf() {
> return false;
> }
> public Element getElement(int p0) {
> return null;
> }
> public int getElementCount() {
> return 0;
> }
> public int getElementIndex(int p0) {
> return 0;
> }
> public int getEndOffset() {
> return 0;
> }
> public int getStartOffset() {
> return 0;
> }
> public AttributeSet getAttributes() {
> return null;
> }
> public String getName() {
> return "AA";
> }
> public Element getParentElement() {
> return null;
> }
> public Document getDocument() {
> return null;
> }
> }
> }
> HARMONY output:
> =============
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software
Foundation or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r450941, (Sep 28 2006), Windows/ia32/msvc 1310, release build
> http://incubator.apache.org/harmony
> .E
> Time: 0.578
> There was 1 error:
> 1) testSetParent_View(test)java.lang.NullPointerException
> at
javax.swing.text.StyleConstants.getComponent(StyleConstants.java:202)
> at
javax.swing.text.ComponentView.createComponent(ComponentView.java:182)
> at
javax.swing.text.ComponentView.setParent(ComponentView.java:163)
> at test.testSetParent_View(test.java:9)
> at
java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> FAILURES!!!
> Tests run: 1, Failures: 0, Errors: 1
> SUN output:
> ==========
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> .
> Time: 0.01
> OK (1 test
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira